Extract common code for versions#1439
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
suvikankare
force-pushed
the
route-versions-extractions
branch
5 times, most recently
from
c4be20b to
b2c45a9
Compare
Huulivoide
left a comment
Huulivoide
left a comment
There was a problem hiding this comment.
@Huulivoide partially reviewed 34 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on suvikankare).
ui/src/components/common/versions/accordionClassNames.ts at r1 (raw file):
Tän vois kokonaan nostaa ylemälle tasolle. Ku näitä luokkia käytetään muuaallakin ku vaan versioissa.
suvikankare
force-pushed
the
route-versions-extractions
branch
from
b2c45a9 to
8927eb6
Compare
suvikankare
left a comment
suvikankare
left a comment
There was a problem hiding this comment.
@suvikankare made 1 comment.
Reviewable status: 25 of 34 files reviewed, 1 unresolved discussion (waiting on Huulivoide).
ui/src/components/common/versions/accordionClassNames.ts at r1 (raw file):
Previously, Huulivoide (Jesse Jaara) wrote…
Tän vois kokonaan nostaa ylemälle tasolle. Ku näitä luokkia käytetään muuaallakin ku vaan versioissa.
Done.
Huulivoide
left a comment
Huulivoide
left a comment
There was a problem hiding this comment.
@Huulivoide partially reviewed 9 files and all commit messages, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on suvikankare).
2 participants
This change is