Required jore stop keyvalues#1444
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
48632b3 to
eb77bfb
Compare
PasiVuohijoki
left a comment
There was a problem hiding this comment.
@PasiVuohijoki made 10 comments.
Reviewable status: 0 of 15 files reviewed, 9 unresolved discussions (waiting on Huulivoide).
cypress/e2e/map/createTerminal.cy.ts line 283 at r1 (raw file):
}, { key: KnownValueKey.Priority, values: ['10'] }, { key: KnownValueKey.StopState, values: ['InOperation'] },
Enumin paikka
cypress/e2e/stop-registry/stopVersions.cy.ts line 75 at r1 (raw file):
values: [(importedId++).toString(10)], }, { key: KnownValueKey.StopState, values: ['InOperation'] },
enumi
cypress/datasets/stopRegistry.ts line 85 at r1 (raw file):
description: { lang: 'fin', value: 'Annankatu 15' }, keyValues: [ ...minimalQuayKeyValues,
Tää on fiksu homma määritellä nämä minimi/toistuvat key valuesit 👍
cypress/datasets/stopRegistry.ts line 250 at r1 (raw file):
keyValues: [ { key: KnownValueKey.Priority, values: ['10'] }, { key: KnownValueKey.StopState, values: ['InOperation'] },
Tässä vois käyttää enumia
cypress/datasets/stopRegistry.ts line 274 at r1 (raw file):
keyValues: [ { key: KnownValueKey.Priority, values: ['10'] }, { key: KnownValueKey.StopState, values: ['InOperation'] },
Tässä vois käyttää enumia
cypress/datasets/stopRegistry.ts line 330 at r1 (raw file):
keyValues: [ { key: KnownValueKey.Priority, values: ['10'] }, { key: KnownValueKey.StopState, values: ['InOperation'] },
Tässäkin vois käyttää enumia
cypress/datasets/stopRegistry.ts line 366 at r1 (raw file):
{ key: KnownValueKey.ValidityEnd, values: ['2052-01-01'] }, { key: KnownValueKey.Priority, values: ['10'] }, { key: KnownValueKey.StopState, values: ['InOperation'] },
Enum
cypress/datasets/stopRegistry.ts line 405 at r1 (raw file):
{ key: KnownValueKey.ValidityStart, values: ['2020-03-20'] }, { key: KnownValueKey.Priority, values: ['10'] }, { key: KnownValueKey.StopState, values: ['InOperation'] },
Enumia tännekin
cypress/datasets/stopRegistry.ts line 431 at r1 (raw file):
{ key: KnownValueKey.ValidityStart, values: ['2020-03-20'] }, { key: KnownValueKey.Priority, values: ['10'] }, { key: KnownValueKey.StopState, values: ['InOperation'] },
Sama homma
cypress/e2e/stop-registry/stopSearch.cy.ts line 1254 at r1 (raw file):
values: [stopPoint.validity_end?.toISODate() ?? null], }, { key: KnownValueKey.StopState, values: ['InOperation'] },
enumi
eb77bfb to
697d6ec
Compare
Huulivoide
left a comment
There was a problem hiding this comment.
@Huulivoide resolved 9 discussions.
Reviewable status: 0 of 15 files reviewed, all discussions resolved (waiting on PasiVuohijoki).
PasiVuohijoki
left a comment
There was a problem hiding this comment.
@PasiVuohijoki reviewed 15 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Huulivoide).
PasiVuohijoki
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on Huulivoide).
E2E: Cleanup code
E2E: Update jore Quay extension seed data
Stop: Set Stop to be in InOpereration state on creation
This change is