Skip to content

Required jore stop keyvalues#1444

Merged
Huulivoide merged 3 commits into
mainfrom
required-jore-stop-keyvalues
Jun 16, 2026
Merged

Required jore stop keyvalues#1444
Huulivoide merged 3 commits into
mainfrom
required-jore-stop-keyvalues

Conversation

@Huulivoide

@Huulivoide Huulivoide commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

E2E: Cleanup code

E2E: Update jore Quay extension seed data

Stop: Set Stop to be in InOpereration state on creation


This change is Reviewable

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@Huulivoide Huulivoide force-pushed the required-jore-stop-keyvalues branch from 48632b3 to eb77bfb Compare June 15, 2026 17:23

@PasiVuohijoki PasiVuohijoki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PasiVuohijoki made 10 comments.
Reviewable status: 0 of 15 files reviewed, 9 unresolved discussions (waiting on Huulivoide).


cypress/e2e/map/createTerminal.cy.ts line 283 at r1 (raw file):

                      },
                      { key: KnownValueKey.Priority, values: ['10'] },
                      { key: KnownValueKey.StopState, values: ['InOperation'] },

Enumin paikka


cypress/e2e/stop-registry/stopVersions.cy.ts line 75 at r1 (raw file):

        values: [(importedId++).toString(10)],
      },
      { key: KnownValueKey.StopState, values: ['InOperation'] },

enumi


cypress/datasets/stopRegistry.ts line 85 at r1 (raw file):

          description: { lang: 'fin', value: 'Annankatu 15' },
          keyValues: [
            ...minimalQuayKeyValues,

Tää on fiksu homma määritellä nämä minimi/toistuvat key valuesit 👍


cypress/datasets/stopRegistry.ts line 250 at r1 (raw file):

          keyValues: [
            { key: KnownValueKey.Priority, values: ['10'] },
            { key: KnownValueKey.StopState, values: ['InOperation'] },

Tässä vois käyttää enumia


cypress/datasets/stopRegistry.ts line 274 at r1 (raw file):

          keyValues: [
            { key: KnownValueKey.Priority, values: ['10'] },
            { key: KnownValueKey.StopState, values: ['InOperation'] },

Tässä vois käyttää enumia


cypress/datasets/stopRegistry.ts line 330 at r1 (raw file):

          keyValues: [
            { key: KnownValueKey.Priority, values: ['10'] },
            { key: KnownValueKey.StopState, values: ['InOperation'] },

Tässäkin vois käyttää enumia


cypress/datasets/stopRegistry.ts line 366 at r1 (raw file):

            { key: KnownValueKey.ValidityEnd, values: ['2052-01-01'] },
            { key: KnownValueKey.Priority, values: ['10'] },
            { key: KnownValueKey.StopState, values: ['InOperation'] },

Enum


cypress/datasets/stopRegistry.ts line 405 at r1 (raw file):

            { key: KnownValueKey.ValidityStart, values: ['2020-03-20'] },
            { key: KnownValueKey.Priority, values: ['10'] },
            { key: KnownValueKey.StopState, values: ['InOperation'] },

Enumia tännekin


cypress/datasets/stopRegistry.ts line 431 at r1 (raw file):

            { key: KnownValueKey.ValidityStart, values: ['2020-03-20'] },
            { key: KnownValueKey.Priority, values: ['10'] },
            { key: KnownValueKey.StopState, values: ['InOperation'] },

Sama homma


cypress/e2e/stop-registry/stopSearch.cy.ts line 1254 at r1 (raw file):

                  values: [stopPoint.validity_end?.toISODate() ?? null],
                },
                { key: KnownValueKey.StopState, values: ['InOperation'] },

enumi

@Huulivoide Huulivoide force-pushed the required-jore-stop-keyvalues branch from eb77bfb to 697d6ec Compare June 16, 2026 10:56

@Huulivoide Huulivoide left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Huulivoide resolved 9 discussions.
Reviewable status: 0 of 15 files reviewed, all discussions resolved (waiting on PasiVuohijoki).

@PasiVuohijoki PasiVuohijoki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PasiVuohijoki reviewed 15 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Huulivoide).

@PasiVuohijoki PasiVuohijoki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Huulivoide).

@Huulivoide Huulivoide merged commit 697d6ec into main Jun 16, 2026
24 checks passed
@Huulivoide Huulivoide deleted the required-jore-stop-keyvalues branch June 16, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants