Corrected logger format. Improved URL processing (#90)

* Added a check for trailing slash in url_input.
* Added a context manager to the load_data method
* Corrected the logger format.

Author: shravandoda

hydra_agent/querying_mechanism.py

@@ -3,6 +3,7 @@
 import logging
 from hydra_agent.hydra_graph import InitialGraph
 import urllib.request
+from urllib.parse import urljoin
 import json
 from hydra_python_core import doc_maker
 from urllib.error import URLError, HTTPError
@@ -29,18 +30,17 @@ def load_data(self, url):
         :return: loaded data
         """
         try:
-            response = urllib.request.urlopen(url)
+            with urllib.request.urlopen(url) as response:
+                return json.loads(response.read().decode('utf-8'))
         except HTTPError as e:
-            logger.info('Error code: ', e.code)
+            logger.error('Error Code: {}'.format(e.code))
             return RequestError("error")
         except URLError as e:
-            logger.info('Reason: ', e.reason)
+            logger.error('Reason: {}'.format(e.reason))
             return RequestError("error")
         except ValueError as e:
-            logger.info("value error:", e)
+            logger.error("Value Error: {}".format(e))
             return RequestError("error")
-        else:
-            return json.loads(response.read().decode('utf-8'))
 
     def show_data(self, get_data):
         """
@@ -685,7 +685,9 @@ def main():
             if url == "exit":
                 print("exit...")
                 return 0
-            apidoc = handle_data.load_data(url + "/vocab")
+            url = url.rstrip('/') + '/'
+            url = urljoin(url, 'vocab')
+            apidoc = handle_data.load_data(url)
         else:
             break
     return query(apidoc, url)