Lenses fail in cruxShopifyThemes

[max-ostapenko]

The JOIN is corrupted when trying to join the lense filter inside: https://github.com/HTTPArchive/bigquery/blob/cf4698469baea9b254537c451ce7282f9fa255d0/sql/histograms/cruxShopifyThemes.sql#L165C1-L168C3

Result:

  ) AS pct_good_cwv
FROM
  `chrome-ux-report.materialized.device_summary` WHERE   experimental.popularity.rank <= 1000000 
JOIN archive_pages
ON

So eventually only ALL lense succeeds.

[tunetheweb]

Yeah it’s only needed for ALL (it’s not an HTTPArchive report but one run for a friend of the project for their tool).

I never figured out a way in the old world on how to have it only run on ALL so just let it try and fail for the other lenses. Is it possible or in your new way of running reports to not even attempt to run for lenses?

We could make it run for the ranks as that’s data’s easily available in on of those columns but not needed. Running it for the other lenses is more difficult and also doesn’t make sense (a Shopify site is be definition not a WordPress, Magento, nor Drupal site).

[max-ostapenko]

I've created an alternative implementation for this report, so we can just remove it from this repo.

[max-ostapenko]

Fixed in HTTPArchive/dataform#139