Merge branch 'main' into 1067-mom-rendering

Author: tunetheweb

src/js/techreport/summaryCards.js

@@ -73,14 +73,14 @@ class SummaryCard {
         });
       }
 
-      if(latestChange && latestChange.string) {
+      if(latestChange && latestChange.string && latestChange.perc) {
         const changeSlot = card.querySelector('[data-slot="change"]');
         const changeMeaning = changeSlot?.dataset?.meaning;
 
         if(changeSlot) {
           changeSlot.textContent = latestChange.string;
           const styling = UIUtils.getChangeStatus(latestChange.perc, changeMeaning);
-          changeSlot.className = `monthchange ${styling.color} ${styling.direction}`;
+          changeSlot.className = `monthchange ${styling?.color} ${styling?.direction}`;
         }
       }
     }

src/js/techreport/table.js

@@ -194,7 +194,7 @@ function updateTable(id, config, appConfig, apps, data) {
       }
 
       if(column.styling) {
-        wrapper.className = `monthchange ${styling.color} ${styling.direction}`;
+        wrapper.className = `monthchange ${column?.styling?.color} ${column?.styling?.direction}`;
       }
 
       // Add cell to the row

src/js/techreport/timeseries.js

@@ -175,7 +175,7 @@ class Timeseries {
           const styling = UIUtils.getChangeStatus(latestMoM, changeMeaning);
           const monthChange = document.createElement('span');
           monthChange.textContent = latestMoMStr;
-          monthChange.className = `monthchange ${styling.color} ${styling.direction}`;
+          monthChange.className = `monthchange ${styling?.color} ${styling?.direction}`;
           itemWrapper.appendChild(monthChange);
         }
 
@@ -250,7 +250,7 @@ class Timeseries {
           const styling = UIUtils.getChangeStatus(latestMoM, changeMeaning);
           const monthChange = document.createElement('span');
           monthChange.textContent = latestMoMStr;
-          monthChange.className = `monthchange ${styling.color} ${styling.direction}`;
+          monthChange.className = `monthchange ${styling?.color} ${styling?.direction}`;
           card.appendChild(monthChange);
         }
       }

src/js/techreport/utils/ui.js

@@ -35,13 +35,6 @@ const updateReportComponents = (sections, data) => {
 }
 
 const getChangeStatus = (percentage, meaning) => {
-  if(percentage === 0) {
-    return {
-      direction: 'equal',
-      color: 'neutral'
-    }
-  }
-
   if(percentage > 0) {
     const color = meaning === 'inverted' ? 'bad' : 'good';
     return {
@@ -57,6 +50,11 @@ const getChangeStatus = (percentage, meaning) => {
       color: color,
     }
   }
+
+  return {
+    direction: 'equal',
+    color: 'neutral'
+  }
 }
 
 export const UIUtils = {