Skip to content

#1066: When month over month change value doesn't exist, don't add or try to style it #1068

Merged
tunetheweb merged 1 commit intomainfrom
1066-geo-bug
Jun 9, 2025
Merged

#1066: When month over month change value doesn't exist, don't add or try to style it #1068
tunetheweb merged 1 commit intomainfrom
1066-geo-bug

Conversation

@sarahfossheim
Copy link
Copy Markdown
Collaborator

See issue: #1066

For some smaller geos, the month over month change returns null. If that's the case, the MoM stat isn't show in the summary cards. As an extra protection, we're also first checking if the styling object exists before trying to call on its color/direction value (styling?.color instead of styling.color).

@tunetheweb tunetheweb merged commit fbd5289 into main Jun 9, 2025
7 of 8 checks passed
@tunetheweb tunetheweb deleted the 1066-geo-bug branch June 9, 2025 09:58
tunetheweb added a commit that referenced this pull request Jun 9, 2025
tunetheweb added a commit that referenced this pull request Jun 9, 2025
* overwrite classnames instead of adding to them

* Fix bug from #1068

---------

Co-authored-by: Barry Pollard <barrypollard@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants