#1067: Overwrite MoM classnames instead of adding to the list#1069
Merged
tunetheweb merged 3 commits intomainfrom Jun 9, 2025
Merged
#1067: Overwrite MoM classnames instead of adding to the list#1069tunetheweb merged 3 commits intomainfrom
tunetheweb merged 3 commits intomainfrom
Conversation
tunetheweb
requested changes
Jun 9, 2025
tunetheweb
reviewed
Jun 9, 2025
| } | ||
|
|
||
| if(latestChange && latestChange.string && latestChange.perc) { | ||
| if(latestChange && latestChange.string && latestChange.perc != null) { |
Member
There was a problem hiding this comment.
I think you broke this in #1068 as 0's weren't showing so fixed it here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Styling was being added to the month over month components by adding to the classList:
or:
As a result, the icons were added twice when switching between mobile and desktop (which doesn't reload the page or clear out the existing components).
Fix
Instead of adding to the
classList, theclassNamenow gets overwritten: