Skip to content

#1067: Overwrite MoM classnames instead of adding to the list #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tunetheweb merged 3 commits into from
Jun 9, 2025
Merged

#1067: Overwrite MoM classnames instead of adding to the list #1069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be0c90a
overwrite classnames instead of adding to them
sarahfossheim Jun 8, 2025
40f7933
Merge branch 'main' into 1067-mom-rendering
tunetheweb Jun 9, 2025
34d6e6e
Fix bug from #1068
tunetheweb Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/js/techreport/summaryCards.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,14 @@ class SummaryCard {
});
}

if(latestChange && latestChange.string && latestChange.perc) {
if(latestChange && latestChange.string && latestChange.perc != null) {
Copy link
Copy Markdown
Member

@tunetheweb tunetheweb Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you broke this in #1068 as 0's weren't showing so fixed it here.

const changeSlot = card.querySelector('[data-slot="change"]');
const changeMeaning = changeSlot?.dataset?.meaning;

if(changeSlot) {
changeSlot.textContent = latestChange.string;
const styling = UIUtils.getChangeStatus(latestChange.perc, changeMeaning);
changeSlot.classList.add(styling?.color, styling?.direction);
changeSlot.className = `monthchange ${styling?.color} ${styling?.direction}`;
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/js/techreport/table.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ function updateTable(id, config, appConfig, apps, data) {
}

if(column.styling) {
wrapper.classList.add('monthchange', column.styling?.direction, column.styling?.color);
wrapper.className = `monthchange ${column?.styling?.color} ${column?.styling?.direction}`;
}

// Add cell to the row
Expand Down
4 changes: 2 additions & 2 deletions src/js/techreport/timeseries.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ class Timeseries {
const styling = UIUtils.getChangeStatus(latestMoM, changeMeaning);
const monthChange = document.createElement('span');
monthChange.textContent = latestMoMStr;
monthChange.classList.add('monthchange', styling?.color, styling.direction);
monthChange.className = `monthchange ${styling?.color} ${styling?.direction}`;
itemWrapper.appendChild(monthChange);
}

Expand Down Expand Up @@ -250,7 +250,7 @@ class Timeseries {
const styling = UIUtils.getChangeStatus(latestMoM, changeMeaning);
const monthChange = document.createElement('span');
monthChange.textContent = latestMoMStr;
monthChange.classList.add('monthchange', styling?.color, styling.direction);
monthChange.className = `monthchange ${styling?.color} ${styling?.direction}`;
card.appendChild(monthChange);
}
}
Expand Down
Loading