Skip to content

Safe int conversion for query parameters#1087

Merged
max-ostapenko merged 8 commits intomainfrom
faithful-ptarmigan
Jul 14, 2025
Merged

Safe int conversion for query parameters#1087
max-ostapenko merged 8 commits intomainfrom
faithful-ptarmigan

Conversation

@max-ostapenko
Copy link
Copy Markdown
Contributor

@max-ostapenko max-ostapenko commented Jul 12, 2025

@max-ostapenko max-ostapenko requested a review from tunetheweb July 12, 2025 19:14
Copy link
Copy Markdown
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not totally convinced that ignoring bad params is actually a good thing to do. However I also don't think sending a 500 error is a good thing to do either (400 is probably more accurate).

Anyway, don't feel strongly about it, so if if it makes our life easier then happy to go with this.

@max-ostapenko
Copy link
Copy Markdown
Contributor Author

Yeah, I'd like to do 400, but 99.9% of our requests are coming from security scanner.
So will mute them for now.

@max-ostapenko max-ostapenko merged commit b327082 into main Jul 14, 2025
11 checks passed
@max-ostapenko max-ostapenko deleted the faithful-ptarmigan branch July 14, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants