Skip to content

Fix technology filters #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tunetheweb merged 2 commits into from
Oct 16, 2025
Merged

Fix technology filters #1153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f52c93
Fix technology filters
tunetheweb Oct 16, 2025
6967691
Show for comparisons
tunetheweb Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/js/components/filters.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,11 @@ class Filters {

/* Modify the URL with the tech */
url.searchParams.delete('tech');
url.searchParams.append('tech', technologies);
if (technologies.length > 0) {
url.searchParams.append('tech', technologies);
} else {
url.searchParams.append('tech', 'ALL');
}

url.searchParams.delete('geo');
url.searchParams.append('geo', geo);
Expand Down Expand Up @@ -120,7 +124,7 @@ class Filters {

const combo = document.querySelectorAll('[data-component="combobox"]');
const url = new URL(location.href);
const selected = url.searchParams.get('tech')?.split(',') || [];
const selected = url.searchParams.get('tech')?.split(',') || ["ALL"];
combo.forEach(box => new ComboBox(box, this.technologies, selected));
}

Expand Down
5 changes: 5 additions & 0 deletions static/css/techreport/techreport.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1752,6 +1752,11 @@ h2.summary-heading {
bottom: 1rem;
}

/* Drilldown shows both clients in timeseries so hide client meta for these */
[data-component="timeseries"] .meta .drilldown.client {
display: none;
}

/* Chart summary list */
.data-summary {
margin-top: 2rem;
Expand Down
5 changes: 3 additions & 2 deletions templates/techreport/components/filter_meta.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<ul class="meta">
<li>
<li class="{{ active_page }} client">
Client: <span data-slot="client">{{ request.args.get('client', '') | capitalize or 'Mobile' }}</span>
</li>
<li>
Expand All @@ -11,7 +11,8 @@
{# if only one technology (including ALL), then legend is not shown so add label #}
{% if ',' not in request.args.get('tech', '') %}
<li>
Technologies: <span data-slot="tech">{{ request.args.get('tech', '') or 'ALL' }}</span>
{% if (request.args.get('tech', '') or 'ALL') == "ALL" %}Technologies:{% else %}Technology:{% endif %}
<span data-slot="tech">{{ request.args.get('tech', '') or 'ALL' }}</span>
</li>
{% endif %}
</ul>
Loading