Fix exit issue#1579
Draft
mengniwang95 wants to merge 1 commit into
Draft
Conversation
mengniwang95
requested review from
afierka-intel,
jikunshang,
kzawora-intel,
madamczyk-intel,
mgawarkiewicz-intel,
michalkuligowski,
mswiniarsk,
vivekgoe and
xuechendi
as code owners
|
is there any way to fix this issue in vllm instead of letting app do it explicitly? it is bad UX to let app do this. |
Author
you can cherry-pick this commit: c0667a8 |
michalkuligowski
left a comment
michalkuligowski
left a comment
There was a problem hiding this comment.
Converting to draft since this PR was not update for quite time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix exit issue
Exception ignored in: <function LLMEngine.del at 0x7f672f8916c0>
Traceback (most recent call last):
File "/home/mewang/workspace/vllm-fork/vllm/engine/llm_engine.py", line 520, in del
File "/home/mewang/workspace/vllm-fork/vllm/executor/uniproc_executor.py", line 71, in shutdown File "/home/mewang/workspace/vllm-fork/vllm/worker/hpu_worker.py", line 496, in shutdown
File "/home/mewang/workspace/vllm-fork/vllm/worker/hpu_model_runner.py", line 2856, in shutdown_inc
File "/home/mewang/workspace/vllm-fork/vllm/worker/hpu_model_runner.py", line 941, in _is_quant_with_inc AttributeError: 'NoneType' object has no attribute 'getenv'
Test Plan
Test Result
The program exits without any issue