Resolve remaining review threads for Node 25 / ES2024 alignment docs and config#1691
Merged
Conversation
Contributor
Dependency Reviewโ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
๐ธ Automated UI Screenshots๐ Screenshots Captured (8)
๐ฆ Download Screenshots๐ฅ Download all screenshots from workflow artifacts
๐ค Generated by Playwright automation |
Copilot stopped work on behalf of
pethers due to an error
March 18, 2026 15:28
โฆll configs and docs Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
github-actions
Bot
added
documentation
Contributor
๐ธ Automated UI Screenshots๐ Screenshots Captured (8)
๐ฆ Download Screenshots๐ฅ Download all screenshots from workflow artifacts
๐ค Generated by Playwright automation |
Copilot
AI
changed the title
[WIP] Update Node.js version in configurations and workflows
Update Node.js to 25 and TypeScript target to ES2024
Mar 18, 2026
โฆ development.md Three.js version, and End-of-Life-Strategy.md remaining Vite 7 refs Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Contributor
Author
Applied all 4 review items in
|
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns the repoโs runtime/tooling configuration and documentation to the current Node.js 25 baseline and ES2024 target, while cleaning up remaining agent/doc references from the prior PixiJS-era guidance.
Changes:
- Bumped TS/Vite build targets to ES2024 and added Node/npm
engines+.nvmrc. - Updated CI workflows/devcontainer/docs to consistently reference Node.js 25 and Vite 8 / Three.js 0.183.x.
- Refreshed Copilot agent documentation/examples to match the Three.js/@react-three stack and updated Node lifecycle strategy wording/diagrams.
Reviewed changes
Copilot reviewed 44 out of 45 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.ts | Aligns Vite build/esbuild targets to ES2024. |
| tsconfig.json | Raises TS target/lib baseline to ES2024. |
| tsconfig.app.json | Aligns app TS target/lib to ES2024. |
| tsconfig.node.json | Aligns node TS target/lib to ES2024. |
| cypress/tsconfig.json | Aligns Cypress TS target/lib to ES2024. |
| package.json | Adds Node/npm engines constraints for Node 25 / npm 11 baseline. |
| .nvmrc | Sets local dev Node version to 25. |
| .eslintrc.cjs | Adds parserOptions.ecmaVersion=2024 (ESLint legacy config). |
| .devcontainer/devcontainer.json | Updates devcontainer to install Node 25 via feature and adjusts base image. |
| .github/workflows/test-and-report.yml | Updates CI Node version to 25 across jobs. |
| .github/workflows/screenshot-analysis.yml | Updates workflow Node version to 25. |
| .github/workflows/release.yml | Updates release workflow Node version to 25. |
| .github/workflows/copilot-setup-steps.yml | Updates Copilot setup workflow Node version to 25. |
| .github/workflows/codeql.yml | Updates CodeQL workflow Node version to 25. |
| .github/workflows/audit-assets.yml | Updates audit workflow Node version to 25. |
| .github/workflows/accessibility-test.yml | Updates accessibility workflow Node version to 25. |
| README.md | Updates stack badges/prereqs to Node 25, Vite 8, Three.js/R3F versions, and Web Audio API. |
| development.md | Updates prerequisites and stack references to Node 25 / Vite 8 / Three.js 0.183.x. |
| WORKFLOWS.md | Updates workflow diagrams/text to Node 25 baseline. |
| UnitTestPlan.md | Updates CI snippets to Node 25. |
| E2ETestPlan.md | Updates CI snippet to Node 25. |
| End-of-Life-Strategy.md | Updates Node/Vite lifecycle sections and gantt timelines for Node 25 baseline + 26 LTS migration. |
| FUTURE_MINDMAP.md | Updates future architecture note to Node 25. |
| FUTURE_FLOWCHART.md | Updates future flowchart note to Node 25. |
| .github/release-drafter.yml | Updates release notes template stack to Node 25 / ES2024 / Three.js and Web Audio. |
| docs/api/media/README.md | Mirrors docs updates for Node 25 baseline. |
| docs/api/media/development.md | Mirrors development.md updates in docs mirror. |
| docs/api/media/WORKFLOWS.md | Mirrors WORKFLOWS.md updates in docs mirror. |
| docs/api/media/UnitTestPlan.md | Mirrors UnitTestPlan.md updates in docs mirror. |
| docs/api/media/E2ETestPlan.md | Mirrors E2ETestPlan.md updates in docs mirror. |
| docs/api/media/COPILOT_MCP_SETUP.md | Updates MCP setup doc to Three.js/R3F and Node 25. |
| docs/api/media/AGENT_CAPABILITIES.md | Updates agent capabilities doc to Node 25 and Three.js/R3F wording. |
| .github/COPILOT_MCP_SETUP.md | Updates MCP setup doc to Three.js/R3F and Node 25. |
| .github/agents/README.md | Updates agent README to Node 25 baseline. |
| .github/agents/AGENT_CAPABILITIES.md | Updates agent capabilities to Node 25 and Three.js/R3F wording. |
| .github/agents/coding-agent.md | Updates coding-agent guidance/examples from PixiJS to Three.js/R3F. |
| .github/agents/game-developer.md | Updates environment references to Node 25. |
| .github/agents/frontend-specialist.md | Updates environment references to Node 25. |
| .github/agents/testing-agent.md | Updates testing guidance to Three.js/R3F mocking approach and Node 25. |
| .github/agents/test-engineer.md | Updates mock example from PixiJS to Three.js and Node 25. |
| .github/agents/task-agent.md | Updates Node 25 references and label naming (three). |
| .github/agents/security-specialist.md | Updates dependency patterns from pixi to three/@react-three and Node 25. |
| .github/agents/korean-martial-arts-expert.md | Updates environment references to Node 25. |
| .github/agents/documentation-writer.md | Updates environment references to Node 25. |
| .github/agents/code-review-agent.md | Updates environment references to Node 25. |
Comment on lines
11
to
23
| parserOptions: { | ||
| ecmaVersion: 2024, | ||
| sourceType: "module", | ||
| ecmaFeatures: { | ||
| jsx: true, | ||
| }, | ||
| }, | ||
| env: { | ||
| browser: true, | ||
| // Keep env at ES2021 for globally supported built-ins; parserOptions.ecmaVersion: 2024 handles syntax support. | ||
| es2021: true, | ||
| node: true, | ||
| }, |
Comment on lines
+184
to
+185
| Node.js 26.x Current :done, node26c, 2025-10-21, 2025-10-28 | ||
| Node.js 26.x LTS :active, node26lts, 2025-10-28, 2028-04-30 |
Contributor
๐ธ Automated UI Screenshots๐ Screenshots Captured (8)
๐ฆ Download Screenshots๐ฅ Download all screenshots from workflow artifacts
๐ค Generated by Playwright automation |
Member
|
@copilot apply changes based on the comments in this thread |
Contributor
๐ธ Automated UI Screenshots๐ Screenshots Captured (8)
๐ฆ Download Screenshots๐ฅ Download all screenshots from workflow artifacts
๐ค Generated by Playwright automation |
โฆt phase to ~6 months Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Contributor
Author
Applied both review items in
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR finishes the Node 25 / ES2024 alignment work across build config, TypeScript/ESLint settings, CI/devcontainer tooling, and the repositoryโs documentation/agent guidance so the stated baseline matches what CI and local dev use.
Changes:
- Align build/tooling targets to ES2024 (Vite build + esbuild, TS targets/libs, ESLint ecmaVersion).
- Standardize Node.js 25 across engines,
.nvmrc, GitHub Actions workflows, and devcontainer. - Update documentation and Copilot agent docs from Node 24/Vite 7/Three.js 0.182-era references to Node 25/Vite 8/Three.js 0.183 and Three.js/R3F testing guidance.
Reviewed changes
Copilot reviewed 45 out of 46 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.ts | Update Vite build/esbuild targets to es2024. |
| tsconfig.node.json | Align Node-side TS target/lib to ES2024. |
| tsconfig.json | Align base TS target/lib to ES2024. |
| tsconfig.app.json | Align app TS target/lib to ES2024. |
| cypress/tsconfig.json | Align Cypress TS target/lib to ES2024. |
| package.json | Declare Node/npm engine constraints (Node >=25, npm >=11). |
| eslint.config.js | Update flat-config ecmaVersion to 2024. |
| .eslintrc.cjs | Update legacy ESLint config parserOptions/ecmaVersion notes for ES2024 syntax. |
| .nvmrc | Pin local Node baseline to 25. |
| .devcontainer/devcontainer.json | Switch base image and install Node 25 via devcontainer feature. |
| .github/workflows/test-and-report.yml | Update CI jobs to use Node 25. |
| .github/workflows/screenshot-analysis.yml | Update workflow Node version to 25. |
| .github/workflows/release.yml | Update release workflow Node version to 25. |
| .github/workflows/copilot-setup-steps.yml | Update Copilot setup workflow Node version to 25. |
| .github/workflows/codeql.yml | Update CodeQL workflow Node version to 25. |
| .github/workflows/audit-assets.yml | Update asset audit workflow Node version to 25. |
| .github/workflows/accessibility-test.yml | Update accessibility workflows Node version to 25. |
| .github/release-drafter.yml | Refresh release template stack section for Node 25 / Vite 8 / Three 0.183 / Web Audio. |
| README.md | Update stack badges + prerequisites + stack summary for Vite 8 / Three 0.183 / Web Audio / Node 25. |
| development.md | Update dev guide stack and prerequisites to Node 25/npm 11 and Vite 8/Three 0.183. |
| WORKFLOWS.md | Update workflow docs to reflect Node 25 CI baseline. |
| UnitTestPlan.md | Update referenced node-version to 25 in sample workflow snippet. |
| E2ETestPlan.md | Update referenced node-version to 25 in sample workflow snippet. |
| End-of-Life-Strategy.md | Refresh Node/Vite timelines and migration triggers; adjust gantt tracks for Node 25 baseline and Node 26 migration. |
| FUTURE_MINDMAP.md | Update future architecture mindmap Node runtime reference to 25. |
| FUTURE_FLOWCHART.md | Update future architecture flowchart Node runtime reference to 25. |
| docs/api/media/development.md | Mirror dev guide stack/prereqs updates in docs copy. |
| docs/api/media/WORKFLOWS.md | Mirror workflows doc updates in docs copy. |
| docs/api/media/UnitTestPlan.md | Mirror unit test plan node-version updates in docs copy. |
| docs/api/media/README.md | Update docs index references to Node 25. |
| docs/api/media/E2ETestPlan.md | Mirror E2E plan node-version updates in docs copy. |
| docs/api/media/COPILOT_MCP_SETUP.md | Update MCP setup doc from PixiJS โ Three.js/R3F and Node 25 references. |
| docs/api/media/AGENT_CAPABILITIES.md | Update agent capabilities doc from PixiJS โ Three.js/R3F and Node 25 references. |
| .github/COPILOT_MCP_SETUP.md | Update MCP setup doc from PixiJS โ Three.js/R3F and Node 25 references. |
| .github/agents/README.md | Update agents README references to Node 25. |
| .github/agents/AGENT_CAPABILITIES.md | Update agents capabilities doc from PixiJS โ Three.js/R3F and Node 25 references. |
| .github/agents/coding-agent.md | Update coding-agent guidance from PixiJS โ Three.js/R3F patterns. |
| .github/agents/testing-agent.md | Update testing-agent guidance on Three.js mocking and setup.ts behavior. |
| .github/agents/test-engineer.md | Update test-engineer guidance with Three.js mock example. |
| .github/agents/task-agent.md | Update task-agent env references to Node 25 and rename label key to three. |
| .github/agents/security-specialist.md | Update dependency pattern examples from PixiJS โ Three.js/R3F. |
| .github/agents/game-developer.md | Update env references to Node 25. |
| .github/agents/frontend-specialist.md | Update env references to Node 25. |
| .github/agents/documentation-writer.md | Update env references to Node 25. |
| .github/agents/korean-martial-arts-expert.md | Update env references to Node 25. |
| .github/agents/code-review-agent.md | Update env references to Node 25. |
Comments suppressed due to low confidence (1)
.github/agents/coding-agent.md:134
- The example under โLayout System Usageโ uses
<group layout={{ ... }}>, butgroup(R3F) doesnโt support alayoutprop (this looks like leftover from @pixi/layout). This snippet will mislead contributors/agents and should be updated to a valid Three.js/R3F pattern (e.g., use<Html fullscreen>with a styled<div>for flex layout, or document a real layout helper used in this repo).
<group
layout={{
width: "100%",
flexDirection: "column",
gap: layoutConstants.spacing,
padding: layoutConstants.padding,
}}
>
Comment on lines
+184
to
+185
| Node.js 26.x Current :done, node26c, 2025-10-21, 2026-04-01 | ||
| Node.js 26.x LTS :active, node26lts, 2026-04-01, 2028-04-30 |
| @@ -49,9 +49,9 @@ You help implement new features, fix bugs, and refactor code following the proje | |||
| ## Core Technologies | |||
|
|
|||
| - **React 18+** with TypeScript | |||
Member
|
@copilot apply changes based on the comments in this thread |
Contributor
๐ธ Automated UI Screenshots๐ Screenshots Captured (8)
๐ฆ Download Screenshots๐ฅ Download all screenshots from workflow artifacts
๐ค Generated by Playwright automation |
- End-of-Life-Strategy.md: Node 26.x Current :doneโ:active (ends 2026-04-01, still in progress); 26.x LTS removed :active (starts 2026-04-01, future) - coding-agent.md: React 18+โReact 19+ to match package.json (react ^19.2.4) Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Contributor
Author
Applied both review items in
|
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns the repoโs build/tooling configuration and documentation with a Node.js 25 + ES2024/ES2024+ baseline (and associated Vite/Three.js updates), resolving remaining review threads across config, workflows, and docs.
Changes:
- Bumped TS/Vite/esbuild/ESLint targets to ES2024 / ecmaVersion 2024.
- Standardized Node.js version references across CI/workflows/docs and introduced
.nvmrc. - Updated docs to reflect the Three.js/R3F stack and Vite 8 baseline.
Reviewed changes
Copilot reviewed 45 out of 46 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.ts | Updates Vite build + esbuild targets to ES2024. |
| tsconfig.node.json | Raises TS compile target/lib to ES2024 for Node tooling config. |
| tsconfig.json | Raises main TS compile target/lib to ES2024. |
| tsconfig.app.json | Raises app TS compile target/lib to ES2024. |
| cypress/tsconfig.json | Raises Cypress TS compile target/lib to ES2024. |
| eslint.config.js | Updates ESLint flat config ecmaVersion to 2024. |
| .eslintrc.cjs | Adds parserOptions/ecmaVersion 2024 and clarifying comment for legacy config. |
| package.json | Adds engines constraints for Node >=25 / npm >=11. |
| .nvmrc | Introduces Node version pin for local tooling. |
| .devcontainer/devcontainer.json | Adjusts devcontainer base image and Node feature version. |
| .github/workflows/test-and-report.yml | Updates CI jobs to run on Node 25. |
| .github/workflows/screenshot-analysis.yml | Updates workflow to run on Node 25. |
| .github/workflows/release.yml | Updates release workflow to run on Node 25. |
| .github/workflows/copilot-setup-steps.yml | Updates Copilot setup workflow to run on Node 25. |
| .github/workflows/codeql.yml | Updates CodeQL workflow to run on Node 25. |
| .github/workflows/audit-assets.yml | Updates audit workflow Node version from 20 to 25. |
| .github/workflows/accessibility-test.yml | Updates accessibility workflows Node version from 20 to 25. |
| docs/api/media/development.md | Updates prerequisites/tooling versions (Node 25, Vite 8, Three.js 0.183.x). |
| development.md | Same as docs copy: Node/Vite/Three.js prerequisites and wording. |
| README.md | Updates stack badges and prerequisites wording (Vite 8, Three.js 0.183, Node 25, audio). |
| WORKFLOWS.md | Updates workflow diagrams/text to Node 25 baseline. |
| docs/api/media/WORKFLOWS.md | Same as docs copy: workflow diagrams/text to Node 25 baseline. |
| UnitTestPlan.md | Updates example CI node-version to 25. |
| docs/api/media/UnitTestPlan.md | Same as docs copy: updates example CI node-version to 25. |
| E2ETestPlan.md | Updates example CI node-version to 25. |
| docs/api/media/E2ETestPlan.md | Same as docs copy: updates example CI node-version to 25. |
| End-of-Life-Strategy.md | Updates Node/Vite baselines, gantt timelines, and migration trigger text. |
| FUTURE_MINDMAP.md | Updates future architecture node version references to 25. |
| FUTURE_FLOWCHART.md | Updates future architecture node version references to 25. |
| .github/release-drafter.yml | Updates stack section to Node 25 / Vite 8 / ES2024 wording. |
| .github/agents/coding-agent.md | Updates agent guidance from PixiJSโThree.js/R3F and Node 25 baseline. |
| .github/agents/testing-agent.md | Updates test guidance from PixiJSโThree.js/R3F and clarifies mocking approach. |
| .github/agents/test-engineer.md | Updates mocking example from PixiJSโThree.js. |
| .github/agents/task-agent.md | Updates Node baseline and renames label key to three. |
| .github/agents/security-specialist.md | Updates dependency patterns from PixiJS to Three.js/R3F related. |
| .github/agents/game-developer.md | Updates Node baseline in agent docs. |
| .github/agents/frontend-specialist.md | Updates Node baseline in agent docs. |
| .github/agents/documentation-writer.md | Updates Node baseline in agent docs. |
| .github/agents/code-review-agent.md | Updates Node baseline in agent docs. |
| .github/agents/korean-martial-arts-expert.md | Updates Node baseline in agent docs. |
| .github/agents/README.md | Updates Node baseline references for agent documentation hub. |
| .github/agents/AGENT_CAPABILITIES.md | Updates stack references from PixiJSโThree.js/R3F and Node baseline. |
| docs/api/media/AGENT_CAPABILITIES.md | Same as docs copy: updates stack references and Node baseline. |
| .github/COPILOT_MCP_SETUP.md | Updates MCP setup doc from PixiJSโThree.js/R3F and Node 25 baseline. |
| docs/api/media/COPILOT_MCP_SETUP.md | Same as docs copy: updates MCP setup doc from PixiJSโThree.js/R3F and Node 25 baseline. |
| docs/api/media/README.md | Updates Node baseline references for docs index. |
| docs/api/media/README.md | Updates environment setup table to Node 25. |
Comments suppressed due to low confidence (1)
vite.config.ts:1
- The earlier comment explaining why
drop: ["console","debugger"]applies (including development) was removed, but the behavior remains. Since dropping console output in dev can be surprising during local debugging, it would help to reintroduce documentation inline (or scope the behavior to production-only if that was the original intent) so future maintainers donโt โfixโ it unintentionally.
| { | ||
| "name": "Black Trigram Dev Container", | ||
| "image": "mcr.microsoft.com/devcontainers/javascript-node:24-trixie", | ||
| "image": "mcr.microsoft.com/devcontainers/javascript-node:22-trixie", |
| "ghcr.io/devcontainers/features/node:1": { | ||
| "nodeGypDependencies": true, | ||
| "version": "24" // Aligned with base image | ||
| "version": "25" // Aligned with package.json engines (>=25) |
Comment on lines
11
to
23
| parserOptions: { | ||
| ecmaVersion: 2024, | ||
| sourceType: "module", | ||
| ecmaFeatures: { | ||
| jsx: true, | ||
| }, | ||
| }, | ||
| env: { | ||
| browser: true, | ||
| // Keep env at ES2021 for globally supported built-ins; parserOptions.ecmaVersion: 2024 handles syntax support. | ||
| es2021: true, | ||
| node: true, | ||
| }, |
| - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0 | ||
| with: | ||
| node-version: "24" | ||
| node-version: "25" |
Member
|
@copilot apply changes based on the comments in this thread |
โฆtch workflows to node-version-file Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Contributor
Author
Applied all 4 review items in
|
Contributor
๐ธ Automated UI Screenshots๐ Screenshots Captured (8)
๐ฆ Download Screenshots๐ฅ Download all screenshots from workflow artifacts
๐ค Generated by Playwright automation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
env.es2021+parserOptions.ecmaVersion: 2024:doneโ:active, 26.x LTS remove:active(future date)base:debian) so only the Node feature provides Node 25 โ eliminates dual Node installations and PATH ambiguitynode-version: "25"tonode-version-file: '.nvmrc'for centralized Node version management๐ GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.