Fix top animation system regressions by Copilot · Pull Request #1930 · Hack23/blacktrigram

Copilot · 2026-05-14T11:21:19Z

Inspect the reviewed files and recent commits to understand the animation regression fixes
Investigate recent CI/build workflow status and logs if failures are present
Run baseline repository validation before code changes
Address stance side-switch visual/state-machine feedback
Align Gon ID lookups with dedicated animation registrations
Replace hard-coded fallback duration assertions with shared constants
Run targeted and full validation
Run final parallel validation and reply to the new PR comment

Agent-Logs-Url: https://github.com/Hack23/blacktrigram/sessions/b0878188-e303-4720-ae1a-b85f79bc09d9 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

github-actions · 2026-05-14T11:21:54Z

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

github-actions · 2026-05-14T11:22:54Z

🎯 Accessibility Test Results

WCAG 2.1 Level AA Compliance Tests

✅ Color contrast validation (4.5:1 for text, 3:1 for UI)
✅ ARIA labels and roles validation
✅ Keyboard navigation structure validation
✅ Focus indicators validation
✅ Dialog and menu semantics validation
✅ Progress bars and timers validation

Components Tested

Accessibility utilities (keyboard nav, focus management)
Bilingual ARIA labels (Korean-English)
Button groups (VirtualDPad pattern)
Radiogroups (StanceWheel pattern)
Dialogs (PauseMenu pattern)
Progress bars (HealthBar, StaminaBar pattern)
Timers (CombatTimer pattern)

Test Framework

Tool: axe-core via jest-axe
Standard: WCAG 2.1 Level AA
Test Runner: Vitest

github-actions · 2026-05-14T11:26:51Z

📸 Automated UI Screenshots

📋 Screenshots Captured (8)

#	Screenshot
1	`01-splash-screen.png` - 01 splash screen.png
2	`02-intro-screen-menu.png` - 02 intro screen menu.png
3	`03-intro-screen-archetype-selector.png` - 03 intro screen archetype selector.png
4	`04-controls-screen.png` - 04 controls screen.png
5	`05-philosophy-screen.png` - 05 philosophy screen.png
6	`06-training-screen.png` - 06 training screen.png
7	`07-combat-screen-practice.png` - 07 combat screen practice.png
8	`08-combat-screen-versus.png` - 08 combat screen versus.png

📦 Download Screenshots

📥 Download all screenshots from workflow artifacts

Screenshots are preserved as workflow artifacts for 30 days.

🤖 Generated by Playwright automation

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 6 comments.

  hit: "hit",
  stance_change: "stance_change",
-  stance_side_switch: "stance_change", // Map to stance_change animation (mirroring guard)
+  stance_side_switch: "stance_side_switch", // Dedicated left↔right foot-forward switch


+    it("should map stance side switch to dedicated side-switch animation", () => {
+      const result = animationStateToPlayerAnimation(
+        AnimationState.STANCE_SIDE_SWITCH
+      );
+      expect(result).toBe("stance_side_switch");
+    });


+  ["gam_idle_flowing", GAM_STANCE_ANIMATIONS.idle],
+  ["gam_yielding_sidestep", GAM_STANCE_ANIMATIONS.movement.yieldingSidestep],
+  ["gam_flowing_retreat_step", GAM_STANCE_ANIMATIONS.movement.flowingRetreat],
+  ["gam_water_flow_counter", GAM_STANCE_ANIMATIONS.techniques.waterFlowCounter],
+  ["gam_flowing_takedown", GAM_STANCE_ANIMATIONS.techniques.flowingTakedown],
+  ["gam_counter", GAM_TECHNIQUE_ANIMATIONS.counter],
+  ["gam_takedown", GAM_TECHNIQUE_ANIMATIONS.takedown],
  ...GAN_STANCE_ANIMATIONS, // ☶ Mountain: Defensive mastery
  ...GAN_TECHNIQUE_ANIMATIONS, // ☶ Mountain techniques
+  ...GON_TECHNIQUE_ANIMATIONS, // ☷ Earth: Ssireum throws and ground control


+  describe("getAnimationDurationOrFallback", () => {
+    it("should return registered animation duration when metadata exists", () => {
+      expect(getAnimationDurationOrFallback("gon_earth_embrace")).toBe(
+        getAnimation("gon_earth_embrace")?.duration,
+      );
+    });
+
+    it("should return shared fallback duration for missing animation metadata", () => {
+      expect(getAnimationDurationOrFallback("missing_animation")).toBe(0.55);
+      expect(getAnimationDurationOrFallback()).toBe(0.55);
+    });


+      // Animation should always be triggered with a technique-aware duration.
+      expect(mockPlayerAnimation.transitionToAttack).toHaveBeenCalledWith(0.55);
    });


          case "stance_side_switch":
-            player1Animation.transitionTo(AnimationState.STANCE_SIDE_SWITCH);
+            handleStanceSideSwitch(PLAYER_ONE_INDEX);
            break;


pethers · 2026-05-14T11:58:46Z

@copilot apply changes based on the comments in this thread

Agent-Logs-Url: https://github.com/Hack23/blacktrigram/sessions/7d68b56b-ff01-4e92-9573-b0d5c1dad4ed Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

github-actions · 2026-05-14T12:09:04Z

🎯 Accessibility Test Results

WCAG 2.1 Level AA Compliance Tests

✅ Color contrast validation (4.5:1 for text, 3:1 for UI)
✅ ARIA labels and roles validation
✅ Keyboard navigation structure validation
✅ Focus indicators validation
✅ Dialog and menu semantics validation
✅ Progress bars and timers validation

Components Tested

Accessibility utilities (keyboard nav, focus management)
Bilingual ARIA labels (Korean-English)
Button groups (VirtualDPad pattern)
Radiogroups (StanceWheel pattern)
Dialogs (PauseMenu pattern)
Progress bars (HealthBar, StaminaBar pattern)
Timers (CombatTimer pattern)

Test Framework

Tool: axe-core via jest-axe
Standard: WCAG 2.1 Level AA
Test Runner: Vitest

github-actions · 2026-05-14T12:12:58Z

📸 Automated UI Screenshots

📋 Screenshots Captured (8)

#	Screenshot
1	`01-splash-screen.png` - 01 splash screen.png
2	`02-intro-screen-menu.png` - 02 intro screen menu.png
3	`03-intro-screen-archetype-selector.png` - 03 intro screen archetype selector.png
4	`04-controls-screen.png` - 04 controls screen.png
5	`05-philosophy-screen.png` - 05 philosophy screen.png
6	`06-training-screen.png` - 06 training screen.png
7	`07-combat-screen-practice.png` - 07 combat screen practice.png
8	`08-combat-screen-versus.png` - 08 combat screen versus.png

📦 Download Screenshots

📥 Download all screenshots from workflow artifacts

Screenshots are preserved as workflow artifacts for 30 days.

🤖 Generated by Playwright automation

Agent-Logs-Url: https://github.com/Hack23/blacktrigram/sessions/7d68b56b-ff01-4e92-9573-b0d5c1dad4ed Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

github-actions · 2026-05-14T12:16:03Z

🎯 Accessibility Test Results

WCAG 2.1 Level AA Compliance Tests

✅ Color contrast validation (4.5:1 for text, 3:1 for UI)
✅ ARIA labels and roles validation
✅ Keyboard navigation structure validation
✅ Focus indicators validation
✅ Dialog and menu semantics validation
✅ Progress bars and timers validation

Components Tested

Accessibility utilities (keyboard nav, focus management)
Bilingual ARIA labels (Korean-English)
Button groups (VirtualDPad pattern)
Radiogroups (StanceWheel pattern)
Dialogs (PauseMenu pattern)
Progress bars (HealthBar, StaminaBar pattern)
Timers (CombatTimer pattern)

Test Framework

Tool: axe-core via jest-axe
Standard: WCAG 2.1 Level AA
Test Runner: Vitest

github-actions · 2026-05-14T12:19:57Z

📸 Automated UI Screenshots

📋 Screenshots Captured (8)

#	Screenshot
1	`01-splash-screen.png` - 01 splash screen.png
2	`02-intro-screen-menu.png` - 02 intro screen menu.png
3	`03-intro-screen-archetype-selector.png` - 03 intro screen archetype selector.png
4	`04-controls-screen.png` - 04 controls screen.png
5	`05-philosophy-screen.png` - 05 philosophy screen.png
6	`06-training-screen.png` - 06 training screen.png
7	`07-combat-screen-practice.png` - 07 combat screen practice.png
8	`08-combat-screen-versus.png` - 08 combat screen versus.png

📦 Download Screenshots

📥 Download all screenshots from workflow artifacts

Screenshots are preserved as workflow artifacts for 30 days.

🤖 Generated by Playwright automation

Agent-Logs-Url: https://github.com/Hack23/blacktrigram/sessions/7d68b56b-ff01-4e92-9573-b0d5c1dad4ed Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

github-actions · 2026-05-14T12:23:09Z

🎯 Accessibility Test Results

WCAG 2.1 Level AA Compliance Tests

✅ Color contrast validation (4.5:1 for text, 3:1 for UI)
✅ ARIA labels and roles validation
✅ Keyboard navigation structure validation
✅ Focus indicators validation
✅ Dialog and menu semantics validation
✅ Progress bars and timers validation

Components Tested

Accessibility utilities (keyboard nav, focus management)
Bilingual ARIA labels (Korean-English)
Button groups (VirtualDPad pattern)
Radiogroups (StanceWheel pattern)
Dialogs (PauseMenu pattern)
Progress bars (HealthBar, StaminaBar pattern)
Timers (CombatTimer pattern)

Test Framework

Tool: axe-core via jest-axe
Standard: WCAG 2.1 Level AA
Test Runner: Vitest

Copilot · 2026-05-14T12:26:42Z

@copilot apply changes based on the comments in this thread

Applied the review feedback in ddfa6e1: side-switch now transitions through STANCE_SIDE_SWITCH while resolving to a named renderable stance transition clip, Gon ID lookups now align with dedicated Gon clips, and duration tests use the shared fallback constant. Validation passed (npm run check, npm run lint, npm test, npm run build) and final code review/CodeQL reported no comments or alerts. No screenshot included because there were no UI changes.

github-actions · 2026-05-14T12:26:58Z

📸 Automated UI Screenshots

📋 Screenshots Captured (8)

#	Screenshot
1	`01-splash-screen.png` - 01 splash screen.png
2	`02-intro-screen-menu.png` - 02 intro screen menu.png
3	`03-intro-screen-archetype-selector.png` - 03 intro screen archetype selector.png
4	`04-controls-screen.png` - 04 controls screen.png
5	`05-philosophy-screen.png` - 05 philosophy screen.png
6	`06-training-screen.png` - 06 training screen.png
7	`07-combat-screen-practice.png` - 07 combat screen practice.png
8	`08-combat-screen-versus.png` - 08 combat screen versus.png

📦 Download Screenshots

📥 Download all screenshots from workflow artifacts

Screenshots are preserved as workflow artifacts for 30 days.

🤖 Generated by Playwright automation

Copilot AI and others added 6 commits May 14, 2026 10:41

Fix top animation system regressions

1cd62d7

Agent-Logs-Url: https://github.com/Hack23/blacktrigram/sessions/b0878188-e303-4720-ae1a-b85f79bc09d9 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Address animation review feedback

44c69cd

Agent-Logs-Url: https://github.com/Hack23/blacktrigram/sessions/b0878188-e303-4720-ae1a-b85f79bc09d9 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Share animation timing constants

8dcfa08

Agent-Logs-Url: https://github.com/Hack23/blacktrigram/sessions/b0878188-e303-4720-ae1a-b85f79bc09d9 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Refine animation lookup helpers

00cff07

Agent-Logs-Url: https://github.com/Hack23/blacktrigram/sessions/b0878188-e303-4720-ae1a-b85f79bc09d9 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Clarify animation timing defaults

3766162

Agent-Logs-Url: https://github.com/Hack23/blacktrigram/sessions/b0878188-e303-4720-ae1a-b85f79bc09d9 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Deduplicate player attack timing setup

a12b86e

Agent-Logs-Url: https://github.com/Hack23/blacktrigram/sessions/b0878188-e303-4720-ae1a-b85f79bc09d9 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Copilot AI assigned Copilot and pethers May 14, 2026

github-actions Bot added graphics Graphics and rendering (PixiJS) ui User interface improvements testing Testing improvements types TypeScript type improvements test-coverage-impact Impacts test coverage needs-tests Needs test coverage three-components labels May 14, 2026

Copilot created this pull request from a session on behalf of pethers May 14, 2026 11:22 View session

Copilot finished work on behalf of pethers May 14, 2026 11:22

Copilot AI requested a review from pethers May 14, 2026 11:22

pethers marked this pull request as ready for review May 14, 2026 11:47

Copilot AI review requested due to automatic review settings May 14, 2026 11:47

Copilot AI reviewed May 14, 2026

View reviewed changes

pethers requested a review from Copilot May 14, 2026 11:47

Copilot started reviewing on behalf of pethers May 14, 2026 11:48 View session

Copilot AI reviewed May 14, 2026

View reviewed changes

Copilot started work on behalf of pethers May 14, 2026 11:58 View session

Address animation review feedback

7b79156

Agent-Logs-Url: https://github.com/Hack23/blacktrigram/sessions/7d68b56b-ff01-4e92-9573-b0d5c1dad4ed Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Refine animation review fixes

f8d564c

Agent-Logs-Url: https://github.com/Hack23/blacktrigram/sessions/7d68b56b-ff01-4e92-9573-b0d5c1dad4ed Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Clarify stance transition animation lookup

ddfa6e1

Agent-Logs-Url: https://github.com/Hack23/blacktrigram/sessions/7d68b56b-ff01-4e92-9573-b0d5c1dad4ed Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Copilot finished work on behalf of pethers May 14, 2026 12:27

pethers merged commit cc4addd into main May 14, 2026
17 checks passed

pethers deleted the copilot/review-animation-systems branch May 14, 2026 20:32

Conversation

Copilot AI commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dependency Review

Scanned Files

Uh oh!

github-actions Bot commented May 14, 2026

🎯 Accessibility Test Results

WCAG 2.1 Level AA Compliance Tests

Components Tested

Test Framework

Uh oh!

github-actions Bot commented May 14, 2026

📸 Automated UI Screenshots

📋 Screenshots Captured (8)

📦 Download Screenshots

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

pethers commented May 14, 2026

Uh oh!

github-actions Bot commented May 14, 2026

🎯 Accessibility Test Results

WCAG 2.1 Level AA Compliance Tests

Components Tested

Test Framework

Uh oh!

github-actions Bot commented May 14, 2026

📸 Automated UI Screenshots

📋 Screenshots Captured (8)

📦 Download Screenshots

Uh oh!

github-actions Bot commented May 14, 2026

🎯 Accessibility Test Results

WCAG 2.1 Level AA Compliance Tests

Components Tested

Test Framework

Uh oh!

github-actions Bot commented May 14, 2026

📸 Automated UI Screenshots

📋 Screenshots Captured (8)

📦 Download Screenshots

Uh oh!

github-actions Bot commented May 14, 2026

🎯 Accessibility Test Results

WCAG 2.1 Level AA Compliance Tests

Components Tested

Test Framework

Uh oh!

Copilot AI commented May 14, 2026

Uh oh!

github-actions Bot commented May 14, 2026

📸 Automated UI Screenshots

📋 Screenshots Captured (8)

📦 Download Screenshots

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented May 14, 2026 •

edited

Loading

github-actions Bot commented May 14, 2026 •

edited

Loading