Skip to content

Commit de10b28

Browse files
Copilotpethers
andauthored
Fix Norwegian sitemap Cypress lang assertion (BCP-47 nb, slug stays no)
Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/b73216c2-7547-4f71-a0f9-03be3edafe25 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
1 parent dced8d4 commit de10b28

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

cypress/e2e/sitemap.cy.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ describe('Sitemap Pages', () => {
8383
const languages = [
8484
{ code: 'sv', name: 'Swedish', dir: 'ltr' },
8585
{ code: 'da', name: 'Danish', dir: 'ltr' },
86-
{ code: 'no', name: 'Norwegian', dir: 'ltr' },
86+
{ code: 'no', name: 'Norwegian', dir: 'ltr', lang: 'nb' },
8787
{ code: 'fi', name: 'Finnish', dir: 'ltr' },
8888
{ code: 'de', name: 'German', dir: 'ltr' },
8989
{ code: 'fr', name: 'French', dir: 'ltr' },
@@ -96,7 +96,7 @@ describe('Sitemap Pages', () => {
9696
{ code: 'zh', name: 'Chinese', dir: 'ltr' }
9797
];
9898

99-
languages.forEach(({ code, name, dir }) => {
99+
languages.forEach(({ code, name, dir, lang }) => {
100100
describe(`${name} Sitemap (${code})`, () => {
101101
it(`should load ${name} sitemap successfully`, () => {
102102
cy.visit(`/sitemap_${code}.html`);
@@ -105,7 +105,10 @@ describe('Sitemap Pages', () => {
105105

106106
it(`should have proper lang attribute for ${name}`, () => {
107107
cy.visit(`/sitemap_${code}.html`);
108-
cy.get('html').should('have.attr', 'lang', code);
108+
// URL slug uses legacy ISO code (e.g. /sitemap_no.html) but the
109+
// <html lang="…"> attribute follows BCP-47 (e.g. lang="nb" for
110+
// Norwegian Bokmål). Allow per-language override.
111+
cy.get('html').should('have.attr', 'lang', lang ?? code);
109112
});
110113

111114
it(`should have proper dir attribute for ${name}`, () => {

0 commit comments

Comments
 (0)