Conversation
…rkflow Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/3653e9a6-cdc7-46c1-a7cc-4027ca70a254 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
…DMEs Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/eb380e50-f0c7-4eab-a61d-a6ccc4b264fc Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
github-actions
Bot
added
documentation
🏷️ Automatic Labeling SummaryThis PR has been automatically labeled based on the files changed and PR metadata. Applied Labels: documentation,workflow,ci-cd,size-xl,news,agentic-workflow Label Categories
For more information, see |
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
| | **2** | **Very unlikely** / *highly improbable* | *Mycket osannolikt* | 5 – 20 % | "A split within SD over migration policy before the 2026 election is very unlikely given the party's current whip discipline." | | ||
| | **3** | **Unlikely** / *improbable* | *Osannolikt* | 20 – 45 % | "Unilateral Regeringskansliet blocking of an EU-initiated trilogue is unlikely, given Sweden's Council commitments." | | ||
| | **4** | **Roughly even chance** | *Ungefär lika sannolikt som inte* | 45 – 55 % | "There is a roughly even chance that C and L will split over budget priorities in Q3." | | ||
| | **5** | **Likely** / *probable* | *Sannolikt* | 55 – 80 % | "The M–KD compromise on the Wind-Power Revenue Act (HD03239) will likely survive the chamber vote." | | ||
| | **6** | **Very likely** / *highly probable* | *Mycket sannolikt* | 80 – 95 % | "Very likely the budget discharge will pass on first chamber vote." | | ||
| | **7** | **Almost certain** / *nearly certain* | *Så gott som säkert* | 95 – 99 % | "Extra amendment budget FiU48 is almost certain to be adopted this plenary." | |
There was a problem hiding this comment.
The WEP band table introduces non-canonical terms/synonyms (e.g. “probable”, “highly probable/improbable”, “almost no chance”) and numeric ranges that don’t match the repository’s canonical WEP vocabulary in political-style-guide.md (Almost certain / Very likely / Likely / Roughly even / Unlikely / Very unlikely / Remote). To avoid conflicting standards, align this table’s terms + ranges to the style guide and remove the extra synonyms.
| | **2** | **Very unlikely** / *highly improbable* | *Mycket osannolikt* | 5 – 20 % | "A split within SD over migration policy before the 2026 election is very unlikely given the party's current whip discipline." | | |
| | **3** | **Unlikely** / *improbable* | *Osannolikt* | 20 – 45 % | "Unilateral Regeringskansliet blocking of an EU-initiated trilogue is unlikely, given Sweden's Council commitments." | | |
| | **4** | **Roughly even chance** | *Ungefär lika sannolikt som inte* | 45 – 55 % | "There is a roughly even chance that C and L will split over budget priorities in Q3." | | |
| | **5** | **Likely** / *probable* | *Sannolikt* | 55 – 80 % | "The M–KD compromise on the Wind-Power Revenue Act (HD03239) will likely survive the chamber vote." | | |
| | **6** | **Very likely** / *highly probable* | *Mycket sannolikt* | 80 – 95 % | "Very likely the budget discharge will pass on first chamber vote." | | |
| | **7** | **Almost certain** / *nearly certain* | *Så gott som säkert* | 95 – 99 % | "Extra amendment budget FiU48 is almost certain to be adopted this plenary." | | |
| | **2** | **Very unlikely** | *Mycket osannolikt* | 5 – 20 % | "A split within SD over migration policy before the 2026 election is very unlikely given the party's current whip discipline." | | |
| | **3** | **Unlikely** | *Osannolikt* | 20 – 45 % | "Unilateral Regeringskansliet blocking of an EU-initiated trilogue is unlikely, given Sweden's Council commitments." | | |
| | **4** | **Roughly even** | *Ungefär lika sannolikt som inte* | 45 – 55 % | "There is a roughly even chance that C and L will split over budget priorities in Q3." | | |
| | **5** | **Likely** | *Sannolikt* | 55 – 80 % | "The M–KD compromise on the Wind-Power Revenue Act (HD03239) will likely survive the chamber vote." | | |
| | **6** | **Very likely** | *Mycket sannolikt* | 80 – 95 % | "Very likely the budget discharge will pass on first chamber vote." | | |
| | **7** | **Almost certain** | *Så gott som säkert* | 95 – 100 % | "Extra amendment budget FiU48 is almost certain to be adopted this plenary." | |
| 6. **Pass-2 done** — agent has read each core artifact back after creation and committed improvements. (Enforced by file mtime diff: final file mtime > creation time + 3 min, OR two git-history snapshots on disk.) | ||
| 4. **Evidence citations** — `swot-analysis.md` and `significance-scoring.md` contain at least one piece of primary-source evidence per quadrant / ranked item. Accepted evidence patterns: a `dok_id` (e.g. `H901FiU1`, `HD01CU27`) **or** a primary-source URL host (`riksdagen.se`, `regeringen.se`, `scb.se`, `worldbank.org`, `data.imf.org`). Enforced against SWOT `### Strengths/Weaknesses/Opportunities/Threats` sections (bullets + table rows) and significance-scoring bullets **plus** ranking table rows and Mermaid node labels. | ||
| 5. **Mermaid diagrams** — every Family A and Family D synthesis file contains ≥ 1 Mermaid diagram with colour-coded `style` directives (or `themeVariables` / `%%{init …}` block). | ||
| 6. **Pass-2 done** — agent has read each Family A + C core artifact back after creation and committed improvements. (Enforced by file mtime diff: final file mtime > creation time + 3 min, OR two git-history snapshots on disk.) |
There was a problem hiding this comment.
Check 6 description says Pass-2 readback is required for “Family A + C core artifact(s)”, but the actual PASS2_REQ list below enforces Pass-2 evidence for almost every artifact (A+B+C+D, excluding only data-download-manifest.md). Please make the prose match the implementation (or narrow PASS2_REQ) so the contract is unambiguous.
| 6. **Pass-2 done** — agent has read each Family A + C core artifact back after creation and committed improvements. (Enforced by file mtime diff: final file mtime > creation time + 3 min, OR two git-history snapshots on disk.) | |
| 6. **Pass-2 done** — agent has read back each enforced Pass-2 artifact after creation and committed improvements: all Family A, B, C, and D artifacts except `data-download-manifest.md`. (Enforced by file mtime diff: final file mtime > creation time + 3 min, OR two git-history snapshots on disk.) |
| SYNTHESIS=(synthesis-summary.md swot-analysis.md risk-assessment.md threat-analysis.md \ | ||
| stakeholder-perspectives.md significance-scoring.md classification-results.md \ | ||
| cross-reference-map.md) | ||
| cross-reference-map.md executive-brief.md coalition-mathematics.md \ |
There was a problem hiding this comment.
The Mermaid requirement in check 5 is described as covering Family A + Family D, but SYNTHESIS only includes two Family D files (coalition-mathematics.md, forward-indicators.md). Since other Family D templates include Mermaid blocks (e.g. election-2026-analysis.md, voter-segmentation.md), consider expanding SYNTHESIS (or adjust the check text) so enforcement matches the intended contract.
| cross-reference-map.md executive-brief.md coalition-mathematics.md \ | |
| cross-reference-map.md executive-brief.md election-2026-analysis.md \ | |
| voter-segmentation.md coalition-mathematics.md historical-parallels.md \ | |
| media-framing-analysis.md implementation-feasibility.md \ |
| 7. **Family C structure checks** (extension-quality gate): | ||
| - `executive-brief.md` contains a `## 🎯 BLUF` section **and** a `## 🧭 3 Decisions` (or `Decisions This Brief Supports`) section. | ||
| - `intelligence-assessment.md` declares **≥ 3 Key Judgments** with confidence labels (`HIGH`, `MEDIUM`, `LOW`, `VERY HIGH`, `VERY LOW`) and references at least one PIR. | ||
| - `scenario-analysis.md` declares **≥ 3 distinct scenarios** (headers matching `Scenario` count ≥ 3). | ||
| - `comparative-international.md` declares a comparator set or **≥ 2 comparator rows** (structural check, see Tier-C gate). | ||
| - `devils-advocate.md` declares **≥ 3 competing hypotheses** (headers matching `Hypothesis`/`H1`/`H2`/`H3` count ≥ 3, ACH-style). | ||
| - `methodology-reflection.md` is non-empty and contains an **ICD 203 audit** marker or ≥ 3 named methodology improvements. |
There was a problem hiding this comment.
In the Family C structure checklist, the prose says Key Judgments must include confidence labels, but the implementation only counts Key Judgment/KJ-* occurrences and doesn’t validate confidence labeling. Either adjust the checklist wording to match what’s actually enforced, or add a simple pattern check for the expected confidence labels.
|
|
||
| # Tier-C additive check 1 — cross-reference-map.md cites ≥ 1 sibling folder under analysis/daily/ | ||
| if [ -s "$ANALYSIS_DIR/cross-reference-map.md" ]; then | ||
| grep -qE 'analysis/daily/[0-9]{4}-[0-9]{2}-[0-9]{2}/[A-Za-z_-]+' "$ANALYSIS_DIR/cross-reference-map.md" \ |
There was a problem hiding this comment.
Tier-C additive check 1 uses grep -qE 'analysis/daily/.../[A-Za-z_-]+', which will not match valid sibling folders that include digits (e.g. realtime-0930). This can cause false gate failures for workflows that only cite realtime-* siblings. Expand the regex to allow digits (and possibly additional path chars) in the <type> segment.
| grep -qE 'analysis/daily/[0-9]{4}-[0-9]{2}-[0-9]{2}/[A-Za-z_-]+' "$ANALYSIS_DIR/cross-reference-map.md" \ | |
| grep -qE 'analysis/daily/[0-9]{4}-[0-9]{2}-[0-9]{2}/[A-Za-z0-9_-]+' "$ANALYSIS_DIR/cross-reference-map.md" \ |
| 1. **Read all 6 methodologies first** (one tool call per file, do not skip). | ||
| 2. **Read all 8 templates first.** | ||
| 3. **Pass 1 — Create** all 9 artifacts + every per-document file. Minimum 15 minutes of real work. | ||
| 1. **Read all 10 methodologies first** (one tool call per file; skipping fails the gate via `methodology-reflection.md §evidence` audit). |
There was a problem hiding this comment.
Execution order says "Read all 10 methodologies first", but this PR’s own docs indicate 12 methodology modules (and the supporting-frameworks list here already exceeds 10). This mismatch can confuse the workflow contract; update the count or rephrase to "read all relevant methodologies" and keep it consistent with .github/prompts/README.md / analysis/methodologies/README.md.
| 1. **Read all 10 methodologies first** (one tool call per file; skipping fails the gate via `methodology-reflection.md §evidence` audit). | |
| 1. **Read all relevant methodologies first** (the primary methodology guide plus every supporting framework listed above; one tool call per file; skipping fails the gate via `methodology-reflection.md §evidence` audit). |
|
@copilot apply changes based on the comments in this thread |
Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/9d64368a-8f56-4991-84c3-4232798184b3 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Applied all 6 review comments in
|
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
Changes (review round 2)
Addresses the 6 Copilot review comments on commit
e570e8f.analysis/methodologies/osint-tradecraft-standards.md§3.1 — WEP table now uses the canonical 7-band vocabulary frompolitical-style-guide.md(Remote / Very unlikely / Unlikely / Roughly even / Likely / Very likely / Almost certain); non-canonical synonyms removed (no more "probable", "highly probable", "almost no chance"); numeric ranges realigned to the style-guide bands..github/prompts/05-analysis-gate.mdcheck 6 — prose now says Pass-2 readback applies to "all Family A, B, C, and D artifacts exceptdata-download-manifest.md", matching the actualREQlist enforcement..github/prompts/05-analysis-gate.mdcheck 5 (SYNTHESIS) — expandedSYNTHESISbash array to cover all 7 Family D files (election-2026-analysis.md,voter-segmentation.md,coalition-mathematics.md,historical-parallels.md,media-framing-analysis.md,implementation-feasibility.md,forward-indicators.md) so Mermaid enforcement matches the "Family A + Family D" prose..github/prompts/05-analysis-gate.mdcheck 7 — prose clarified to state structural enforcement + confidence-label audit, and the bash gate now actively countsVERY HIGH|HIGH|MEDIUM|LOW|VERY LOWoccurrences inintelligence-assessment.md(≥ 3 required) so the check matches the prose contract..github/prompts/ext/tier-c-aggregation.md— Tier-C sibling-folder regex expanded to[A-Za-z0-9_-]+so folders with digits (e.g.realtime-0930,evening-2200) no longer cause false gate failures..github/prompts/04-analysis-pipeline.md— "Read all 10 methodologies first" → "Read all relevant methodologies first (includingosint-tradecraft-standards.md)"; removes the 10 vs 12 inconsistency with.github/prompts/README.mdandanalysis/methodologies/README.md.Compilation
gh aw compilev0.69.3 → 12 workflows, 0 errors / 0 warnings..lock.ymlfiles changed — the four affected prompts are all{{#runtime-import}}imports in the compiled workflows, resolved at runtime.