test(network-diagnostics): align tests with shared news-prewarm composite action#2009
Merged
test(network-diagnostics): align tests with shared news-prewarm composite action#2009
Conversation
…ction (PR #2008) Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/9779450d-1150-4617-ae7c-9a19f74bef10 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pethers
April 26, 2026 09:38
View session
Contributor
🏷️ Automatic Labeling SummaryThis PR has been automatically labeled based on the files changed and PR metadata. Applied Labels: testing,size-m Label Categories
For more information, see |
Contributor
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the network-diagnostics test suite to reflect the post-#2008 architecture where pre-warm + pre-flight diagnostics moved from inline workflow YAML into the shared composite action .github/actions/news-prewarm/action.yml.
Changes:
- Add constants to reference the shared
news-prewarmcomposite action path and theuses:wiring string. - Move diagnostics literal assertions (step names, DNS/HTTPS/tool-count checks, required domain probes) from per-workflow greps to a single assertion against the composite action file.
- Update workflow assertions to verify frontmatter
steps:wiresuses: ./.github/actions/news-prewarm, while keeping effective-prompt health-gate checks (get_sync_status,safeoutputs___noop) intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
14 assertions in
tests/network-diagnostics.test.tsfailed after PR #2008 extracted the inline pre-flight/pre-warm YAML from everynews-*.mdworkflow into the shared composite action.github/actions/news-prewarm/action.yml. The tests still grepped each workflow file for literals (Pre-flight external endpoint reachability check,DNS Resolution Tests, …) that now live only in the action.Test-only change — workflows and the action are correct as merged.
Changes —
tests/network-diagnostics.test.tsNEWS_PREWARM_ACTIONandNEWS_PREWARM_USES_REFto point at the shared action.Network and MCP diagnostics), carries the canonical diagnostics content (DNS / HTTPS / MCP tool count), and probes every entry inREQUIRED_MCP_DOMAINS. Every workflow must wireuses: ./.github/actions/news-prewarmin its frontmattersteps:.get_sync_status+safeoutputs___noophealth-gate assertions on the effective prompt surface; replace the per-workflow inline pre-flight grep with theuses:reference check, and assert the Render MCP endpoint is probed inside the action.news-propositions.mdto the action; per-workflow check accepts theuses:wiring as a valid pre-warm signal.