Advanced js week4 mila#225
Conversation
…r, center the heading,script.css add button to change the background,reflection.md reflect on Copilot use
Add file with a link to Trello
Ai-week1-Mila
Khandohii
left a comment
Khandohii
left a comment
There was a problem hiding this comment.
Great job, Liudmyla! The application successfully captures screenshots. Unfortunately, I wasn’t able to fully test saving and loading screenshots due to endpoint limitations. Good catch noting that the API can be unstable.
I’ve left a couple of small suggestions in the comments. For the future, it would be really helpful to include clear steps on how to test the application — it makes things much easier for reviewers, especially for someone who is new to the project 🙂
| @@ -0,0 +1,56 @@ | |||
| <!doctype html> | |||
There was a problem hiding this comment.
I assume the files outside the screenshotGenerator folder are not related to the final result. It would be good to remove them if they are not used, to keep the file structure clean and clear.
| if (err instanceof SaveError) { | ||
| error.textContent = err.toUserMessage(); | ||
| } else if (err instanceof TypeError) { | ||
| error.textContent = new NetworkError().toUserMessage(); |
There was a problem hiding this comment.
This error occurs with the response "413 Request Entity Too Large", which is not related to network issues. It would be better to show a more appropriate message to the user, such as: "Could not save the screenshot. Please try again later."
There was a problem hiding this comment.
Dmytro, that’s a great point!
You’re right — a 413 "Request Entity Too Large" error is not a network issue, so the current message is misleading.
I’ll update the error handling to provide a more accurate user-facing message.
|
Thank you for the kind feedback! Also, thank you for highlighting the importance of adding testing steps — I’ll definitely include clearer instructions in future PRs. |
2 participants
PR contains a Screenshot Generator app that allows users to capture, save, and manage website screenshots using external APIs.
The app integrates two APIs:
The user can:
Notes
What I learned
This assignment helped me practice working with APIs, structuring code into modules, handling errors in a more organized way, and designing reusable UI components using classes.