Fix dead instructions link, align task numbers to the chapter, scope az login to HYF tenant#2
Merged
Conversation
… scope az login to HYF tenant - README: the "full assignment instructions" link pointed at hackyourfuture.github.io/datatrack/week-5/assignment, which 404s. Repoint it to the Week 5 assignment page in the Notion curriculum. - Renumber tasks to match the assignment chapter (8 tasks): add Task 3 (the provided test suite), so Dockerfile=4, Configuration=5, CI=6, ACR push=7, AI report=8. Updates README, ci.yml, Dockerfile, AI_ASSIST.md, pipeline.py, and the grader's deliverable message. - README: az login now targets the HackYourFuture tenant (--tenant 07a14c4e-...), preventing the "wrong tenant" failure for students who also have a personal/other-org Azure account. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
lassebenni
commented
Jun 1, 2026
lassebenni
left a comment
lassebenni
left a comment
Collaborator
Author
There was a problem hiding this comment.
Local review by Claude — 0 blocking, 0 warnings.
Python/bash assignment repo, so the dbt/PBI validators are N/A. Ran the applicable ones:
python -m py_compile src/pipeline.py tests/test_pipeline.py→ OK- Grader
bash -n .hyf/test.sh→ OK, and ran it end-to-end on the scaffold: Score 39/100,pass=false(expected —NotImplementedErrorstubs still present). Logic intact; the edited deliverable message now readsTask 7 deliverable. ci.ymlchange is a comment only;grade-assignment.ymluntouched (no functional YAML change).- Task-number references are consistent across all 6 files (1→8 model); no
github.iolink or conflict markers remain.
Manual eyeball (not machine-verifiable): the new instructions link is a Notion page URL — it follows the curriculum's link convention and replaces a confirmed 404, but I can't confirm it resolves for a logged-in student from here. Worth a quick click-test before merge.
✅ No code issues to fix.
Collaborator
Author
|
@copilot review |
Reviewed. I re-ran local checks ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes surfaced while verifying the Week 5 ACR flow end-to-end.
1. Dead instructions link (the notable one)
The README sent students to
hackyourfuture.github.io/datatrack/week-5/assignmentfor the full Task 7 (ACR push) steps — that URL 404s. Repointed to the Week 5 assignment page in the Notion curriculum.2. Task numbers were off by one vs the chapter
The repo numbered tasks 1–7 (ACR push = Task 6), but the assignment chapter has 8 tasks (ACR push = Task 7, AI report = Task 8). A student reading both got conflicting numbers. Renumbered to match: added Task 3 for the provided test suite, so Dockerfile=4, Configuration=5, CI=6, ACR=7, AI=8. Updated README,
ci.yml,Dockerfile,AI_ASSIST.md,src/pipeline.py, and the grader's deliverable message. Grader scoring tiers ("Level N") and logic are unchanged.3.
az logincould land on the wrong tenantREADME said
az login --use-device-codewith no tenant. Students who also have a personal/other-org Azure account would authenticate there and getunauthorizedonaz acr login. Now targets the HYF tenant:az login --use-device-code --tenant 07a14c4e-....Verified: grader
bash -nclean; no task-number references remain inconsistent; nogithub.iolink remains.🤖 Generated with Claude Code