Skip to content

fix(review): de-stack blockquotes + drop vague timing in Task 7 callout#4

Merged
lassebenni merged 1 commit into
mainfrom
fix/review-readme-callout
Jun 2, 2026
Merged

fix(review): de-stack blockquotes + drop vague timing in Task 7 callout#4
lassebenni merged 1 commit into
mainfrom
fix/review-readme-callout

Conversation

@lassebenni

Copy link
Copy Markdown
Collaborator

Self-review of #3. Two warnings:

  1. Stacked blockquotes. My Slack callout sits directly above the pre-existing > These task numbers… blockquote. GitHub renders the two > blocks as separate quote panels. Fix: convert the pre-existing blockquote into regular prose so the 💡 callout stands alone.
  2. Vague timing. 'DMs it to you over Slack before the assignment is due' is uninformative. Drop the clause: the next sentence's 'if you have not received it by the time you reach Task 7' already gives the right trigger.

Single-callout self-review per the /review-pr workflow.

Convert the pre-existing 'These task numbers match...' blockquote into
regular prose so the new 'Task 7 credentials' 💡 callout no longer
stacks against another quote block. Drop the 'before the assignment is
due' clause: the next sentence already establishes the right trigger
('if you have not received it by the time you reach Task 7').

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Self-review tweaks to a Task 7 README callout: removes a stacked blockquote and trims vague timing wording.

Changes:

  • Convert the pre-existing > line into plain prose so the 💡 callout renders as a single blockquote.
  • Drop the "before the assignment is due" clause from the Slack DM sentence.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lassebenni lassebenni merged commit 8830bc7 into main Jun 2, 2026
2 checks passed
@lassebenni lassebenni deleted the fix/review-readme-callout branch June 2, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants