fix: correct usage of customHeaderCount to keep arrows on any monthsShown prop#5618
Merged
martijnrusschen merged 5 commits intoHacker0x01:mainfrom May 25, 2025
Merged
fix: correct usage of customHeaderCount to keep arrows on any monthsShown prop#5618martijnrusschen merged 5 commits intoHacker0x01:mainfrom
martijnrusschen merged 5 commits intoHacker0x01:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5618 +/- ##
=======================================
Coverage 96.99% 96.99%
=======================================
Files 30 30
Lines 3363 3363
Branches 1404 1419 +15
=======================================
Hits 3262 3262
Misses 101 101 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: correct usage of customHeaderCount to keep arrows on any monthsShown prop
name: Pull Request
about: Create a pull request to improve this repository
title: Correct usage of customHeaderCount to keep arrows on any monthsShown prop
labels: docs
assignees: johannrp27
Description
Linked issue: #(issue number)
Problem
If you follow the example of Custom-header-with-two-months-displayed it actually works ONLY if monthsShown is set to 2. When you set more or less monthsShown values, the arrows does not look good. See reference image.
Changes
I found a patch by using monthsShown number. This value has to be stored to use within customHeader alongside customHeaderCount, and invert the style statement condition.
Screenshots
Current issue
After patch
To reviewers
Contribution checklist