feat: add keyboard accessibility for timepicker#6039
Merged
martijnrusschen merged 8 commits intoHacker0x01:mainfrom Nov 26, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6039 +/- ##
==========================================
+ Coverage 98.91% 99.21% +0.30%
==========================================
Files 30 30
Lines 3496 3582 +86
Branches 1470 1509 +39
==========================================
+ Hits 3458 3554 +96
+ Misses 37 27 -10
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
It looks like our code coverage tool isn't too happy with the changes yet. Please check out the results and check how test coverage can be improved. |
Refactor timepicker tests to improve clarity and functionality.
Cap new time calculation at the last valid interval of the day.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
#9097, #6036
Description (What does it do?)
This PR adds keyboard accessibility support for time-only pickers. When the time input is focused and the dropdown is open, ArrowUp/ArrowDown increment or decrement the selected time by the configured
timeIntervals(default 30 minutes), update the input value in real-time, and automatically scroll the highlighted option into view in the dropdown. The Enter key commits the current typed value if it's valid, or falls back to the currently highlighted option in the dropdown if the input is invalid or empty. After committing, the dropdown closes and onChange is triggered with the selected time.The implementation adds three new methods:
handleTimeOnlyArrowKeyfor handling arrow key navigation,handleTimeOnlyEnterKeyfor parsing and committing the selected time, andscrollToTimeOptionfor finding and scrolling the matching time option into view.Screencast
Screen.Recording.2025-11-11.at.3.38.55.PM.mov