Skip to content

fix: add inline styles to sr-only spans for CSS-independent accessibility #6178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
martijnrusschen wants to merge 1 commit into from
Closed

fix: add inline styles to sr-only spans for CSS-independent accessibility #6178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions src/calendar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,19 @@ export default class Calendar extends Component<CalendarProps, CalendarState> {
this.props.calendarStartDay,
);

// Inline sr-only styles ensure weekday names work without CSS import
const srOnlyStyles: React.CSSProperties = {
position: "absolute",
width: "1px",
height: "1px",
padding: 0,
margin: "-1px",
overflow: "hidden",
clipPath: "inset(50%)",
whiteSpace: "nowrap",
border: 0,
};

const dayNames: React.ReactElement[] = [];
if (this.props.showWeekNumbers) {
dayNames.push(
Expand All @@ -517,7 +530,9 @@ export default class Calendar extends Component<CalendarProps, CalendarState> {
className={`react-datepicker__day-name ${disabled ? "react-datepicker__day-name--disabled" : ""}`}
role="columnheader"
>
<span className="react-datepicker__sr-only">Week number</span>
<span className="react-datepicker__sr-only" style={srOnlyStyles}>
Week number
</span>
<span aria-hidden="true">{this.props.weekLabel || "#"}</span>
</div>,
);
Expand Down Expand Up @@ -568,7 +583,9 @@ export default class Calendar extends Component<CalendarProps, CalendarState> {
disabled ? "react-datepicker__day-name--disabled" : "",
)}
>
<span className="react-datepicker__sr-only">{fullDayName}</span>
<span className="react-datepicker__sr-only" style={srOnlyStyles}>
{fullDayName}
</span>
<span aria-hidden="true">{weekDayName}</span>
</div>
);
Expand Down
Loading