fix: clamp month navigation to min/max to prevent snap-back (#6290)#6291
Open
GauravDhuri wants to merge 1 commit into
Open
fix: clamp month navigation to min/max to prevent snap-back (#6290)#6291GauravDhuri wants to merge 1 commit into
GauravDhuri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Create a pull request to improve this repository
title: ""
labels: ""
assignees: ""
Description
Linked issue: #6290
Problem
When we pick a month from the month dropdown, the calendar sometimes jumps to that month for a moment and then snaps back to the month we were already on.
Changes
[minDate, maxDate]before passing it tohandleCustomMonthChange/setPreSelection. This keeps the target date selectable, so the view stays n the picked month andonMonthChangefires exactly once with the correct math.maxDateboundary.Screenshots
Datepicker.month.snapback.-.Fix.mov
To reviewers
Contribution checklist