feat: simplify sponsor page messaging

Author: newbe36524

src/renderer/components/SidebarNavigation.subscription.render.test.ts

@@ -22,7 +22,10 @@ describe('subscription sidebar and shell wiring', () => {
     assert.match(sidebarSource, /labelKey: 'sidebar\.subscription'/);
     assert.match(sidebarSource, /distributionState\.winStoreMode/);
     assert.match(sidebarSource, /typeof window\.electronAPI\.subscription\?\.getSnapshot === 'function'/);
-    assert.match(sidebarSource, /getSubscriptionBadgeLabel\(subscriptionSnapshot, t\)/);
+    assert.doesNotMatch(sidebarSource, /selectSubscriptionSnapshot/);
+    assert.doesNotMatch(sidebarSource, /getSubscriptionBadgeLabel/);
+    assert.doesNotMatch(sidebarSource, /getSubscriptionBadgeVariant/);
+    assert.doesNotMatch(sidebarSource, /item\.id === 'subscription'/);
     assert.match(appSource, /import SubscriptionPage from '\.\/components\/subscription\/SubscriptionPage';/);
     assert.match(appSource, /subscriptionFeatureEnabled && currentView === 'subscription' && <SubscriptionPage \/>/);
     assert.match(storeSource, /subscriptionFeatureEnabled \? \[store\.dispatch\(loadSubscriptionSnapshot\(\)\)\] : \[\]/);

src/renderer/components/SidebarNavigation.tsx

@@ -19,10 +19,7 @@ import {
 } from 'lucide-react';
 import { switchView } from '../store/slices/viewSlice';
 import type { RootState } from '../store';
-import { selectSubscriptionSnapshot } from '../store/slices/subscriptionSlice';
 import type { ViewType } from '../store/slices/viewSlice';
-import type { SubscriptionSnapshot } from '../../types/subscription.js';
-import { Badge } from './ui/badge';
 import { ThemeToggle } from './ui/theme-toggle';
 import { LanguageToggle } from './ui/language-toggle';
 import { Popover, PopoverContent, PopoverTrigger } from './ui/popover';
@@ -145,43 +142,6 @@ function getAboutEntryHint(entry: SidebarAboutEntry): string {
   return entry.detail;
 }
 
-function getSubscriptionBadgeVariant(snapshot: SubscriptionSnapshot | null): 'default' | 'secondary' | 'destructive' | 'outline' {
-  if (!snapshot) {
-    return 'outline';
-  }
-
-  if (snapshot.availability !== 'supported') {
-    return 'destructive';
-  }
-
-  if (snapshot.isStale) {
-    return 'secondary';
-  }
-
-  return snapshot.status === 'active' ? 'default' : 'outline';
-}
-
-function getSubscriptionBadgeLabel(
-  snapshot: SubscriptionSnapshot | null,
-  t: (key: string) => string,
-): string {
-  if (!snapshot) {
-    return t('sidebar.subscriptionStatus.loading');
-  }
-
-  if (snapshot.availability !== 'supported') {
-    return t('sidebar.subscriptionStatus.unavailable');
-  }
-
-  if (snapshot.isStale) {
-    return t('sidebar.subscriptionStatus.stale');
-  }
-
-  return snapshot.status === 'active'
-    ? t('sidebar.subscriptionStatus.active')
-    : t('sidebar.subscriptionStatus.inactive');
-}
-
 function AboutBrandLogo({ entry }: { entry: SidebarAboutEntry }) {
   const [imageFailed, setImageFailed] = useState(false);
   const domain = getAboutBrandDomain(entry);
@@ -213,7 +173,6 @@ export default function SidebarNavigation({ distributionState }: SidebarNavigati
   const { t, i18n } = useTranslation('common');
   const dispatch = useDispatch();
   const currentView = useSelector((state: RootState) => state.view.currentView);
-  const subscriptionSnapshot = useSelector((state: RootState) => selectSubscriptionSnapshot(state));
   const isFusionMode = distributionState.fusionMode;
   const subscriptionFeatureEnabled = distributionState.winStoreMode
     && typeof window.electronAPI.subscription?.getSnapshot === 'function';
@@ -569,15 +528,6 @@ export default function SidebarNavigation({ distributionState }: SidebarNavigati
                         <span className="truncate font-medium text-sm whitespace-nowrap">
                           {t(item.labelKey)}
                         </span>
-
-                        {item.id === 'subscription' ? (
-                          <Badge
-                            variant={getSubscriptionBadgeVariant(subscriptionSnapshot)}
-                            className="rounded-md px-1.5 py-0 text-[10px] uppercase tracking-[0.14em]"
-                          >
-                            {getSubscriptionBadgeLabel(subscriptionSnapshot, t)}
-                          </Badge>
-                        ) : null}
                       </motion.div>
                     )}
                   </AnimatePresence>

src/renderer/components/subscription/SubscriptionPage.render.test.ts

@@ -7,7 +7,7 @@ const pagePath = path.resolve(process.cwd(), 'src/renderer/components/subscripti
 const slicePath = path.resolve(process.cwd(), 'src/renderer/store/slices/subscriptionSlice.ts');
 
 describe('subscription workspace renderer', () => {
-  it('renders loading, stale, unsupported, entitlement, and diagnostics states with thunk-driven actions', async () => {
+  it('renders a centered subscription card with thunk-driven actions and sponsor messaging', async () => {
     const [pageSource, sliceSource] = await Promise.all([
       fs.readFile(pagePath, 'utf8'),
       fs.readFile(slicePath, 'utf8'),
@@ -19,12 +19,16 @@ describe('subscription workspace renderer', () => {
     assert.match(pageSource, /dispatch\(refreshSubscriptionSnapshot\(\)\)/);
     assert.match(pageSource, /dispatch\(purchaseSubscription\(\)\)/);
     assert.match(pageSource, /subscription\.purchaseOutcome\./);
-    assert.match(pageSource, /subscriptionEntitlementNames\.map\(\(entitlement\) => \{/);
-    assert.match(pageSource, /subscription\.entitlements\.names\.\$\{entitlement\}/);
-    assert.match(pageSource, /subscription\.entitlements\.details\.\$\{entitlement\}/);
-    assert.match(pageSource, /subscription\.diagnostics\.title/);
-    assert.match(pageSource, /selectHasSubscriptionEntitlement\(state, 'sponsorBadge'\)/);
-    assert.match(pageSource, /selectHasSubscriptionEntitlement\(state, 'premiumFeatureGate'\)/);
+    assert.match(pageSource, /mx-auto max-w-2xl overflow-hidden rounded-\[36px\]/);
+    assert.match(pageSource, /subscription\.message\.ongoingTitle/);
+    assert.match(pageSource, /subscription\.message\.perksTitle/);
+    assert.match(pageSource, /subscription\.message\.unlockNoticeTitle/);
+    assert.match(pageSource, /subscription\.message\.unlockNoticeDescription/);
+    assert.match(pageSource, /subscription\.message\.activeThanks/);
+    assert.match(pageSource, /subscription\.message\.inactivePrompt/);
+    assert.doesNotMatch(pageSource, /subscriptionEntitlementNames\.map\(\(entitlement\) => \{/);
+    assert.doesNotMatch(pageSource, /selectHasSubscriptionEntitlement/);
+    assert.doesNotMatch(pageSource, /subscription\.snapshot\.fields\.lastCheckedAt/);
     assert.match(sliceSource, /createAsyncThunk\(/);
     assert.match(sliceSource, /'subscription\/loadSnapshot'/);
     assert.match(sliceSource, /'subscription\/refreshSnapshot'/);