ci: extend placeholder-coverage check to all processed directories#32
Open
dmchaledev wants to merge 1 commit into
Open
ci: extend placeholder-coverage check to all processed directories#32dmchaledev wants to merge 1 commit into
dmchaledev wants to merge 1 commit into
Conversation
The grep that validates no core placeholders remain after customize.sh was scoped to $tmpdir/policies only. customize.sh also writes to templates/, industry-variants/, and docs/, all of which contain [Company Name], [Date], [Security Officer], and other core placeholders — meaning unreplaced placeholders in those directories would pass CI silently. Widen the grep root from $tmpdir/policies to $tmpdir so every output directory is covered. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NReYztvPgEeiXKj9dbBTuk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
placeholder-coverageCI job rancustomize.sh --output-dir $tmpdir, which writes customized files to$tmpdir/policies/,$tmpdir/templates/,$tmpdir/industry-variants/, and$tmpdir/docs/. But the post-run grep that asserts no core placeholders remain was scoped to$tmpdir/policiesonly — so unreplaced placeholders in the other three directories would silently pass CI.Confirmed:
templates/,industry-variants/, anddocs/all contain core placeholders today ([Company Name],[Date],[Security Officer],[IT Contact]) that are in-scope forcustomize.shbut were invisible to the CI check.Change
One-line fix: widen the grep root from
$tmpdir/policies→$tmpdir.Also updated the success message to reflect the broader scope.
Test plan
placeholder-coveragejob passes with the fix applied (all placeholders in templates, industry-variants, and docs are replaced by the fullcustomize.shflag set used in CI)customize.shand re-running CI should now fail for files outsidepolicies/, confirming the check is active🤖 Generated with Claude Code
https://claude.ai/code/session_01NReYztvPgEeiXKj9dbBTuk
Generated by Claude Code