ci: broaden placeholder-coverage check to all customize.sh output dirs#39
Open
dmchaledev wants to merge 1 commit into
Open
ci: broaden placeholder-coverage check to all customize.sh output dirs#39dmchaledev wants to merge 1 commit into
dmchaledev wants to merge 1 commit into
Conversation
customize.sh customizes markdown under policies/, templates/, industry-variants/, and docs/ (per TARGET_FILES), but the CI placeholder-coverage job only asserted no leftover placeholders in policies/. A future regression that broke substitution in the other three directories (which also contain core placeholders like [Company Name] and [Security Officer]) would pass CI silently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/customize.shcustomizes markdown files under four directories (policies/,templates/,industry-variants/,docs/— see itsTARGET_FILESdefinition), but the CIplaceholder-coveragejob only asserted that no core placeholders ([Company Name],[Security Officer], etc.) remained inpolicies/after a full run.I verified that
templates/,industry-variants/, anddocs/also contain these same core placeholders today (e.g.industry-variants/healthcare-hipaa-overlay.md,templates/incident-forms/breach_notification_template.md,docs/framework_mapping.md), so a future regression in substitution logic for those directories — a typo in a placeholder, a new placeholder added to a template but not wired intocustomize.sh's sed args, etc. — would currently pass CI silently because the check never looks there.This PR widens the CI assertion to scan all four directories customize.sh actually writes to, matching the tool's real surface area.
customize.shitself — this only strengthens the CI regression test.--company/--date/.../--output-dirrun).Test plan
scripts/customize.shlocally with all flags set and--output-dir, then applied the new (broadened) grep check againstpolicies/,templates/,industry-variants/, anddocs/in the output — passes with no remaining placeholders.shellcheck scripts/customize.shstill passes (script unchanged).shellcheck+placeholder-coveragejobs) — will confirm green once triggered.Generated by Claude Code