fix: stuck camera while moving#1899
Closed
quanghuynh99 wants to merge 14 commits intoHaishinKit:mainfrom
Closed
Conversation
fix: stuck when moving camera
fix: re calculate duration and timeline for stuck frames
feature: add method for video customize
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation
Summary
Improves the render timing pipeline in Screen.swift to reduce frame stutter/freezing during fast camera movement.
Stabilizes frame pacing and timestamps before creating CMSampleBuffer .
Root Cause
presentationTimeStamp could become non-monotonic when capture/render latency fluctuates.
frameDuration could vary too much between consecutive frames during rapid motion.
Sudden latency shifts caused visible jitter and short frame stalls.
Type of change
Please delete options that are not relevant.
Demo (video from Android using VLC app that watch video stream from iPhone X):
https://drive.google.com/file/d/186ImpDCjmSb8kGZUJe70n8F7CpUqfKOw/view?usp=sharing