[core] Added checks to prevent rogue CMD MSG to sneak thru#3323
Open
ethouris wants to merge 1 commit into
Open
[core] Added checks to prevent rogue CMD MSG to sneak thru#3323ethouris wants to merge 1 commit into
ethouris wants to merge 1 commit into
Conversation
Collaborator
ethouris
commented
May 19, 2026
ethouris
commented
- Added a check to ensure that every command message is aligned to 4 bytes and is at least 4 bytes long.
- Removed excessive checks in particular messages where it was not necessary.
- Updated test case with removal of cases that are prevented from upside.
- Added missing minimum check for ACK message beside the LITE ACK case.
ethouris
added
Type: Maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.