Personal copy of anomalyco/opencode#29208: fix(config): catch parse errors gracefully during startup

packages/opencode/src/config/config.ts

@@ -420,11 +420,26 @@ export const layer = Layer.effect(
             : { text, type: "virtual", ...options, env },
         ),
       )
-      const parsed = ConfigParse.jsonc(expanded, source)
-      const data = ConfigParse.schema(Info, normalizeLoadedConfig(parsed, source), source)
+      const data = yield* Effect.sync(() => {
+        const parsed = ConfigParse.jsonc(expanded, source)
+        return ConfigParse.schema(Info, normalizeLoadedConfig(parsed, source), source)
+      }).pipe(
+        Effect.catchCause((cause) =>
+          Effect.sync(() => {
+            log.error("invalid config", { path: source, cause })
+            return Schema.decodeSync(Info)({})
+          }),
+        ),
+      )
       if (!("path" in options)) return data
 
-      yield* Effect.promise(() => resolveLoadedPlugins(data, options.path))
+      yield* Effect.promise(() => resolveLoadedPlugins(data, options.path)).pipe(
+        Effect.catchCause((cause) =>
+          Effect.sync(() => {
+            log.error("plugin resolution failed", { path: source, cause })
+          }),
+        ),
+      )
       if (!data.$schema) {
         data.$schema = "https://opencode.ai/config.json"
         const updated = text.replace(/^\s*\{/, '{\n  "$schema": "https://opencode.ai/config.json",')

packages/opencode/test/config/config.test.ts

@@ -580,24 +580,61 @@ accountTokenIt.instance("resolves env templates in account config with account t
   }),
 )
 
-it.instance("validates config schema and throws on invalid fields", () =>
+it.instance("handles invalid schema gracefully without crashing", () =>
   Effect.gen(function* () {
     const test = yield* TestInstance
     yield* writeConfigEffect(test.directory, {
       $schema: "https://opencode.ai/config.json",
       invalid_field: "should cause error",
     })
-    const exit = yield* Config.use.get().pipe(Effect.exit)
-    expect(Exit.isFailure(exit)).toBe(true)
+    const config = yield* Config.use.get()
+    expect(config.username).toBeDefined()
+    expect("invalid_field" in config).toBe(false)
   }),
 )
 
-it.instance("throws error for invalid JSON", () =>
+it.instance("handles invalid JSON gracefully without crashing", () =>
   Effect.gen(function* () {
     const test = yield* TestInstance
     yield* AppFileSystem.use.writeWithDirs(path.join(test.directory, "opencode.json"), "{ invalid json }")
-    const exit = yield* Config.use.get().pipe(Effect.exit)
-    expect(Exit.isFailure(exit)).toBe(true)
+    const config = yield* Config.use.get()
+    expect(config.username).toBeDefined()
+  }),
+)
+
+it.instance("handles invalid JSONC syntax gracefully without crashing", () =>
+  Effect.gen(function* () {
+    const test = yield* TestInstance
+    yield* AppFileSystem.use.writeWithDirs(
+      path.join(test.directory, "opencode.jsonc"),
+      `{
+        // comment
+        "model": "test/model",
+        "username": "testuser",`,
+    )
+    const config = yield* Config.use.get()
+    expect(config.username).toBeDefined()
+  }),
+)
+
+it.instance("skips bad config file but merges others", () =>
+  Effect.gen(function* () {
+    const test = yield* TestInstance
+    yield* AppFileSystem.use.writeWithDirs(
+      path.join(test.directory, "opencode.json"),
+      JSON.stringify({
+        $schema: "https://opencode.ai/config.json",
+        model: "global/model",
+        username: "globaluser",
+      }),
+    )
+    yield* AppFileSystem.use.writeWithDirs(
+      path.join(test.directory, "opencode.jsonc"),
+      "{ invalid json }",
+    )
+    const config = yield* Config.use.get()
+    expect(config.model).toBe("global/model")
+    expect(config.username).toBe("globaluser")
   }),
 )