fix: Octave test compatibility — replace contains(), fix Abstract classdef

- Replace contains() with strfind() in 6 Octave test files
- Remove (Abstract) attribute from DataSource.m (unsupported in Octave)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: HanSur94

libs/EventDetection/DataSource.m

@@ -1,4 +1,4 @@
-classdef (Abstract) DataSource < handle
+classdef DataSource < handle
     % DataSource  Abstract interface for fetching new sensor data.
     %
     %   Subclasses must implement fetchNew() which returns a struct:

tests/test_data_source.m

@@ -18,7 +18,7 @@ function test_cannot_instantiate()
         ds = DataSource();
         error('Should not reach here');
     catch ex
-        assert(contains(ex.message, 'Abstract'), 'cannot_instantiate');
+        assert(~isempty(strfind(ex.message, 'Abstract')), 'cannot_instantiate');
     end
     fprintf('  PASS: test_cannot_instantiate\n');
 end

tests/test_data_source_map.m

@@ -49,7 +49,7 @@ function test_unknown_key_errors()
         m.get('nope');
         error('Should not reach here');
     catch ex
-        assert(contains(ex.identifier, 'unknownKey'), 'error_id');
+        assert(~isempty(strfind(ex.identifier, 'unknownKey')), 'error_id');
     end
     fprintf('  PASS: test_unknown_key_errors\n');
 end

tests/test_event_console.m

@@ -13,13 +13,13 @@ function test_event_console()
     % testPrintEventSummary — should not error, should produce output
     out = evalc('printEventSummary(events)');
     assert(~isempty(out), 'printSummary: produces output');
-    assert(contains(out, 'Temperature'), 'printSummary: contains sensor name');
-    assert(contains(out, 'warning high'), 'printSummary: contains threshold label');
-    assert(contains(out, 'Pressure'), 'printSummary: contains second sensor');
+    assert(~isempty(strfind(out, 'Temperature')), 'printSummary: contains sensor name');
+    assert(~isempty(strfind(out, 'warning high')), 'printSummary: contains threshold label');
+    assert(~isempty(strfind(out, 'Pressure')), 'printSummary: contains second sensor');
 
     % testPrintEventSummaryEmpty — should not error
     out = evalc('printEventSummary([])');
-    assert(contains(out, 'No events'), 'printSummaryEmpty: no events message');
+    assert(~isempty(strfind(out, 'No events')), 'printSummaryEmpty: no events message');
 
     % testEventLogger — returns function handle
     logger = eventLogger();
@@ -28,9 +28,9 @@ function test_event_console()
     % testEventLoggerOutput — prints one-line log
     out = evalc('logger(e1)');
     assert(~isempty(out), 'eventLoggerOutput: produces output');
-    assert(contains(out, 'EVENT'), 'eventLoggerOutput: contains EVENT tag');
-    assert(contains(out, 'Temperature'), 'eventLoggerOutput: contains sensor name');
-    assert(contains(out, 'warning high'), 'eventLoggerOutput: contains label');
+    assert(~isempty(strfind(out, 'EVENT')), 'eventLoggerOutput: contains EVENT tag');
+    assert(~isempty(strfind(out, 'Temperature')), 'eventLoggerOutput: contains sensor name');
+    assert(~isempty(strfind(out, 'warning high')), 'eventLoggerOutput: contains label');
 
     fprintf('    All 4 event_console tests passed.\n');
 end

tests/test_event_snapshot.m

@@ -38,8 +38,8 @@ function test_generates_two_pngs()
     assert(numel(files) == 2, 'two_files');
     assert(isfile(files{1}), 'detail_exists');
     assert(isfile(files{2}), 'context_exists');
-    assert(contains(files{1}, 'detail'), 'detail_name');
-    assert(contains(files{2}, 'context'), 'context_name');
+    assert(~isempty(strfind(files{1}, 'detail')), 'detail_name');
+    assert(~isempty(strfind(files{2}, 'context')), 'context_name');
     rmdir(outDir, 's');
     fprintf('  PASS: test_generates_two_pngs\n');
 end

tests/test_event_store.m

@@ -53,7 +53,7 @@ function test_event_store()
         EventViewer.fromFile('/tmp/nonexistent_event_store.mat');
     catch e
         threw = true;
-        assert(contains(e.identifier, 'fileNotFound'), 'fromFile: correct error id');
+        assert(~isempty(strfind(e.identifier, 'fileNotFound')), 'fromFile: correct error id');
     end
     assert(threw, 'fromFile: throws on missing file');
 

tests/test_notification_rule.m

@@ -56,10 +56,10 @@ function test_fill_template()
     ev = Event(now, now + 1/24, 'temp', 'HH', 100, 'upper');
     ev.setStats(105, 10, 90, 105, 98, 99, 3);
     subj = r.fillTemplate(r.Subject, ev);
-    assert(contains(subj, 'temp'), 'subj_sensor');
-    assert(contains(subj, 'HH'), 'subj_threshold');
-    assert(contains(subj, 'upper'), 'subj_direction');
+    assert(~isempty(strfind(subj, 'temp')), 'subj_sensor');
+    assert(~isempty(strfind(subj, 'HH')), 'subj_threshold');
+    assert(~isempty(strfind(subj, 'upper')), 'subj_direction');
     msg = r.fillTemplate(r.Message, ev);
-    assert(contains(msg, '105'), 'msg_peak');
+    assert(~isempty(strfind(msg, '105')), 'msg_peak');
     fprintf('  PASS: test_fill_template\n');
 end