Commit 13534e0
authored
fix(octave): guard isvalid calls so Octave CI passes (#146)
* fix(octave): guard isvalid in refreshActivePageWidgetsAfterResize_
Octave 7+ has no isvalid() for classdef handles, so the three unguarded
isvalid(w) / isvalid(w.FastSenseObj) calls in DashboardEngine line 2022
and 2045/2048 broke Octave CI (test_engine_preview_nbuckets_reset).
Inline an isOctave flag and short-circuit the check on Octave; behaviour
unchanged on MATLAB.
* fix(octave): guard isvalid in FastSenseWidget.autoScaleY_
Octave 7+ has no isvalid() for classdef handles, so the unguarded
isvalid(obj.FastSenseObj) check in autoScaleY_ broke every test that
renders a FastSenseWidget or calls setYLimitMode (testDetectStaleWithFrozenSensor,
testRefreshTriggers*, test_set_y_limit_mode_*, test_dashboard_preview_envelope).
Inline an isOctave flag and short-circuit on Octave.
* fix(octave): guard isvalid in syncYLimitButtonsState_
Octave 7+ has no isvalid() for classdef handles. Once autoScaleY_ is
fixed, dashboard tests proceed to addYLimitButtons_ which calls
syncYLimitButtonsState_ — the unguarded isvalid(w) on the cached widget
handle would then throw. Inline isOctave and short-circuit on Octave.1 parent c057cbf commit 13534e0
3 files changed
Lines changed: 15 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2016 | 2016 | | |
2017 | 2017 | | |
2018 | 2018 | | |
| 2019 | + | |
2019 | 2020 | | |
2020 | 2021 | | |
2021 | 2022 | | |
2022 | | - | |
| 2023 | + | |
| 2024 | + | |
| 2025 | + | |
2023 | 2026 | | |
2024 | 2027 | | |
2025 | 2028 | | |
| |||
2042 | 2045 | | |
2043 | 2046 | | |
2044 | 2047 | | |
2045 | | - | |
| 2048 | + | |
2046 | 2049 | | |
2047 | 2050 | | |
2048 | | - | |
| 2051 | + | |
2049 | 2052 | | |
2050 | 2053 | | |
2051 | 2054 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1035 | 1035 | | |
1036 | 1036 | | |
1037 | 1037 | | |
1038 | | - | |
| 1038 | + | |
| 1039 | + | |
| 1040 | + | |
| 1041 | + | |
1039 | 1042 | | |
1040 | 1043 | | |
1041 | 1044 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
450 | 450 | | |
451 | 451 | | |
452 | 452 | | |
453 | | - | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
454 | 458 | | |
455 | 459 | | |
456 | 460 | | |
| |||
0 commit comments