feat(companion): inline time-range control (dropdown + Custom date strip)

Replace the separate-window time picker with an in-toolbar uidropdown (six
presets, apply-on-select) plus a 'Custom...' item that reveals an in-window
overlay strip under the toolbar: a Relative (N + unit) tab and an Absolute
(Start/End date pickers) tab with live preview, validation, and Apply/Cancel.
No separate figure/modal is created -- the strip parents to the companion
figure via the dropdown's ancestor. Resolves the rejected modal-window UX
from phase 1041 and adds direct date entry per user request.

- CompanionTimeBar: dropdown + overlay strip; both mode panels overlap in a
  single host cell (fixes a stacked/clipped layout bug); preset/relative/
  absolute commit paths reuse the shared CompanionTimeRange.
- TestCompanionTimeBar: rewritten for the dropdown + strip (12 tests).
- TestFastSenseCompanion: default-label assertion btn.Text -> btn.Value.
- 1041 HUMAN-UAT / MANUAL-VERIFY: updated to the inline design; gap resolved.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: HanSur94

.planning/phases/1041-global-kibana-style-time-range-for-the-companion-with-windowed-sensor-loading/1041-HUMAN-UAT.md

@@ -3,58 +3,75 @@ status: partial
 phase: 1041-global-kibana-style-time-range-for-the-companion-with-windowed-sensor-loading
 source: [1041-VERIFICATION.md, 1041-MANUAL-VERIFY.md]
 started: 2026-06-02
-updated: 2026-06-02
+updated: 2026-06-03
 ---
 
 ## Current Test
 
-[awaiting human testing — deferred by user decision ("finalize now, defer visual"); run the steps below in a live MATLAB session via `/gsd:verify-work 1041`]
+[Design-change gap RESOLVED. The separate-window picker was replaced by an inline
+toolbar control: a preset dropdown (applies instantly) plus a 'Custom…' item that
+reveals an in-window relative/absolute editor strip under the toolbar — no separate
+figure is ever created. User verified the inline control live on 2026-06-03 ("much
+better"), including a follow-up fix to the Custom-strip spacing (overlapping mode
+panels). Remaining deep manual checks (empty-state, live-slide, persistence) are
+covered by automated tests; the visual checklist in 1041-MANUAL-VERIFY.md was
+updated to the inline design and can be re-run as desired.]
 
 ## Tests
 
-### 1. Default range button label + color
-expected: Toolbar range button (left of the gear) reads "Last 7 days" with the inactive WidgetBorderColor background (no Accent — no filter set yet).
-result: [pending]
+### 1. Default range control label + color
+expected: Toolbar range dropdown (col 9, left of the gear) reads "Last 7 days" with the inactive WidgetBorderColor background when no filter is set.
+result: passed
 
-### 2. Picker opens; three tabs; Quick active
-expected: Clicking the button opens a 400x280 "Time Range" popup with Quick/Relative/Absolute tabs; Quick active; six presets listed; "Last 7 days" preset highlighted; Apply hidden in Quick; non-modal.
-result: [pending]
+### 2. Dropdown lists presets + Custom…
+expected: Opening the dropdown shows six presets (24h / 7d / 30d / 90d / 1y / All data) plus a trailing "Custom…" item. No separate window opens.
+result: passed
 
-### 3. One-click quick apply + label update + re-query
-expected: Clicking "Last 30 days" closes the popup immediately, button text → "Last 30 days", background → Accent, and any open dashboard/ad-hoc plot re-queries to the last 30 days.
-result: [pending]
+### 3. Preset applies instantly + label/accent update + re-query
+expected: Selecting a preset (e.g. "Last 30 days") applies immediately; dropdown Value updates, background → Accent, and any open dashboard / ad-hoc plot re-queries.
+result: passed
 
-### 4. Relative builder: live preview + Apply
-expected: Relative tab shows spinner (N) + unit dropdown + live preview label that updates as N/unit change; Apply closes popup and updates the button label (e.g. "Last 14 weeks") and re-queries open views.
-result: [pending]
+### 4. Custom… reveals an inline strip (no separate window)
+expected: Selecting "Custom…" reveals an overlay strip under the toolbar INSIDE the companion window (no 'Time Range' figure; figure count unchanged). Relative/Absolute toggle + Apply/Cancel.
+result: passed
 
-### 5. Absolute tab: validation + valid apply
-expected: Two date pickers; Start > End disables Apply and shows "Invalid: start must be before end" in red; a valid range enables Apply and sets a date-string button label (e.g. "2026-06-02 to 2026-06-04").
-result: [pending]
+### 5. Absolute date entry: pickers + validation + apply
+expected: Absolute tab shows Start/End date pickers; Start ≥ End disables Apply with red "Invalid: start must be before end"; a valid range applies, closes the strip, and sets a date-string label (e.g. "2026-05-27 to 2026-06-03", Accent).
+result: passed
 
-### 6. Empty-state widget for data outside the window
-expected: Opening an ad-hoc plot for a tag whose data does not overlap the active window shows a centered bold "No data in selected range" label (no axes, no crash).
-result: [pending]
+### 6. Relative builder: spinner + unit + apply
+expected: Relative tab shows an N spinner + unit dropdown + live preview; Apply commits e.g. "Last 14 days".
+result: passed
 
-### 7. Relative window slides on live tick; absolute stays fixed
-expected: With a "Last 7 days" relative range and live mode on, the right edge tracks wall-clock "now" each tick with no flicker and the label stays "Last 7 days"; switching to an Absolute window keeps the window fixed across live ticks.
-result: [pending]
+### 7. Empty-state widget for data outside the window
+expected: Opening a tag whose data does not overlap the active window shows a centered "No data in selected range" label (no axes, no crash).
+result: pending
+note: covered by automated out-of-extent getXYRange tests (test_sensor_tag_range); manual visual optional.
 
-### 8. Theme restyle of the range button (and popup)
-expected: Switching theme via Settings restyles the range button (and the popup if open) to the new theme colors.
-result: [pending]
+### 8. Relative window slides on live tick; absolute stays fixed
+expected: With a relative range + live mode, the right edge tracks wall-clock "now" each tick (label unchanged); switching to an Absolute window keeps it fixed.
+result: pending
+note: manual-only (requires live ticks); RangeChanged → setTimeWindow re-query covered by TestFastSenseCompanion.
 
-### 9. Persistence across reopen
-expected: After setting a non-default range and reopening the companion, the button reads the last-used range (Accent) and currentTimeWindow() returns the restored span — loaded from companionPrefs.
-result: [pending]
+### 9. Theme restyle + persistence across reopen
+expected: Switching theme restyles the dropdown (and open strip); reopening the companion restores the last-used range from companionPrefs.
+result: pending
+note: theme restyle covered by TestCompanionTimeBar; persistence by automated companion tests.
 
 ## Summary
 
 total: 9
-passed: 0
+passed: 6
 issues: 0
-pending: 9
+pending: 3
 skipped: 0
-blocked: 0
 
 ## Gaps
+
+- truth: "Time-range selection is integrated into the companion's top toolbar (no separate window)"
+  status: resolved
+  reason: "User: the picker opened a separate modal window via the 'Last 7 days' button; wanted it integrated in the top bar, not a new window. Follow-up: also wanted a date picker / edit field for direct date entry."
+  severity: major
+  test: 2
+  artifacts: [libs/FastSenseCompanion/CompanionTimeBar.m, tests/suite/TestCompanionTimeBar.m, tests/suite/TestFastSenseCompanion.m]
+  resolution: "Reworked CompanionTimeBar from a separate uifigure popup to an inline toolbar uidropdown (six presets, apply-on-select) plus a 'Custom…' item that reveals an in-window overlay strip under the toolbar with a Relative (N + unit) tab and an Absolute (Start/End date pickers) tab, Apply/Cancel. The strip parents to the companion figure (derived via ancestor of the dropdown) — no separate window. Fixed a layout bug where the two mode panels stacked and clipped (now overlap in one host cell). TestCompanionTimeBar rewritten for the dropdown + strip (12/12); TestFastSenseCompanion default-label assertion updated from btn.Text to btn.Value (5/5 range subset). User-verified live 2026-06-03."

.planning/phases/1041-global-kibana-style-time-range-for-the-companion-with-windowed-sensor-loading/1041-MANUAL-VERIFY.md

@@ -1,8 +1,14 @@
 # Manual Verification: Phase 1041 — Global Time Range for FastSenseCompanion
 
-**Purpose:** Verify behaviors that cannot be asserted headlessly — picker visual rendering,
-one-click preset interaction, relative-slide on live ticks, empty-state widget display,
-persistence across sessions, and theme restyle.
+**Purpose:** Verify behaviors that cannot be asserted headlessly — inline control
+rendering, one-click preset interaction, Custom-strip date entry, relative-slide on
+live ticks, empty-state widget display, persistence across sessions, and theme restyle.
+
+> **Design note (2026-06-03):** The original separate-window picker was replaced by an
+> **inline toolbar control** per user request: a preset **dropdown** in toolbar column 9
+> (applies on select) plus a trailing **"Custom…"** item that reveals an **in-window
+> overlay strip** under the toolbar (Relative / Absolute tabs, Apply / Cancel). No
+> separate figure / modal window is ever opened.
 
 **Prerequisites:**
 - Run `install()` once in the MATLAB Command Window to add paths and compile MEX.
@@ -31,75 +37,75 @@ TagRegistry.register('s2', t2);
 c = FastSenseCompanion('Registry', TagRegistry);
 ```
 
-### Step 1 — Default range button label and color
+### Step 1 — Default range control label and color
 
 **Action:** Inspect the companion toolbar after it opens.
 
 **Expected:**
-- The range button (positioned to the left of the gear) reads **"Last 7 days"**.
-- The button background matches the inactive (WidgetBorderColor) toolbar style — same
+- The range **dropdown** (positioned to the left of the gear, toolbar column 9) reads
+  **"Last 7 days"**.
+- The dropdown background matches the inactive (WidgetBorderColor) toolbar style — same
   as the Tile, Wiki, and Events buttons. No Accent highlight (no filter is set yet).
 
 ---
 
-### Step 2 — Picker opens; three tabs visible; Quick tab active
+### Step 2 — Dropdown lists presets + "Custom…" (no separate window)
 
-**Action:** Click the "Last 7 days" toolbar button.
+**Action:** Open the range dropdown.
 
 **Expected:**
-- A 400 × 280 px popup titled **"Time Range"** opens near the companion window.
-- Three tabs are visible in the top strip: **Quick**, **Relative**, **Absolute**.
-- **Quick** tab is active (Accent background on the Quick tab button).
-- The Quick panel shows six preset buttons:
+- The dropdown lists six presets, in order:
   "Last 24 hours", "Last 7 days", "Last 30 days", "Last 90 days", "Last 1 year", "All data".
-- The **"Last 7 days"** preset button is highlighted (Accent background) because it
-  matches the current spec.
-- The Apply button row is **hidden** in Quick mode (Cancel is visible).
-- Clicking anywhere outside the popup does NOT close it (non-modal).
+- A final **"Custom…"** item appears after the presets.
+- The current spec ("Last 7 days") is the selected value.
+- **No popup / separate figure** opens just by viewing the list.
 
 ---
 
-### Step 3 — One-click quick apply + label update + re-query
+### Step 3 — One-click preset apply + label update + re-query
 
-**Action:** With the picker open (from Step 2), click **"Last 30 days"**.
+**Action:** Select **"Last 30 days"** from the dropdown.
 
 **Expected:**
-- Popup **closes immediately** (no separate Apply needed).
-- Toolbar button text changes to **"Last 30 days"**.
-- Toolbar button background changes to the **Accent color** (visual signal that a filter
-  is active — non-default range).
+- The preset applies **immediately** (no separate Apply step).
+- Dropdown value changes to **"Last 30 days"**.
+- Dropdown background changes to the **Accent color** (visual signal that a filter is
+  active — non-default range).
 - Any open dashboard or ad-hoc plot **re-queries** its data to the last 30 days. For a
   disk-backed sensor this is visible as fewer points loading; for an in-RAM tag the line
   updates to the 30-day slice.
 
 ---
 
-### Step 4 — Relative builder tab: live preview + Apply
+### Step 4 — Custom… → Relative builder (live preview + Apply)
 
-**Action:** Click the "Last 30 days" toolbar button to reopen the picker. Click the
-**Relative** tab.
+**Action:** Select **"Custom…"** from the dropdown, then click the **Relative** tab in the
+strip that appears under the toolbar.
 
 **Expected:**
-- The Relative panel becomes visible: a spinner (N), a unit dropdown, "Last … until now" labels.
-- Default values reflect the current spec (N = 30, unit = days).
-- Change the spinner to **14** and the dropdown to **weeks**.
+- An **in-window strip** appears directly under the toolbar (NOT a separate window). The
+  companion figure count does not change.
+- The Relative panel shows a spinner (N), a unit dropdown, and "Last … until now" labels.
+- Change the spinner to **14** and the unit dropdown to **weeks**.
 - A preview label below the controls updates live: it shows a date range
   approximately `YYYY-MM-DD to YYYY-MM-DD` spanning 98 days from today.
 - Click **Apply**.
 
 **After Apply:**
-- Popup closes.
-- Toolbar button reads **"Last 14 weeks"**.
+- The strip closes.
+- The toolbar dropdown reads **"Last 14 weeks"** (shown as a transient leading item).
 - Open views re-query to the 98-day window.
 
 ---
 
-### Step 5 — Absolute tab: validation + Apply
+### Step 5 — Custom… → Absolute date entry: validation + Apply
 
-**Action:** Reopen the picker; click the **Absolute** tab.
+**Action:** Select **"Custom…"** again. The strip opens on the **Absolute** tab by default
+(direct date entry).
 
 **Expected:**
-- Two date pickers (Start, End) with default values (today − 7 days, today).
+- Two date pickers (Start, End) are visible, seeded from the current range (or
+  today − 7 days … today).
 
 **Sub-step A — Validation:**
 - Set the Start date picker to today's date.
@@ -111,7 +117,7 @@ c = FastSenseCompanion('Registry', TagRegistry);
 - Fix the End date to tomorrow's date.
 - Preview label shows **"1 days"** (or "2 days" depending on clock).
 - Apply is enabled; click **Apply**.
-- Popup closes; toolbar button reads a date string e.g. **"2026-06-02 to 2026-06-04"**.
+- The strip closes; the dropdown reads a date string e.g. **"2026-06-02 to 2026-06-04"**.
 - Open views re-query to that fixed window.
 
 ---
@@ -127,41 +133,41 @@ Open an ad-hoc plot for `s1` from the companion Inspector ("Plot" button).
 **Expected:**
 - The spawned plot window shows a **centered bold label**: **"No data in selected range"**
   (14pt bold, muted foreground color, inside the widget panel). No axes, no crash.
-- The toolbar button still shows the active range (Accent color).
+- The toolbar dropdown still shows the active range (Accent color).
 
 ---
 
 ### Step 7 — Relative-window slide on live tick (requires a live-to-today sensor)
 
-**Action:** Ensure the active range is **"Last 7 days"** (click the button, pick the preset
+**Action:** Ensure the active range is **"Last 7 days"** (select the preset in the dropdown
 if needed). Open a live-to-today sensor (e.g., `s2` which spans from 2025 to today).
 Click **Live** to start live mode.
 
 Let at least 3 live ticks elapse (default: 1 second per tick).
 
 **Expected for relative range:**
 - The right edge of the data window slides with wall-clock "now" — new tail samples
-  appear on every tick WITHOUT a popup re-open or full figure rerender flicker.
-- The toolbar button label remains **"Last 7 days"** (it does not add a timestamp or change).
+  appear on every tick WITHOUT a strip re-open or full figure rerender flicker.
+- The toolbar dropdown value remains **"Last 7 days"** (it does not add a timestamp or change).
 
 **Expected for absolute range (regression):**
-- Change the range to an Absolute window (e.g., yesterday to today). Live ticks
+- Change the range to an Absolute window (via Custom… → Absolute). Live ticks
   continue but the window is **fixed** — the left edge does NOT slide.
 
 ---
 
-### Step 8 — Theme restyle of the range button and popup
+### Step 8 — Theme restyle of the range control (and open strip)
 
-**Action:** With the picker popup closed, open the companion Settings dialog (gear button).
+**Action:** With the Custom strip closed, open the companion Settings dialog (gear button).
 Switch the theme (e.g., from dark to light). Close the settings dialog.
 
 **Expected:**
-- The range button restyles to the new theme (FontColor + BackgroundColor match the new
-  theme's ToolbarFontColor / WidgetBorderColor or Accent as appropriate).
+- The range dropdown restyles to the new theme (FontColor + BackgroundColor match the new
+  theme's foreground / WidgetBorderColor or Accent as appropriate).
 
-**Bonus (if popup is open):**
-- Reopen the picker popup; switch the theme while it is visible. The popup's background
-  and control colors update to the new theme.
+**Bonus (if the strip is open):**
+- Open Custom… so the strip is visible; switch the theme while it is open. The strip's
+  background and control colors update to the new theme; the active tab keeps its Accent.
 
 ---
 
@@ -173,7 +179,7 @@ Switch the theme (e.g., from dark to light). Close the settings dialog.
 3. Reopen: `c2 = FastSenseCompanion('Registry', TagRegistry);`.
 
 **Expected:**
-- The toolbar button on the new companion reads **"Last 30 days"** (Accent color).
+- The toolbar dropdown on the new companion reads **"Last 30 days"** (Accent color).
 - `c2.currentTimeWindow()` returns a `[t0, t1]` span of ~30 days.
 - The restored range is loaded from `companionPrefs` automatically.
 
@@ -183,15 +189,15 @@ Switch the theme (e.g., from dark to light). Close the settings dialog.
 
 | Step | Description | Result | Notes |
 |------|-------------|--------|-------|
-| 1 | Default label "Last 7 days" + WidgetBorderColor background | ⬜ | |
-| 2 | Picker 400x280, 3 tabs, Quick active, presets listed, Cancel visible | ⬜ | |
-| 3 | One-click "Last 30 days" closes popup + Accent + re-query | ⬜ | |
-| 4 | Relative tab: live preview updates; Apply closes + updates label | ⬜ | |
-| 5A | Absolute: start > end → Apply disabled + red error text | ⬜ | |
-| 5B | Absolute: valid range → Apply + date-string label | ⬜ | |
+| 1 | Default dropdown value "Last 7 days" + WidgetBorderColor background | ⬜ | |
+| 2 | Dropdown lists 6 presets + "Custom…"; no separate window | ⬜ | |
+| 3 | Selecting "Last 30 days" applies instantly + Accent + re-query | ⬜ | |
+| 4 | Custom… → Relative: live preview; Apply closes strip + updates value | ⬜ | |
+| 5A | Custom… → Absolute: start > end → Apply disabled + red error text | ⬜ | |
+| 5B | Custom… → Absolute: valid range → Apply + date-string value | ⬜ | |
 | 6 | Empty-state "No data in selected range" for out-of-window sensor | ⬜ | |
 | 7 | Relative window slides on live tick; Absolute stays fixed | ⬜ | |
-| 8 | Theme switch restyles button (and popup if open) | ⬜ | |
+| 8 | Theme switch restyles dropdown (and open strip) | ⬜ | |
 | 9 | Persistence: reopen companion restores last-used range | ⬜ | |
 
 **Tester:** ______________________
@@ -205,5 +211,5 @@ Switch the theme (e.g., from dark to light). Close the settings dialog.
 ---
 
 *This checklist covers the two manual-only validation targets from `1041-VALIDATION.md`:*
-*1. CompanionTimeBar picker visuals + popup interaction (presets / relative / absolute)*
+*1. CompanionTimeBar inline control visuals + interaction (dropdown presets / Custom relative / Custom absolute)*
 *2. Relative-window slide on live tick*