Commit c4c8969
Bug-find session 260526: info-icon survival + 1000-pt preview cap (#163)
* feat(quick-260526-pqz-01): raise preview line cap per signal from 400 -> 1000
- DashboardEngine.computePreviewEnvelopeReturning_: change min(400, ...) -> min(1000, ...) so wide windows (>=2000 px) drive proportionally more preview detail in the bottom slider strip.
- Update doc-comment on computePreviewEnvelope and inline comment in computePreviewEnvelopeReturning_ to report new range [50, 1000].
- Update consistency comment in tests/test_dashboard_preview_overlay.m (no assertion change — the test only asserts numel(xd) >= 4).
- Intentionally NOT adding cache invalidation: PreviewNBuckets_ is cached on DashboardEngine, so a running demo must restart (or trigger the existing resize-invalidation at line 2241) to pick up the new cap.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* docs(quick-260526-pqz): complete raise preview line cap quick task
- Add PLAN.md and SUMMARY.md for quick task 260526-pqz.
- Update STATE.md "Quick Tasks Completed" table with new row.
Task delivered: raised per-signal slider-preview cap from 400 -> 1000 buckets in DashboardEngine.computePreviewEnvelopeReturning_. Static analysis clean (mh_lint + mh_style); MATLAB tests pass (envelope 7/7, overlay 10/10); Octave runs as expected (preview_envelope 2/2 with pre-existing skips; preview_overlay skipped — pre-existing TimeRangeSelector guard).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(dashboard): preserve i icon after PlantLog L toggle cycle
addPlantLogToggle hardcoded xPL for a 3-button right cluster, but
the FastSenseWidget chrome carries a 4-button cluster. Without a
reflowChrome_ pass after L rebuild, the recreated L button landed
on top of InfoIconButton, visually swallowing the i icon after
every toggle. The initial render was rescued by the reflowChrome_
at the end of realizeWidget; callback-driven rebuilds were not.
Fix: call DashboardLayout.reflowChrome_ at the end of
addPlantLogToggle (wrapped in try/catch so a reflow failure can
never break the toggle itself).
Adds regression tests covering one and multiple toggle cycles.
Fixes two pre-existing stale tests that pinned the 3-button-cluster
layout.
Closes debug session: .planning/debug/260526-info-icon-vanishes-after-plantlog-toggle.md
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent e0d2dff commit c4c8969
8 files changed
Lines changed: 572 additions & 22 deletions
File tree
- .planning
- quick/260526-pqz-raise-preview-line-cap-per-signal-from-4
- libs/Dashboard
- tests
- suite
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
| 92 | + | |
92 | 93 | | |
93 | 94 | | |
94 | 95 | | |
| |||
0 commit comments