style: fix 6 mh_style violations (CI lint green)#141
Merged
Conversation
CI lint job revealed 6 style issues in mh_style libs/ tests/ examples/: - DashboardEngine.m:80 165-char comment (pre-existing 260513-q7w fu2) - DashboardToolbar.m:316 && continuation (pre-existing) - FastSenseWidget.m:454 && continuation (pre-existing) - TestClearPanelHelper_.m:1 class naming scheme violation (PR scope) - test_event_pick_mode.m:411 && continuation (PR scope) - test_event_pick_mode.m:418 && continuation (PR scope) Resolutions: - Wrap the 165-char comment as a 3-line block above the property. - Replace `...\n && expr` with `&& ...\n expr` (operator at end of previous line per MISS_HIT operator_after_continuation rule). - Rename TestClearPanelHelper_ -> TestClearPanelHelper (file + class declaration + 2 callsites in tests/test_create_event_dialog.m). After fixes: `mh_style libs/ tests/ examples/` reports "465 file(s) analysed, everything seems fine". Drive-by fixes for the 3 pre-existing issues are included because the CI job lints the whole tree on every push — without them, this PR's lint stays red regardless of my own files being clean. 12/12 test_event_pick_mode + 9/9 test_create_event_dialog still PASS. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'FastSense Performance'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.
| Benchmark suite | Current: 3391e5d | Previous: 0613d40 | Ratio |
|---|---|---|---|
Instantiation mean std(1M) |
0.916 ms |
0.703 ms |
1.30 |
Zoom cycle mean (1M) |
16.5 ms |
14.869 ms |
1.11 |
Instantiation mean std(5M) |
1.6 ms |
0.479 ms |
3.34 |
Zoom cycle mean (5M) |
17.247 ms |
14.874 ms |
1.16 |
Downsample mean std10M) |
0.11 ms |
0.045 ms |
2.44 |
Instantiation mean std10M) |
1.358 ms |
0.773 ms |
1.76 |
Render mean std10M) |
5.64 ms |
1.336 ms |
4.22 |
Zoom cycle mean (10M) |
16.831 ms |
15.265 ms |
1.10 |
Zoom cycle mean std10M) |
0.785 ms |
0.662 ms |
1.19 |
Downsample mean std50M) |
0.214 ms |
0.121 ms |
1.77 |
Render mean std50M) |
3.267 ms |
0.965 ms |
3.39 |
Zoom cycle mean (50M) |
17.482 ms |
14.92 ms |
1.17 |
Zoom cycle mean (100M) |
17.666 ms |
14.86 ms |
1.19 |
Downsample mean ( std00M) |
4.098 ms |
0.415 ms |
9.87 |
Instantiation mean ( std00M) |
302.448 ms |
157.602 ms |
1.92 |
Render mean (500M) |
360.967 ms |
302.487 ms |
1.19 |
Render mean ( std00M) |
61.867 ms |
1.217 ms |
50.84 |
Zoom cycle mean (500M) |
17.472 ms |
15.87 ms |
1.10 |
Dashboard live tick stdmean |
2.581 ms |
1.52 ms |
1.70 |
Dashboard page switch stdmean |
1.032 ms |
0.351 ms |
2.94 |
Dashboard broadcastTimeRange mean |
0.089 ms |
0.06 ms |
1.48 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @HanSur94
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the MATLAB Lint CI job to green by fixing all 6
mh_styleviolations acrosslibs/ tests/ examples/:libs/Dashboard/DashboardEngine.m:80— 165-char comment line (pre-existing 260513-q7w fu2)libs/Dashboard/DashboardToolbar.m:316—&&at start of continuation (pre-existing)libs/Dashboard/FastSenseWidget.m:454—&&at start of continuation (pre-existing)tests/TestClearPanelHelper_.m— trailing-underscore class-name naming violation (introduced by Create events from a dashboard: "+" button + two-click pick UX + shaded region #139)tests/test_event_pick_mode.m:411—&&continuation (introduced by Create events from a dashboard: "+" button + two-click pick UX + shaded region #139)tests/test_event_pick_mode.m:418—&&continuation (introduced by Create events from a dashboard: "+" button + two-click pick UX + shaded region #139)After fixes:
mh_style libs/ tests/ examples/reports465 file(s) analysed, everything seems fine.Why bundled
The 3 pre-existing issues were already failing CI on main before #139 merged. Without fixing them, the lint job stays red even after my own 3 are fixed, since CI runs
mh_styleon the whole tree on every push. Drive-by fix in scope.Resolutions
...\n && expr→&& ...\n expr(operator at end of previous line; MISS_HIToperator_after_continuationrule).TestClearPanelHelper_→TestClearPanelHelper(renamed file + class declaration + 2 callsites intests/test_create_event_dialog.m).Test plan
mh_style libs/ tests/ examples/clean (verified locally)test_create_event_dialog.mstill passes 9/9 after renametest_event_pick_mode.mstill passes 12/12 after continuation fixesNote: the MATLAB Tests / Octave failures currently showing on main (TestCompanionEventViewer / TimeRangeSelector buildGraphics_) are pre-existing since 2026-05-13 18:06 and not addressed here — separate issue.
🤖 Generated with Claude Code