Rename dashboard toolbar Reset button to Redraw (260602-p2t)#187
Merged
Conversation
The top-bar button labelled 'Reset' actually forces a full re-render of every widget on the active page (onReset -> DashboardEngine.rerenderWidgets), not a reset. Rename the user-facing label to 'Redraw' so its purpose is clear; the tooltip already described the re-render behaviour. Internal handle/handler (hResetBtn/onReset) keep their historical names. The time-panel 'Reset' button (resetTimeRange) is a genuine reset and is left unchanged. Updates test_dashboard_toolbar_buttons label assertion + button-names list. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Quick-task artifacts (PLAN/SUMMARY) + STATE.md tracking row for the toolbar 'Reset' -> 'Redraw' label rename. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Renames the dashboard top-bar (toolbar) button from "Reset" → "Redraw" so the label matches what it actually does.
Why
The toolbar button labelled "Reset" doesn't reset anything — its callback
onReset()callsDashboardEngine.rerenderWidgets(), which tears down and re-renders every widget on the active page (a manual recovery action). The tooltip already said "Force re-render of all widgets on the active page…", so "Redraw" matches both the behaviour and the existing tooltip.Scope — two different "Reset" buttons
There are two buttons named "Reset"; only the top-bar one is renamed:
DashboardToolbar.m) → re-renders widgets → renamed to "Redraw" ✅DashboardEngine.hTimeResetBtn→resetTimeRange) → restores the time window to the full data range. That's a genuine reset and isn't in the top bar — left unchanged ❌Changes
libs/Dashboard/DashboardToolbar.m— button label'Reset'→'Redraw'+ updated adjacent comment. Tooltip unchanged (already accurate). Internal handle/handlerhResetBtn/onResetkept as-is (not user-facing).tests/test_dashboard_toolbar_buttons.m— synced the label assertion and button-names list to expect'Redraw'.Verification
test_dashboard_toolbar_buttons→ 7/7 pass (label, tooltip-mentions-"widget", and theonResetre-render behaviour test).🤖 Generated with Claude Code