feat(dashboard): add GroupWidget container with panel/collapsible/tabbed modes#33
Merged
Conversation
13-task TDD plan covering: GroupWidget scaffold, panel/collapsible/tabbed modes, theme integration, serialization, engine/serializer/layout integration, web bridge export, and example script. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…agement Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Move ExpandedHeight/ParentGroup to SetAccess=protected - Error on invalid removeChild index instead of silent no-op - Add toStruct stub to prevent broken serialization - Use sentinel idiom for default Position override Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add GroupHeaderBg, GroupHeaderFg, GroupBorderColor, TabActiveBg, and TabInactiveBg to DashboardTheme for all presets (dark, light, industrial, scientific, ocean, default), with shared fallback defaults. Add testThemeHasGroupFields to TestGroupWidget to verify presence across all presets. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace collapse/expand stubs with real implementations that save/restore the expanded height and toggle child panel visibility. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace renderTabbedChildren and switchTab stubs with real implementations. Tab buttons are placed in the header, content panels toggle visibility on tab switch, and button backgrounds update to reflect active/inactive state. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Verify that one level of nesting (depth=2) succeeds and that attempting to nest three levels deep throws GroupWidget:maxDepth. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ruct) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add struct-array normalization in fromStruct for JSON round-trip (jsondecode converts cell arrays to struct arrays) - Force header panel in tabbed mode even with empty Label (tab buttons need a parent panel) - Document reflow() TODO in collapse/expand (requires engine wiring) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'FastSense Performance'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.
| Benchmark suite | Current: b4816da | Previous: 2df32a9 | Ratio |
|---|---|---|---|
Downsample mean (1M) |
4.142 ms |
2.095 ms |
1.98 |
Downsample mean std(1M) |
0.097 ms |
0.069 ms |
1.41 |
Downsample mean (5M) |
20.758 ms |
9.935 ms |
2.09 |
Downsample mean (10M) |
42.632 ms |
19.713 ms |
2.16 |
Downsample mean std10M) |
0.84 ms |
0.087 ms |
9.66 |
Instantiation mean std10M) |
2.416 ms |
0.376 ms |
6.43 |
Downsample mean (50M) |
213.479 ms |
97.95 ms |
2.18 |
Downsample mean std50M) |
2.909 ms |
0.221 ms |
13.16 |
Render mean std50M) |
1.532 ms |
0.405 ms |
3.78 |
Downsample mean (100M) |
421.531 ms |
196.073 ms |
2.15 |
Downsample mean ( std00M) |
3.554 ms |
1.567 ms |
2.27 |
Render mean ( std00M) |
3.855 ms |
2.483 ms |
1.55 |
Downsample mean (500M) |
2132.945 ms |
986.499 ms |
2.16 |
Downsample mean ( std00M) |
17.372 ms |
1.567 ms |
11.09 |
Instantiation mean ( std00M) |
346.466 ms |
188.372 ms |
1.84 |
Render mean ( std00M) |
49.673 ms |
2.483 ms |
20.01 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @HanSur94
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GroupWidgetclass extendingDashboardWidget— container that organizes child widgets into titled panels, collapsible sections, or tabbed viewspanel(always visible),collapsible(expand/collapse with position tracking),tabbed(tab switching with per-tab child sets)addWidget('group', ...)), DashboardSerializer (JSON round-trip withcreateWidgetFromStructrefactor), DashboardLayout (reflow()method), DashboardTheme (5 new group fields across all 6 presets), web bridge (JS rendering + CSS)Known follow-ups
collapse()/expand()updatePosition(4)but don't trigger grid reflow yet (needs engine-level LayoutRef wiring)exportScriptdoesn't emitaddChildcalls for group childrenTest plan
TestGroupWidget.min MATLAB — all tests passTestDashboardEngine.m— no regressionsTestDashboardSerializer.m— no regressionsexample_dashboard_groups.m— renders 3 groups (panel, collapsible, tabbed)🤖 Generated with Claude Code