fix(examples): restore addThreshold continuation lines + re-migrate#51
Merged
Conversation
…hold calls - Sensor() -> SensorTag() constructor calls across all 41 example files - StateChannel() -> StateTag() with 'X'/'Y' constructor args - SensorRegistry -> TagRegistry (register/get/list/printTable/viewer/unregister) - fp.addSensor() -> fp.addTag() for FastSense plot bindings - Removed legacy Threshold() OOP constructor + addCondition + s.addThreshold(tVar) - Removed s.addStateChannel() / s.resolve() calls (not on SensorTag API) - Preserved all fp.addThreshold(value, ...) visual threshold lines untouched - Updated stress_test helper functions to use getXY()/updateData() Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
These files only use FastSense.addLine/addThreshold (no Sensor API). The Phase 1011 migration agent incorrectly stripped their addThreshold continuation lines. Restored verbatim from origin/main. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FastSense.addLine/addThreshold(no Sensor API) — these were incorrectly damaged by the Phase 1011 migration agentaddThresholdcontinuation linesRoot cause: Phase 1011 Plan 04 migration agent pattern-matched "Threshold" in
fp.addThreshold()method calls and stripped their multi-line continuation arguments.addThresholdis a surviving FastSense method for visual threshold lines — it should never have been touched.Test plan
fp.addThreshold(...)continuation lines verified intact (47 across all files)Sensor(constructor calls remain in examplesSensorRegistry/ThresholdRegistryfully replaced withTagRegistry🤖 Generated with Claude Code