Complete PR #20: Fix async/await cleanup + CI pipeline fixes#31
Closed
remyluslosius wants to merge 5 commits into
Closed
Complete PR #20: Fix async/await cleanup + CI pipeline fixes#31remyluslosius wants to merge 5 commits into
remyluslosius wants to merge 5 commits into
Conversation
- Fixed 62 SonarCloud code smell issues where functions were marked async but didn't use any async features - Removed async keyword from functions that perform only synchronous operations - Updated corresponding await calls to regular function calls - Improves code clarity and prevents confusion about function behavior This addresses SonarCloud's 'Use asynchronous features in this function or remove the async keyword' warnings
- Fix backend dependency installation path in CI workflow - Fix code quality workflow to find requirements.txt at root - Add test workflow to verify CI fixes - Update .gitignore to allow .github directory - Document all CI pipeline issues and resolutions
- Fix YAML formatting issues (trailing spaces, line lengths) - Add document start marker (---) - Fix truthy warning with inline comment - Ensure proper spacing and indentation - Add newline at end of file This resolves yamllint warnings to ensure clean CI execution.
- Format all Python files in backend/app/ with Black - Ensures consistent code style across the codebase - Resolves formatting issues that were blocking CI This prepares the code for successful CI pipeline execution.
- cryptography: 41.0.7 → 44.0.1 (security fix for OpenSSL vulnerabilities) - aiohttp: 3.9.1 → 3.12.14 (multiple security fixes) - python-multipart: 0.0.6 → 0.0.18 (security and stability fixes) These updates address 15 security vulnerabilities identified by GitHub's security alerts. All updates are backwards compatible and tested. Consolidates security fixes from PRs #19, #24, #25.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the async/await cleanup from PR #20 and includes critical CI pipeline fixes:
🔧 CI Pipeline Fixes
🎨 Code Quality Improvements
🧪 Testing Improvements
Impact
Testing
This is a foundational fix that unblocks PR completion workflow.
Related PRs