chore(reports): drop stale 'not part of this MVP' copy#656
Merged
Conversation
Signing, PDF/CSV/OSCAL faces, and the Framework Attestation kind have all shipped, so several MVP-era 'not built yet' claims are now false: - ExecutiveBody footer: drop 'Signing, PDF, and OSCAL export are not part of this MVP' (keep the still-true 'figures reflect the last successful scan' line). OSCAL was never an executive face anyway. - Templates 'coming soon' copy (user-facing): it claimed attestation, PDF, OSCAL, and signing 'are not built yet' - all live now. Reword: the report kinds + signed faces are live in the Library; only the custom-template gallery builder is deferred. - Scheduled 'coming soon' copy: drop 'and signing' (signing is built); only the dispatcher is missing. - File header comment + frontend-reports spec description/objective/excludes: align with reality (two kinds, kind-aware body, signed PDF/CSV/OSCAL/JSON faces; only the template-gallery builder and the scheduler remain deferred). The stale prose had contradicted the spec's own C-06/C-07/ C-10/C-13 constraints. No behavior change; vitest 12/12, specter 112 specs + 100% structural.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Several MVP-era "not built yet" claims in the Reports page are now factually false — signing, the PDF/CSV/OSCAL faces, and the Framework Attestation kind have all shipped. The in-app
ExecutiveBodyfooter literally said "Signing, PDF, and OSCAL export are not part of this MVP."Changes (no behavior change, copy + spec prose only)
ExecutiveBodyfooter: drop the false disclaimer; keep the still-true "figures reflect the last successful scan per host" line.frontend-reportsspec description/objective/excludes: aligned with reality (two kinds, kind-aware body, signed PDF/CSV/OSCAL/JSON faces). The stale prose had contradicted the spec's own C-06/C-07/C-10/C-13 constraints.Validation