Skip to content

Commit 358995f

Browse files
committed
little code correction
1 parent e7c6850 commit 358995f

3 files changed

Lines changed: 21 additions & 19 deletions

File tree

files/lib/acp/form/FaqCategoryAddForm.class.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@ protected function createForm()
3939
#[Override]
4040
protected function finalizeForm()
4141
{
42+
parent::finalizeForm();
43+
4244
$this->form->getDataHandler()->addProcessor(
4345
new CustomFormDataProcessor(
4446
'icon',
@@ -57,7 +59,5 @@ function (IFormDocument $document, array $data, IStorableObject $object) {
5759
}
5860
)
5961
);
60-
61-
parent::finalizeForm();
6262
}
6363
}

files/lib/acp/form/FaqQuestionAddForm.class.php

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,6 @@ class FaqQuestionAddForm extends AbstractFormBuilderForm
3535
*/
3636
public $activeMenuItem = 'wcf.acp.menu.link.faq.questions.add';
3737

38-
/**
39-
* @inheritDoc
40-
*/
41-
public $formAction = 'create';
42-
4338
/**
4439
* @inheritDoc
4540
*/
@@ -191,9 +186,9 @@ protected function createForm()
191186
}
192187

193188
#[Override]
194-
public function buildForm()
189+
public function finalizeForm()
195190
{
196-
parent::buildForm();
191+
parent::finalizeForm();
197192

198193
$this->form->getDataHandler()->addProcessor(new CustomFormDataProcessor(
199194
'answer_i18n',

files/lib/acp/form/FaqQuestionEditForm.class.php

Lines changed: 17 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -40,18 +40,25 @@ public function readParameters()
4040
if (!$this->formObject->questionID) {
4141
throw new IllegalLinkException();
4242
}
43-
if ($this->formObject->isMultilingual) {
44-
$this->isMultilingual = 1;
45-
46-
$languageItemList = new LanguageItemList();
47-
$languageItemList->getConditionBuilder()->add('languageItem = ?', [$this->formObject->answer]);
48-
$languageItemList->readObjects();
49-
foreach ($languageItemList as $languageItem) {
50-
$this->multiLingualAnswers[$languageItem->languageID] = $languageItem->languageItemValue;
51-
}
52-
}
5343
} catch (MappingError) {
5444
throw new IllegalLinkException();
5545
}
5646
}
47+
48+
#[Override]
49+
public function readData()
50+
{
51+
parent::readData();
52+
53+
if ($this->formObject->isMultilingual) {
54+
$this->isMultilingual = 1;
55+
56+
$languageItemList = new LanguageItemList();
57+
$languageItemList->getConditionBuilder()->add('languageItem = ?', [$this->formObject->answer]);
58+
$languageItemList->readObjects();
59+
foreach ($languageItemList as $languageItem) {
60+
$this->multiLingualAnswers[$languageItem->languageID] = $languageItem->languageItemValue;
61+
}
62+
}
63+
}
5764
}

0 commit comments

Comments
 (0)