use correct scope

Author: Hanashi

files/lib/data/faq/Question.class.php

@@ -39,7 +39,7 @@ final class Question extends DatabaseObject implements IRouteController, ISearch
      */
     protected static $databaseTableIndexName = 'questionID';
 
-    protected GroupedAttachmentList $attachmentList;
+    private GroupedAttachmentList $attachmentList;
 
     #[Override]
     public function getTitle(): string

files/lib/data/faq/QuestionAction.class.php

@@ -188,7 +188,7 @@ public function update()
         }
     }
 
-    protected function updateSearchIndex($object)
+    private function updateSearchIndex($object)
     {
         if (isset($this->parameters['answer_i18n'])) {
             foreach ($this->parameters['answer_i18n'] as $languageID => $answer) {

files/lib/data/faq/QuestionList.class.php

@@ -19,7 +19,7 @@ final class QuestionList extends DatabaseObjectList
      */
     public $sqlOrderBy = 'showOrder, questionID';
 
-    protected GroupedAttachmentList $attachmentList;
+    private GroupedAttachmentList $attachmentList;
 
     public function readAttachments()
     {

files/lib/data/faq/category/FaqCategory.class.php

@@ -25,7 +25,7 @@ final class FaqCategory extends AbstractDecoratedCategory implements IAccessible
 {
     public const OBJECT_TYPE_NAME = 'dev.tkirch.wsc.faq.category';
 
-    protected array $userPermissions = [];
+    private array $userPermissions = [];
 
     private bool $prefix = false;
 

files/lib/data/faq/category/FaqCategoryCache.class.php

@@ -12,9 +12,9 @@ final class FaqCategoryCache extends SingletonFactory
      * number of total questions
      * @var int[]
      */
-    protected array $questions;
+    private array $questions;
 
-    protected function initQuestions()
+    private function initQuestions()
     {
         $this->questions = [];
 
@@ -38,7 +38,7 @@ protected function initQuestions()
         $this->countQuestions($categoryToParent, $contacts, 0);
     }
 
-    protected function countQuestions(array $categoryToParent, array &$contacts, $categoryID)
+    private function countQuestions(array $categoryToParent, array &$contacts, $categoryID)
     {
         $count = (isset($contacts[$categoryID])) ? $contacts[$categoryID] : 0;
         if (isset($categoryToParent[$categoryID])) {

files/lib/data/faq/category/FaqCategoryNode.class.php

@@ -16,7 +16,7 @@ final class FaqCategoryNode extends CategoryNode
      */
     protected static $baseClass = FaqCategory::class;
 
-    protected int $questions;
+    private int $questions;
 
     #[Override]
     public function getItems(): int

files/lib/page/FaqQuestionListPage.class.php

@@ -19,9 +19,9 @@ class FaqQuestionListPage extends AbstractPage
      */
     public $neededPermissions = ['user.faq.canViewFAQ'];
 
-    public int $showFaqAddDialog = 0;
+    protected int $showFaqAddDialog = 0;
 
-    public ?FaqCategory $category;
+    protected ?FaqCategory $category;
 
     #[Override]
     public function readParameters()

files/lib/page/FaqQuestionPage.class.php

@@ -20,7 +20,7 @@ class FaqQuestionPage extends AbstractPage
 
     protected Question $question;
 
-    public ?FaqCategory $category;
+    protected ?FaqCategory $category;
 
     #[Override]
     public function readParameters()

files/lib/system/search/FaqQuestionSearch.class.php

@@ -9,7 +9,7 @@
 
 final class FaqQuestionSearch extends AbstractSearchProvider
 {
-    protected array $faqCache = [];
+    private array $faqCache = [];
 
     #[Override]
     public function cacheObjects(array $objectIDs, ?array $additionalData = null): void