Humanizer Truncate should always be used as "Humanizer.Truncate" (#132)

Author: StefH

src/Handlebars.Net.Helpers.Core/Attributes/HandlebarsWriterAttribute.cs

@@ -1,5 +1,4 @@
-using System;
-using HandlebarsDotNet.Helpers.Enums;
+using HandlebarsDotNet.Helpers.Enums;
 
 namespace HandlebarsDotNet.Helpers.Attributes;
 

src/Handlebars.Net.Helpers.Core/Options/HandlebarsHelpersOptions.cs

@@ -10,7 +10,7 @@ namespace HandlebarsDotNet.Helpers.Options;
 /// </summary>
 public class HandlebarsHelpersOptions
 {
-    private const string Dot = ".";
+    public const string Dot = ".";
 
     /// <summary>
     /// An array of the default allowed HandlebarsHelpers.

src/Handlebars.Net.Helpers.Humanizer/Helpers/HumanizerHelpers.cs

@@ -133,17 +133,12 @@ public string Titleize(string value)
     [HandlebarsWriter(WriterType.String)]
     public string ToMetric(object value)
     {
-        switch (value)
+        return value switch
         {
-            case int intValue:
-                return intValue.ToMetric();
-
-            case double doubleValue:
-                return doubleValue.ToMetric();
-
-            default:
-                throw new NotSupportedException($"The value '{value}' must be an int or double.");
-        }
+            int intValue => intValue.ToMetric(),
+            double doubleValue => doubleValue.ToMetric(),
+            _ => throw new NotSupportedException($"The value '{value}' must be an int or double.")
+        };
     }
 
     [HandlebarsWriter(WriterType.String)]
@@ -218,7 +213,7 @@ public string Transform(string value, string? transformer)
         return value.Transform(MapToStringTransformer(transformer));
     }
 
-    [HandlebarsWriter(WriterType.String)]
+    [HandlebarsWriter(WriterType.String, $"{nameof(Humanizer)}.{nameof(Truncate)}")]
     public string Truncate(string value, int length, string? separator = null, string? truncator = null, string? truncateFrom = null)
     {
         if (string.IsNullOrWhiteSpace(separator))

src/Handlebars.Net.Helpers/HandlebarsHelpers.cs

@@ -184,7 +184,7 @@ private static void RegisterEvaluateHelper(IHandlebars handlebarsContext)
 
     private static void RegisterCustomHelper(IHandlebars handlebarsContext, HandlebarsHelpersOptions options, string categoryPrefix, IHelpers helper)
     {
-        Type helperClassType = helper.GetType();
+        var helperClassType = helper.GetType();
 
         var methods = helperClassType.GetMethods()
             .Select(methodInfo => new
@@ -220,15 +220,16 @@ private static void RegisterCustomHelper(IHandlebars handlebarsContext, Handleba
     private static string GetName(MethodInfo methodInfo, HandlebarsWriterAttribute attribute, HandlebarsHelpersOptions options, string categoryPrefix)
     {
         var names = new List<string>();
-        if (attribute.Name is { } && !string.IsNullOrWhiteSpace(attribute.Name))
+        if (!string.IsNullOrWhiteSpace(attribute.Name))
         {
-            names.Add(attribute.Name);
+            var modifiedName = attribute.Name!.Replace(HandlebarsHelpersOptions.Dot, options.PrefixSeparator);
+            names.Add(modifiedName);
         }
         else
         {
-            if (options.Prefix is { } && !string.IsNullOrWhiteSpace(options.Prefix))
+            if (!string.IsNullOrWhiteSpace(options.Prefix))
             {
-                names.Add(options.Prefix);
+                names.Add(options.Prefix!);
             }
 
             if (options.UseCategoryPrefix)
@@ -333,7 +334,7 @@ IHelperOptions options
             parameterCountRequired--;
         }
 
-        if (model is { })
+        if (model != null)
         {
             numberOfArguments += 1;
         }
@@ -374,7 +375,7 @@ IHelperOptions options
         var parsedArguments = ArgumentsParser.Parse(context, methodInfo.GetParameters(), arguments);
 
         // Add null for optional arguments
-        for (int i = 0; i < parameterCountAllowed.Max() - numberOfArguments; i++)
+        for (var i = 0; i < parameterCountAllowed.Max() - numberOfArguments; i++)
         {
             parsedArguments.Add(null);
         }
@@ -384,7 +385,7 @@ IHelperOptions options
             parsedArguments.Insert(0, true);
         }
 
-        if (model is { })
+        if (model != null)
         {
             parsedArguments.Insert(0, model);
         }
@@ -416,6 +417,6 @@ IHelperOptions options
     /// </summary>
     private static string[] CreateHelperNames(string helperName)
     {
-        return new[] { helperName, $"[{helperName}]" };
+        return [helperName, $"[{helperName}]"];
     }
 }

test/Handlebars.Net.Helpers.Tests/Templates/HumanizerHelpersTemplateTests.cs

@@ -45,6 +45,8 @@ public void HumanizeDateTime()
         result.Should().Be("yesterday");
     }
 
+    
+
     [Theory]
     [InlineData("{{[Humanizer.Humanize] \"HTML\"}}", "HTML")]
     [InlineData("{{[Humanizer.Humanize] \"PascalCaseInputStringIsTurnedIntoSentence\"}}", "Pascal case input string is turned into sentence")]
@@ -59,4 +61,41 @@ public void HumanizeString(string template, string expected)
         // Assert
         result.Should().Be(expected);
     }
+
+    [Theory]
+    [InlineData("{{[Humanizer.Truncate] \"This is a long sentence that needs truncating.\" 10}}", "This is a…")]
+    [InlineData("{{[Humanizer.Truncate] \"Short sentence.\" 20}}", "Short sentence.")]
+    [InlineData("{{[Humanizer.Truncate] \"Exact length.\" 13}}", "Exact length.")]
+    [InlineData("{{[Humanizer.Truncate] \"This sentence will be truncated to zero.\" 0}}", "")]
+    [InlineData("{{[Humanizer.Truncate] \"This is a test for truncating with custom ellipsis.\" 15 \"[...]\"}}", "This is a [...]")]
+    public void HumanizeTruncate(string template, string expected)
+    {
+        // Arrange
+        var action = _handlebarsContext.Compile(template);
+
+        // Act
+        var result = action("");
+
+        // Assert
+        result.Should().Be(expected);
+    }
+
+    [Fact]
+    public void HumanizeTruncateWithCategoryPrefix()
+    {
+        // Arrange
+        var handlebarsContext = Handlebars.Create();
+        HandlebarsHelpers.Register(handlebarsContext, o =>
+        {
+            o.PrefixSeparator = "_";
+        });
+        var template = "{{[Humanizer_Truncate] \"This is a long sentence that needs truncating.\" 10}}";
+        var action = handlebarsContext.Compile(template);
+
+        // Act
+        var result = action("");
+
+        // Assert
+        result.Should().Be("This is a…");
+    }
 }

test/Handlebars.Net.Helpers.Tests/Templates/StringHelpersTemplateTests.cs

@@ -3,6 +3,7 @@
 using System.Globalization;
 using FluentAssertions;
 using HandlebarsDotNet.Compiler;
+using HandlebarsDotNet.Helpers.Enums;
 using HandlebarsDotNet.Helpers.Models;
 using HandlebarsDotNet.Helpers.Utils;
 using Moq;
@@ -538,6 +539,24 @@ public void ToWrappedString_Null()
         decoded.Should().Be("test  abc");
     }
 
+    [Fact]
+    public void Truncate()
+    {
+        // Arrange
+        var handlebarsContext = Handlebars.Create();
+        HandlebarsHelpers.Register(handlebarsContext, o =>
+        {
+            o.UseCategoryPrefix = false;
+            o.Categories = [Category.String, Category.Humanizer];
+        });
+        var action = handlebarsContext.Compile("{{Truncate \"This is a long sentence that needs truncating.\" 10 }}");
+
+        // Act
+        var result = action("");
+
+        result.Should().Be("This is a ");
+    }
+
     [Fact]
     public void Format_Template_Now()
     {