-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathServerInfoRefresherTests.cs
More file actions
233 lines (196 loc) · 10.6 KB
/
Copy pathServerInfoRefresherTests.cs
File metadata and controls
233 lines (196 loc) · 10.6 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
using Discord;
using NSubstitute;
using RustPlusBot.Discord.Posting;
using RustPlusBot.Domain.Workspace;
using RustPlusBot.Features.Workspace.Gateway;
using RustPlusBot.Features.Workspace.Reconciler;
using RustPlusBot.Features.Workspace.Registry;
using RustPlusBot.Persistence.Workspace;
namespace RustPlusBot.Features.Workspace.Tests.Reconciler;
public sealed class ServerInfoRefresherTests
{
private const ulong GuildId = 1;
private const ulong ChannelId = 500;
private const ulong MessageId = 900;
private static readonly Guid ServerId = Guid.NewGuid();
private static IWorkspaceStore StoreWith(params string[] keys)
{
var store = Substitute.For<IWorkspaceStore>();
store.GetCultureAsync(GuildId, Arg.Any<CancellationToken>()).Returns("en");
foreach (var key in keys)
{
store.GetMessageAsync(GuildId, ServerId, key, Arg.Any<CancellationToken>())
.Returns(new ProvisionedMessage
{
GuildId = GuildId,
RustServerId = ServerId,
MessageKey = key,
DiscordChannelId = ChannelId,
DiscordMessageId = MessageId,
});
}
return store;
}
[Fact]
public async Task First_refresh_edits_the_message()
{
var renderer = new StubRenderer(WorkspaceMessageKeys.ServerInfo, "v1");
var gateway = Substitute.For<IWorkspaceGateway>();
var reconciler = Substitute.For<IWorkspaceReconciler>();
var refresher = new ServerInfoRefresher(StoreWith(WorkspaceMessageKeys.ServerInfo), gateway, [renderer],
new RenderGate(), reconciler, Pacer());
await refresher.RefreshAsync(GuildId, ServerId, default);
await gateway.Received(1).EditMessageAsync(GuildId, ChannelId, MessageId, Arg.Any<MessagePayload>(),
Arg.Any<CancellationToken>());
}
[Fact]
public async Task Unchanged_render_is_not_sent_twice()
{
var renderer = new StubRenderer(WorkspaceMessageKeys.ServerInfo, "v1");
var gateway = Substitute.For<IWorkspaceGateway>();
var reconciler = Substitute.For<IWorkspaceReconciler>();
var refresher = new ServerInfoRefresher(StoreWith(WorkspaceMessageKeys.ServerInfo), gateway, [renderer],
new RenderGate(), reconciler, Pacer());
await refresher.RefreshAsync(GuildId, ServerId, default);
await refresher.RefreshAsync(GuildId, ServerId, default);
Assert.Equal(2, renderer.Calls);
await gateway.Received(1).EditMessageAsync(GuildId, ChannelId, MessageId, Arg.Any<MessagePayload>(),
Arg.Any<CancellationToken>());
}
[Fact]
public async Task Changed_render_is_sent_again()
{
var renderer = new StubRenderer(WorkspaceMessageKeys.ServerInfo, "v1");
var gateway = Substitute.For<IWorkspaceGateway>();
var reconciler = Substitute.For<IWorkspaceReconciler>();
var refresher = new ServerInfoRefresher(StoreWith(WorkspaceMessageKeys.ServerInfo), gateway, [renderer],
new RenderGate(), reconciler, Pacer());
await refresher.RefreshAsync(GuildId, ServerId, default);
renderer.Title = "v2";
await refresher.RefreshAsync(GuildId, ServerId, default);
await gateway.Received(2).EditMessageAsync(GuildId, ChannelId, MessageId, Arg.Any<MessagePayload>(),
Arg.Any<CancellationToken>());
}
[Fact]
public async Task Missing_message_row_escalates_to_full_reconcile()
{
var renderer = new StubRenderer(WorkspaceMessageKeys.ServerInfo, "v1");
var store = Substitute.For<IWorkspaceStore>();
store.GetCultureAsync(GuildId, Arg.Any<CancellationToken>()).Returns("en");
store.GetMessageAsync(GuildId, ServerId, Arg.Any<string>(), Arg.Any<CancellationToken>())
.Returns((ProvisionedMessage?)null);
var gateway = Substitute.For<IWorkspaceGateway>();
var reconciler = Substitute.For<IWorkspaceReconciler>();
var refresher = new ServerInfoRefresher(store, gateway, [renderer], new RenderGate(), reconciler, Pacer());
await refresher.RefreshAsync(GuildId, ServerId, default);
await reconciler.Received(1).ReconcileServerAsync(GuildId, ServerId, Arg.Any<CancellationToken>());
await gateway.DidNotReceive().EditMessageAsync(Arg.Any<ulong>(), Arg.Any<ulong>(), Arg.Any<ulong>(),
Arg.Any<MessagePayload>(), Arg.Any<CancellationToken>());
}
[Fact]
public async Task Edit_failure_escalates_and_invalidates_the_gate()
{
// This also stands in as the regression test for the missing-channel case: DiscordWorkspaceGateway's
// EditMessageAsync throws InvalidOperationException("Channel {id} not found in guild {id}.") when the
// channel is absent from the socket cache (symmetric with PostMessageAsync), rather than silently
// returning. ServerInfoRefresher's catch below is exception-type-agnostic, so a channel-missing throw
// is handled by the exact same escalate-and-invalidate path exercised here; a separate test with only
// a different exception message would exercise no new code and assert nothing new.
var renderer = new StubRenderer(WorkspaceMessageKeys.ServerInfo, "v1");
var gateway = Substitute.For<IWorkspaceGateway>();
gateway.EditMessageAsync(GuildId, ChannelId, MessageId, Arg.Any<MessagePayload>(),
Arg.Any<CancellationToken>())
.Returns(Task.FromException(
new InvalidOperationException($"Channel {ChannelId} not found in guild {GuildId}.")));
var reconciler = Substitute.For<IWorkspaceReconciler>();
var gate = new RenderGate();
var refresher = new ServerInfoRefresher(StoreWith(WorkspaceMessageKeys.ServerInfo), gateway, [renderer], gate,
reconciler, Pacer());
await refresher.RefreshAsync(GuildId, ServerId, default);
await reconciler.Received(1).ReconcileServerAsync(GuildId, ServerId, Arg.Any<CancellationToken>());
// Probe with the EXACT canonical of the render that was attempted (what the stub renderer built and
// ServerInfoRefresher tried to send), not an arbitrary literal. A dummy probe would pass even if the
// gate had wrongly committed the render before the edit landed — this one would not.
var attemptedCanonical = RenderCanonicalizer.Canonicalize(new EmbedBuilder().WithTitle("v1").Build(), null);
Assert.True(gate.ShouldSend(MessageId, attemptedCanonical));
}
[Fact]
public async Task Empty_payload_is_skipped_without_editing()
{
var renderer = new EmptyPayloadRenderer(WorkspaceMessageKeys.ServerInfo);
var gateway = Substitute.For<IWorkspaceGateway>();
var reconciler = Substitute.For<IWorkspaceReconciler>();
var refresher = new ServerInfoRefresher(StoreWith(WorkspaceMessageKeys.ServerInfo), gateway, [renderer],
new RenderGate(), reconciler, Pacer());
await refresher.RefreshAsync(GuildId, ServerId, default);
await gateway.DidNotReceive().EditMessageAsync(Arg.Any<ulong>(), Arg.Any<ulong>(), Arg.Any<ulong>(),
Arg.Any<MessagePayload>(), Arg.Any<CancellationToken>());
await reconciler.DidNotReceive().ReconcileServerAsync(Arg.Any<ulong>(), Arg.Any<Guid>(),
Arg.Any<CancellationToken>());
}
[Fact]
public async Task Refreshes_all_three_info_messages()
{
var renderers = new IMessageRenderer[]
{
new StubRenderer(WorkspaceMessageKeys.ServerInfo, "a"),
new StubRenderer(WorkspaceMessageKeys.ServerEvents, "b"),
new StubRenderer(WorkspaceMessageKeys.ServerTeam, "c"),
};
var store = StoreWith(WorkspaceMessageKeys.ServerInfo, WorkspaceMessageKeys.ServerEvents,
WorkspaceMessageKeys.ServerTeam);
var gateway = Substitute.For<IWorkspaceGateway>();
var refresher = new ServerInfoRefresher(store, gateway, renderers, new RenderGate(),
Substitute.For<IWorkspaceReconciler>(), Pacer());
await refresher.RefreshAsync(GuildId, ServerId, default);
Assert.All(renderers.Cast<StubRenderer>(), r => Assert.Equal(1, r.Calls));
}
[Fact]
public async Task Each_edit_is_paced_before_it_is_sent()
{
var renderer = new StubRenderer(WorkspaceMessageKeys.ServerInfo, "v1");
var gateway = Substitute.For<IWorkspaceGateway>();
var pacer = Pacer();
var refresher = new ServerInfoRefresher(StoreWith(WorkspaceMessageKeys.ServerInfo), gateway, [renderer],
new RenderGate(), Substitute.For<IWorkspaceReconciler>(), pacer);
await refresher.RefreshAsync(GuildId, ServerId, default);
Received.InOrder(() =>
{
_ = pacer.PaceAsync(ChannelId, Arg.Any<CancellationToken>());
_ = gateway.EditMessageAsync(GuildId, ChannelId, MessageId, Arg.Any<MessagePayload>(),
Arg.Any<CancellationToken>());
});
}
[Fact]
public async Task A_skipped_unchanged_render_is_not_paced()
{
var renderer = new StubRenderer(WorkspaceMessageKeys.ServerInfo, "v1");
var gateway = Substitute.For<IWorkspaceGateway>();
var pacer = Pacer();
var refresher = new ServerInfoRefresher(StoreWith(WorkspaceMessageKeys.ServerInfo), gateway, [renderer],
new RenderGate(), Substitute.For<IWorkspaceReconciler>(), pacer);
await refresher.RefreshAsync(GuildId, ServerId, default);
await refresher.RefreshAsync(GuildId, ServerId, default);
// Second render is identical, so the gate suppresses the edit — and the pace with it.
await pacer.Received(1).PaceAsync(ChannelId, Arg.Any<CancellationToken>());
}
private static IChannelEditPacer Pacer() => Substitute.For<IChannelEditPacer>();
private sealed class StubRenderer(string key, string title) : IMessageRenderer
{
public int Calls { get; private set; }
public string Title { get; set; } = title;
public string MessageKey => key;
public ValueTask<MessagePayload> RenderAsync(MessageRenderContext context, CancellationToken cancellationToken)
{
Calls++;
var embed = new EmbedBuilder().WithTitle(Title).Build();
return ValueTask.FromResult(new MessagePayload(null, embed, null));
}
}
private sealed class EmptyPayloadRenderer(string key) : IMessageRenderer
{
public string MessageKey => key;
public ValueTask<MessagePayload> RenderAsync(MessageRenderContext context, CancellationToken cancellationToken)
=> ValueTask.FromResult(new MessagePayload(null, null, null));
}
}