refactor: SonarQube code-smell & duplication cleanup (#25)

* chore(sonar): exclude EF migrations and obj from analysis

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* style: apply analyzer auto-fixes (collection init, var, switch expr, UTF-8 literals)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* refactor: extract repeated string literals into constants (S1192)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* refactor: move Abstractions.Connections types to matching namespace (IDE0130)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* refactor(localization): extract shared RustPlusBot.Localization (ILocalizer + DictionaryLocalizer)

Collapses 6 byte-identical per-feature localizer implementations into one
shared DictionaryLocalizer + ILocalizer in a new leaf project. The 6
per-feature interfaces are kept as thin markers extending the shared
ILocalizer, and each feature keeps a 1-line concrete localizer that
subclasses DictionaryLocalizer and implements its marker — so DI
registrations and ~30 consumers are unchanged and there is no last-wins
DI collision in the composed host container.

Resolves the in-code 'consolidate into a shared project' TODO.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* refactor(workspace): collapse channel locators onto shared CachingChannelLocator

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* refactor(discord): extract shared poster boilerplate into DiscordChannelMessenger

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* refactor: bundle cohesive dependencies to satisfy S107 parameter limit

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* refactor: extract helpers to reduce cognitive complexity below 15 (S3776)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

Author: HandyS11

.github/workflows/Sonar.yml

@@ -60,7 +60,7 @@ jobs:
 
       - name: Build and analyze
         run: |
-          ./.sonar/scanner/dotnet-sonarscanner begin /k:"${{ secrets.SONAR_PROJECT_KEY }}" /d:sonar.token="${{ secrets.SONAR_TOKEN }}" /d:sonar.host.url="${{ secrets.SONAR_HOST_URL }}" /d:sonar.coverage.exclusions="**/tests/**" /d:sonar.cs.opencover.reportsPaths="**/coverage.opencover.xml"
+          ./.sonar/scanner/dotnet-sonarscanner begin /k:"${{ secrets.SONAR_PROJECT_KEY }}" /d:sonar.token="${{ secrets.SONAR_TOKEN }}" /d:sonar.host.url="${{ secrets.SONAR_HOST_URL }}" /d:sonar.coverage.exclusions="**/tests/**" /d:sonar.cs.opencover.reportsPaths="**/coverage.opencover.xml" /d:sonar.cpd.exclusions="**/Migrations/*.cs" /d:sonar.exclusions="**/Migrations/*.cs,**/obj/**,**/bin/**"
           dotnet build --no-restore --configuration Release
           dotnet test --no-build --configuration Release --collect:"XPlat Code Coverage;Format=opencover" --blame-hang-timeout 60s
           ./.sonar/scanner/dotnet-sonarscanner end /d:sonar.token="${{ secrets.SONAR_TOKEN }}"

Directory.Packages.props

@@ -10,6 +10,7 @@
     <PackageVersion Include="Microsoft.EntityFrameworkCore.Sqlite" Version="10.0.9" />
     <PackageVersion Include="Microsoft.Extensions.Hosting" Version="10.0.9" />
     <PackageVersion Include="Microsoft.Extensions.Hosting.Abstractions" Version="10.0.9" />
+    <PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.9" />
     <PackageVersion Include="Persistord.Core" Version="1.0.0-beta.1" />
     <PackageVersion Include="RustPlusApi" Version="2.0.0-beta.3" />
     <PackageVersion Include="RustPlusApi.Fcm" Version="2.0.0-beta.3" />

RustPlusBot.slnx

@@ -14,6 +14,7 @@
     <Project Path="src/RustPlusBot.Features.Players/RustPlusBot.Features.Players.csproj" />
     <Project Path="src/RustPlusBot.Features.Switches/RustPlusBot.Features.Switches.csproj" />
     <Project Path="src/RustPlusBot.Features.Workspace/RustPlusBot.Features.Workspace.csproj" />
+    <Project Path="src/RustPlusBot.Localization/RustPlusBot.Localization.csproj" />
     <Project Path="src/RustPlusBot.Persistence/RustPlusBot.Persistence.csproj" />
   </Folder>
   <Folder Name="/tests/">
@@ -28,6 +29,7 @@
     <Project Path="tests/RustPlusBot.Features.Alarms.Tests/RustPlusBot.Features.Alarms.Tests.csproj" />
     <Project Path="tests/RustPlusBot.Features.Chat.Tests/RustPlusBot.Features.Chat.Tests.csproj" />
     <Project Path="tests/RustPlusBot.Features.Events.Tests/RustPlusBot.Features.Events.Tests.csproj" />
+    <Project Path="tests/RustPlusBot.Localization.Tests/RustPlusBot.Localization.Tests.csproj" />
     <Project Path="tests/RustPlusBot.Persistence.Tests/RustPlusBot.Persistence.Tests.csproj" />
   </Folder>
 </Solution>

src/RustPlusBot.Abstractions/Connections/IRustServerQuery.cs

@@ -1,4 +1,4 @@
-namespace RustPlusBot.Features.Connections.Listening;
+namespace RustPlusBot.Abstractions.Connections;
 
 /// <summary>Reads live data from a connected server's socket (implemented by the connection supervisor).</summary>
 public interface IRustServerQuery

src/RustPlusBot.Abstractions/Connections/MapDimensions.cs

@@ -1,4 +1,4 @@
-namespace RustPlusBot.Features.Connections.Listening;
+namespace RustPlusBot.Abstractions.Connections;
 
 /// <summary>The static-per-wipe map size needed to convert world coordinates to a grid reference.</summary>
 /// <param name="Width">Map image width.</param>

src/RustPlusBot.Abstractions/Connections/MapMarkerSnapshot.cs

@@ -1,4 +1,4 @@
-namespace RustPlusBot.Features.Connections.Listening;
+namespace RustPlusBot.Abstractions.Connections;
 
 /// <summary>One map marker observed in a <c>GetMapMarkers</c> poll.</summary>
 /// <param name="Id">The stable marker id (used to diff polls).</param>

src/RustPlusBot.Abstractions/Connections/MarkerKind.cs

@@ -1,4 +1,4 @@
-namespace RustPlusBot.Features.Connections.Listening;
+namespace RustPlusBot.Abstractions.Connections;
 
 /// <summary>The subset of Rust map-marker types this bot reasons about; everything else is <see cref="Other"/>.</summary>
 public enum MarkerKind

src/RustPlusBot.Abstractions/Connections/MonumentSnapshot.cs

@@ -1,4 +1,4 @@
-namespace RustPlusBot.Features.Connections.Listening;
+namespace RustPlusBot.Abstractions.Connections;
 
 /// <summary>One named monument observed in a <c>GetMap</c> response.</summary>
 /// <param name="Token">The monument token (e.g. <c>oilrig_1</c>, <c>large_oil_rig</c>).</param>

src/RustPlusBot.Abstractions/Connections/ServerInfoSnapshot.cs

@@ -1,4 +1,4 @@
-namespace RustPlusBot.Features.Connections.Listening;
+namespace RustPlusBot.Abstractions.Connections;
 
 /// <summary>A point-in-time view of a server's population and wipe, decoupled from RustPlusApi types.</summary>
 /// <param name="Players">Current player count.</param>

src/RustPlusBot.Abstractions/Connections/ServerTimeSnapshot.cs

@@ -1,4 +1,4 @@
-namespace RustPlusBot.Features.Connections.Listening;
+namespace RustPlusBot.Abstractions.Connections;
 
 /// <summary>A point-in-time view of in-game time, decoupled from RustPlusApi types.</summary>
 /// <param name="TimeOfDay">Current in-game time of day (RustPlusApi <c>TimeInfo.Time</c>).</param>