refactor(alarms): extract IAlarmLocalizer + fix stale catalog doc

Fix 1: Update stale XML comment on AlarmLocalizationCatalog.Default to reference the actual per-slice AlarmLocalizer constructor instead of non-existent shared ILocalizer type.

Fix 2: Extract IAlarmLocalizer interface (matching ISwitchLocalizer pattern) with Get(key, culture) and Get(key, culture, params args) methods. Make AlarmLocalizer implement it with <inheritdoc /> on public methods. Update AlarmEmbedRenderer ctor to accept IAlarmLocalizer instead of concrete AlarmLocalizer.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: HandyS11

src/RustPlusBot.Features.Alarms/Rendering/AlarmEmbedRenderer.cs

@@ -8,7 +8,7 @@ namespace RustPlusBot.Features.Alarms.Rendering;
 /// <summary>Renders a Smart Alarm as a Discord embed + control row, and the pairing-prompt embed + row. Pure.</summary>
 /// <param name="localizer">The alarm localizer.</param>
 /// <param name="clock">The clock used to compute relative trigger times.</param>
-internal sealed class AlarmEmbedRenderer(AlarmLocalizer localizer, IClock clock)
+internal sealed class AlarmEmbedRenderer(IAlarmLocalizer localizer, IClock clock)
 {
     /// <summary>Renders the alarm embed and its control buttons.</summary>
     /// <param name="alarm">The alarm to render.</param>

src/RustPlusBot.Features.Alarms/Rendering/AlarmLocalizationCatalog.cs

@@ -2,8 +2,8 @@ namespace RustPlusBot.Features.Alarms.Rendering;
 
 /// <summary>
 /// The in-memory string catalog for Smart Alarms: culture → (key → value).
-/// English is the fallback. Intended to be passed directly to the shared
-/// <c>RustPlusBot.Discord.Localization.ILocalizer</c> constructor.
+/// English is the fallback. Intended to be passed to the per-slice
+/// <see cref="AlarmLocalizer"/> constructor.
 /// </summary>
 internal static class AlarmLocalizationCatalog
 {

src/RustPlusBot.Features.Alarms/Rendering/AlarmLocalizer.cs

@@ -5,13 +5,11 @@ namespace RustPlusBot.Features.Alarms.Rendering;
 /// <summary>Dictionary-backed localizer for Smart Alarms with English fallback and region normalization.</summary>
 /// <remarks>Mirrors the SwitchLocalizer pattern; a future refactor may hoist a shared implementation.</remarks>
 /// <param name="catalog">The culture → (key → value) catalog.</param>
-internal sealed class AlarmLocalizer(IReadOnlyDictionary<string, IReadOnlyDictionary<string, string>> catalog)
+internal sealed class AlarmLocalizer(IReadOnlyDictionary<string, IReadOnlyDictionary<string, string>> catalog) : IAlarmLocalizer
 {
     private const string FallbackCulture = "en";
 
-    /// <summary>Gets the localized string for a key, or the key itself if not found.</summary>
-    /// <param name="key">The string key to resolve.</param>
-    /// <param name="culture">The BCP-47 culture tag (e.g. "en", "fr").</param>
+    /// <inheritdoc />
     public string Get(string key, string culture)
     {
         var normalized = Normalize(culture);
@@ -29,10 +27,7 @@ public string Get(string key, string culture)
         return key;
     }
 
-    /// <summary>Gets the localized, <see cref="string.Format(IFormatProvider, string, object?[])"/>-applied string.</summary>
-    /// <param name="key">The string key to resolve.</param>
-    /// <param name="culture">The BCP-47 culture tag (e.g. "en", "fr").</param>
-    /// <param name="args">Format arguments.</param>
+    /// <inheritdoc />
     public string Get(string key, string culture, params object[] args)
     {
         var format = Get(key, culture);

src/RustPlusBot.Features.Alarms/Rendering/IAlarmLocalizer.cs

@@ -0,0 +1,16 @@
+namespace RustPlusBot.Features.Alarms.Rendering;
+
+/// <summary>Resolves localized smart-alarm strings by key and culture, falling back to English.</summary>
+internal interface IAlarmLocalizer
+{
+    /// <summary>Gets the localized string for a key, or the key itself if not found.</summary>
+    /// <param name="key">The string key.</param>
+    /// <param name="culture">The BCP-47 culture tag (e.g. "en", "fr").</param>
+    string Get(string key, string culture);
+
+    /// <summary>Gets the localized, format-applied string.</summary>
+    /// <param name="key">The string key.</param>
+    /// <param name="culture">The BCP-47 culture tag.</param>
+    /// <param name="args">Format arguments.</param>
+    string Get(string key, string culture, params object[] args);
+}