feat(generator): validate decay + upkeep (6b)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: HandyS11

tests/RustPlusBot.ItemData.Generator.Tests/DatasetValidatorTests.cs

@@ -56,4 +56,43 @@ public void UnresolvableCraftIngredientId_isError()
         var errors = DatasetValidator.Validate(bad, new ValidationOptions(MinItemCount: 1));
         Assert.Contains(errors, e => e.Contains("88888", StringComparison.Ordinal));
     }
+
+    /// <summary>An upkeep entry that references an unknown item id should produce an error.</summary>
+    [Fact]
+    public void UnresolvableUpkeepId_isError()
+    {
+        var bad = new ItemDataset(2, Good().Sources,
+        [
+            new ItemRecord(1, "Wooden Door", 1, null, null, null, null, null,
+                new UpkeepCost([new UpkeepEntry(77777, 8, 25)])),
+        ]);
+        var errors = DatasetValidator.Validate(bad, new ValidationOptions(MinItemCount: 1));
+        Assert.Contains(errors, e => e.Contains("77777", StringComparison.Ordinal));
+    }
+
+    /// <summary>An upkeep entry with min greater than max should produce an error.</summary>
+    [Fact]
+    public void UpkeepMinGreaterThanMax_isError()
+    {
+        var bad = new ItemDataset(2, Good().Sources,
+        [
+            new ItemRecord(1, "Wooden Door", 1, null, null, null, null, null,
+                new UpkeepCost([new UpkeepEntry(1, 25, 8)])),
+        ]);
+        var errors = DatasetValidator.Validate(bad, new ValidationOptions(MinItemCount: 1));
+        Assert.Contains(errors, e => e.Contains("upkeep", StringComparison.OrdinalIgnoreCase));
+    }
+
+    /// <summary>Negative decay seconds should produce an error.</summary>
+    [Fact]
+    public void NegativeDecay_isError()
+    {
+        var bad = new ItemDataset(2, Good().Sources,
+        [
+            new ItemRecord(1, "Stone Barricade", 1, null, null, null, null,
+                new DecayInfo(-900, null, null, null, 100), null),
+        ]);
+        var errors = DatasetValidator.Validate(bad, new ValidationOptions(MinItemCount: 1));
+        Assert.Contains(errors, e => e.Contains("decay", StringComparison.OrdinalIgnoreCase));
+    }
 }

tools/RustPlusBot.ItemData.Generator/Validation/DatasetValidator.cs

@@ -46,6 +46,34 @@ public static IReadOnlyList<string> Validate(ItemDataset dataset, ValidationOpti
             }
         }
 
+        foreach (var item in dataset.Items.Where(i => i.Upkeep is not null))
+        {
+            foreach (var entry in item.Upkeep!.Entries)
+            {
+                if (!ids.Contains(entry.ItemId))
+                {
+                    errors.Add(
+                        $"item {item.Id} ({item.Name}): upkeep references unknown id {entry.ItemId}");
+                }
+
+                if (entry.QuantityMin > entry.QuantityMax)
+                {
+                    errors.Add(
+                        $"item {item.Id} ({item.Name}): upkeep quantity min {entry.QuantityMin} > max {entry.QuantityMax}");
+                }
+            }
+        }
+
+        foreach (var item in dataset.Items.Where(i => i.Decay is not null))
+        {
+            var decay = item.Decay!;
+            if (decay.Seconds is < 0 || decay.OutsideSeconds is < 0 || decay.InsideSeconds is < 0 ||
+                decay.UnderwaterSeconds is < 0 || decay.Hp is < 0)
+            {
+                errors.Add($"item {item.Id} ({item.Name}): decay has a negative value");
+            }
+        }
+
         return errors;
     }
 }