Bump Microsoft.VisualStudio.Threading.Analyzers from 17.14.15 to 18.7.23 (#34)

* Bump Microsoft.VisualStudio.Threading.Analyzers from 17.14.15 to 18.7.23

---
updated-dependencies:
- dependency-name: Microsoft.VisualStudio.Threading.Analyzers
  dependency-version: 18.7.23
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Suppress VSTHRD103 false positive for EF Core DbSet.Add

VS.Threading.Analyzers 18.x flags synchronous DbSet<T>.Add as
"Add synchronously blocks; await AddAsync instead" (VSTHRD103) because
DbSet also exposes AddAsync. This is a false positive: EF Core's Add does
not block; AddAsync only matters for special value generators. With
TreatWarningsAsErrors the 17.14.15 -> 18.7.23 bump broke the build (src
plus the EF-using test projects once src compiled).

Scope severity=none to src/RustPlusBot.Persistence (the only production
DbSet.Add sites) and to tests/** (test EF setup), keeping VSTHRD103
active everywhere else.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: HandyS11 <valentin-clergue@orange.fr>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

Author: 3 people

.editorconfig

@@ -475,6 +475,10 @@ dotnet_diagnostic.CS1591.severity = none # XML docs not required in sample apps
 dotnet_diagnostic.CA2007.severity = none # ConfigureAwait not required in test projects
 dotnet_diagnostic.CS1591.severity = none # XML docs not required in test projects
 dotnet_diagnostic.VSTHRD003.severity = none # Awaiting stored Task fields is acceptable in test infrastructure
+dotnet_diagnostic.VSTHRD103.severity = none # EF Core DbSet.Add is not blocking; false positive from VS.Threading.Analyzers 18.x (see src/RustPlusBot.Persistence)
 
 [tools/**]
 dotnet_diagnostic.CS1591.severity = none # XML docs not required in internal tooling
+
+[src/RustPlusBot.Persistence/**]
+dotnet_diagnostic.VSTHRD103.severity = none # EF Core DbSet.Add is not blocking; AddAsync only matters for special value generators. False positive from VS.Threading.Analyzers 18.x.

Directory.Packages.props

@@ -34,7 +34,7 @@
   <ItemGroup>
     <!-- Analyzers -->
     <PackageVersion Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="10.0.301" />
-    <PackageVersion Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.14.15" />
+    <PackageVersion Include="Microsoft.VisualStudio.Threading.Analyzers" Version="18.7.23" />
     <PackageVersion Include="Roslynator.Analyzers" Version="4.15.0" />
     <PackageVersion Include="Roslynator.Formatting.Analyzers" Version="4.15.0" />
     <PackageVersion Include="SonarAnalyzer.CSharp" Version="10.27.0.140913" />