fix(review): address Copilot comments on PR #45

- DiscordWorkspaceGateway.DeleteMessageAsync forwards the cancellation token
  via RequestOptions.CancelToken instead of ignoring it.
- Correct the stale DI comment: with no RustMaps API key the #info map
  renderer returns an empty payload (no message), not a placeholder.
- RustMapsParityTests orders the fixture enumeration so the selected fixture
  is deterministic across filesystems.
- MapParity CLI uses TryParse for numeric args and prints the usage line on
  invalid input instead of throwing.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: HandyS11

src/RustPlusBot.Features.Workspace/Gateway/DiscordWorkspaceGateway.cs

@@ -153,7 +153,11 @@ public async Task DeleteMessageAsync(ulong guildId,
 
         try
         {
-            await channel.DeleteMessageAsync(messageId).ConfigureAwait(false);
+            await channel.DeleteMessageAsync(messageId, new RequestOptions
+                {
+                    CancelToken = cancellationToken
+                })
+                .ConfigureAwait(false);
         }
         catch (HttpException ex) when (ex.HttpCode == System.Net.HttpStatusCode.NotFound)
         {

src/RustPlusBot.Features.Workspace/WorkspaceServiceCollectionExtensions.cs

@@ -43,8 +43,8 @@ public static IServiceCollection AddWorkspace(this IServiceCollection services)
         // the host must compose both AddWorkspace and AddConnections.
         services.AddScoped<IMessageRenderer, ServerInfoMessageRenderer>();
         // ServerInfoMapMessageRenderer takes IInfoMapReadModel as an OPTIONAL dependency: it only resolves
-        // when Features.Map registered it (RustMaps API key present); otherwise the renderer shows the
-        // "preparing" placeholder forever.
+        // when Features.Map registered it (RustMaps API key present); otherwise the renderer returns an
+        // empty payload and the reconciler never posts a map message.
         services.AddScoped<IMessageRenderer, ServerInfoMapMessageRenderer>();
         services.AddScoped<IMessageRenderer, MapControlMessageRenderer>();
 

tests/RustPlusBot.Features.Map.Tests/RustMapsParityTests.cs

@@ -17,8 +17,9 @@ public sealed class RustMapsParityTests
     [SkippableFact]
     public void Monument_world_coords_project_into_consistent_grid_cells()
     {
+        // Order the enumeration so the selected fixture is deterministic across machines/filesystems.
         var fixture = Directory.Exists(FixtureDir)
-            ? Directory.EnumerateFiles(FixtureDir, "rustmaps-*.json").FirstOrDefault()
+            ? Directory.EnumerateFiles(FixtureDir, "rustmaps-*.json").Order(StringComparer.Ordinal).FirstOrDefault()
             : null;
         Skip.If(fixture is null, "No RustMaps fixture committed yet (run tools/RustPlusBot.MapParity).");
 

tools/RustPlusBot.MapParity/Program.cs

@@ -8,14 +8,14 @@
 using SixLabors.ImageSharp.PixelFormats;
 using SixLabors.ImageSharp.Processing;
 
-if (args.Length < 4)
+if (args.Length < 4
+    || !int.TryParse(args[0], NumberStyles.Integer, CultureInfo.InvariantCulture, out var size)
+    || !int.TryParse(args[1], NumberStyles.Integer, CultureInfo.InvariantCulture, out var seed))
 {
     await Console.Error.WriteLineAsync("Usage: map-parity <worldSize> <seed> <apiKey> <outDir>").ConfigureAwait(false);
     return 1;
 }
 
-var size = int.Parse(args[0], CultureInfo.InvariantCulture);
-var seed = int.Parse(args[1], CultureInfo.InvariantCulture);
 var apiKey = args[2];
 var outDir = Directory.CreateDirectory(args[3]).FullName;