refactor: extract helpers to reduce cognitive complexity below 15 (S3776)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: HandyS11

src/RustPlusBot.Features.Connections/Supervisor/ConnectionSupervisor.cs

@@ -491,24 +491,7 @@ void OnSmartDevice(object? sender, SmartDeviceTrigger trigger)
             CancellationToken.None);
         try
         {
-            while (!ct.IsCancellationRequested)
-            {
-                await Task.Delay(_options.HeartbeatInterval, ct).ConfigureAwait(false);
-                var beat = await connection.GetInfoAsync(_options.HeartbeatTimeout, ct).ConfigureAwait(false);
-                switch (beat.Kind)
-                {
-                    case HeartbeatKind.Ok:
-                        await PublishStatusAsync(key, ConnectionStatus.Connected, beat.PlayerCount, credentialId, ct)
-                            .ConfigureAwait(false);
-                        break;
-                    case HeartbeatKind.AuthRejected:
-                        return ReconnectReason.AuthRejected;
-                    default:
-                        return ReconnectReason.Unreachable;
-                }
-            }
-
-            return ReconnectReason.Stopped;
+            return await RunHeartbeatLoopAsync(key, connection, credentialId, ct).ConfigureAwait(false);
         }
         finally
         {
@@ -530,6 +513,32 @@ await PublishStatusAsync(key, ConnectionStatus.Connected, beat.PlayerCount, cred
         }
     }
 
+    private async Task<ReconnectReason> RunHeartbeatLoopAsync(
+        (ulong Guild, Guid Server) key,
+        IRustServerConnection connection,
+        Guid credentialId,
+        CancellationToken ct)
+    {
+        while (!ct.IsCancellationRequested)
+        {
+            await Task.Delay(_options.HeartbeatInterval, ct).ConfigureAwait(false);
+            var beat = await connection.GetInfoAsync(_options.HeartbeatTimeout, ct).ConfigureAwait(false);
+            switch (beat.Kind)
+            {
+                case HeartbeatKind.Ok:
+                    await PublishStatusAsync(key, ConnectionStatus.Connected, beat.PlayerCount, credentialId, ct)
+                        .ConfigureAwait(false);
+                    break;
+                case HeartbeatKind.AuthRejected:
+                    return ReconnectReason.AuthRejected;
+                default:
+                    return ReconnectReason.Unreachable;
+            }
+        }
+
+        return ReconnectReason.Stopped;
+    }
+
     private async Task PollMarkersAsync(
         (ulong Guild, Guid Server) key,
         IRustServerConnection connection,

src/RustPlusBot.Features.Map/Rendering/MapRenderer.cs

@@ -189,34 +189,42 @@ private static void DrawPlayers(Image<Rgba32> image, IReadOnlyList<PlayerPlaceme
         {
             foreach (var player in players)
             {
-                var isActive = player is { IsAlive: true, IsOnline: true };
-
-                if (icon is not null)
-                {
-                    ctx.DrawImage(icon, CenterAt(player.PixelX, player.PixelY, icon), 1f);
-                }
-                else
-                {
-                    var dotColor = isActive ? Color.LimeGreen : Color.Gray;
-                    var dot = new EllipsePolygon(player.PixelX, player.PixelY, PlayerRadius);
-                    ctx.Fill(dotColor, dot);
-                    ctx.Draw(Color.Black, OutlinePenWidth, dot);
-                }
-
-                var suffix = player.IsAlive ? " (offline)" : " (dead)";
-                var label = isActive ? player.Name : player.Name + suffix;
-                var labelColor = isActive ? Color.White : Color.Gray;
-                var textOptions = new RichTextOptions(Font)
-                {
-                    Origin = new PointF(player.PixelX, player.PixelY + PlayerLabelOffset),
-                    HorizontalAlignment = HorizontalAlignment.Center,
-                    VerticalAlignment = VerticalAlignment.Top,
-                };
-                ctx.DrawText(textOptions, label, labelColor);
+                DrawPlayerIcon(ctx, player, icon);
+                DrawPlayerLabel(ctx, player);
             }
         });
     }
 
+    private static void DrawPlayerIcon(IImageProcessingContext ctx, PlayerPlacement player, Image<Rgba32>? icon)
+    {
+        if (icon is not null)
+        {
+            ctx.DrawImage(icon, CenterAt(player.PixelX, player.PixelY, icon), 1f);
+            return;
+        }
+
+        var isActive = player is { IsAlive: true, IsOnline: true };
+        var dotColor = isActive ? Color.LimeGreen : Color.Gray;
+        var dot = new EllipsePolygon(player.PixelX, player.PixelY, PlayerRadius);
+        ctx.Fill(dotColor, dot);
+        ctx.Draw(Color.Black, OutlinePenWidth, dot);
+    }
+
+    private static void DrawPlayerLabel(IImageProcessingContext ctx, PlayerPlacement player)
+    {
+        var isActive = player is { IsAlive: true, IsOnline: true };
+        var suffix = player.IsAlive ? " (offline)" : " (dead)";
+        var label = isActive ? player.Name : player.Name + suffix;
+        var labelColor = isActive ? Color.White : Color.Gray;
+        var textOptions = new RichTextOptions(Font)
+        {
+            Origin = new PointF(player.PixelX, player.PixelY + PlayerLabelOffset),
+            HorizontalAlignment = HorizontalAlignment.Center,
+            VerticalAlignment = VerticalAlignment.Top,
+        };
+        ctx.DrawText(textOptions, label, labelColor);
+    }
+
     private static Point CenterAt(float x, float y, Image<Rgba32> icon) =>
         new((int)(x - (icon.Width / 2f)), (int)(y - (icon.Height / 2f)));
 }

src/RustPlusBot.Features.Workspace/Messages/ServerInfoMessageRenderer.cs

@@ -66,22 +66,7 @@ public async ValueTask<MessagePayload> RenderAsync(MessageRenderContext context,
 
         if (status == ConnectionStatus.Connected)
         {
-            var team = await query.GetTeamInfoAsync(context.GuildId, serverId, cancellationToken).ConfigureAwait(false);
-            if (team is not null)
-            {
-                var online = team.Members.Count(m => m.IsOnline);
-                var leaderEntry = team.Members.FirstOrDefault(m => m.SteamId == team.LeaderSteamId);
-                // The API can report a member with no display name, so treat an empty name as missing.
-                var leaderName = string.IsNullOrWhiteSpace(leaderEntry?.Name)
-                    ? team.LeaderSteamId.ToString(CultureInfo.InvariantCulture)
-                    : leaderEntry.Name;
-                embed.AddField(
-                    localizer.Get("server.info.team.label", context.Culture),
-                    localizer.Get("server.info.team.value", context.Culture,
-                        online.ToString(CultureInfo.InvariantCulture),
-                        team.Members.Count.ToString(CultureInfo.InvariantCulture),
-                        leaderName));
-            }
+            await AddTeamFieldAsync(embed, context, serverId, cancellationToken).ConfigureAwait(false);
         }
 
         var eligible = pool
@@ -113,6 +98,32 @@ public async ValueTask<MessagePayload> RenderAsync(MessageRenderContext context,
         return new MessagePayload(null, embed.Build(), builder.Build());
     }
 
+    private async ValueTask AddTeamFieldAsync(
+        EmbedBuilder embed,
+        MessageRenderContext context,
+        Guid serverId,
+        CancellationToken cancellationToken)
+    {
+        var team = await query.GetTeamInfoAsync(context.GuildId, serverId, cancellationToken).ConfigureAwait(false);
+        if (team is null)
+        {
+            return;
+        }
+
+        var online = team.Members.Count(m => m.IsOnline);
+        var leaderEntry = team.Members.FirstOrDefault(m => m.SteamId == team.LeaderSteamId);
+        // The API can report a member with no display name, so treat an empty name as missing.
+        var leaderName = string.IsNullOrWhiteSpace(leaderEntry?.Name)
+            ? team.LeaderSteamId.ToString(CultureInfo.InvariantCulture)
+            : leaderEntry.Name;
+        embed.AddField(
+            localizer.Get("server.info.team.label", context.Culture),
+            localizer.Get("server.info.team.value", context.Culture,
+                online.ToString(CultureInfo.InvariantCulture),
+                team.Members.Count.ToString(CultureInfo.InvariantCulture),
+                leaderName));
+    }
+
     private static string Glyph(ConnectionStatus status) => status switch
     {
         ConnectionStatus.Connected => "🟢",