From f6a1c698d2d6f3487809a64760dc5869f3cd0809 Mon Sep 17 00:00:00 2001
From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com>
Date: Sun, 28 Jun 2026 22:44:04 +0000
Subject: [PATCH 1/2] Bump Microsoft.VisualStudio.Threading.Analyzers from
 17.14.15 to 18.7.23

---
updated-dependencies:
- dependency-name: Microsoft.VisualStudio.Threading.Analyzers
  dependency-version: 18.7.23
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
---
 Directory.Packages.props | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Directory.Packages.props b/Directory.Packages.props
index af61d2ff..d2ab63c8 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -34,7 +34,7 @@
   <ItemGroup>
     <!-- Analyzers -->
     <PackageVersion Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="10.0.301" />
-    <PackageVersion Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.14.15" />
+    <PackageVersion Include="Microsoft.VisualStudio.Threading.Analyzers" Version="18.7.23" />
     <PackageVersion Include="Roslynator.Analyzers" Version="4.15.0" />
     <PackageVersion Include="Roslynator.Formatting.Analyzers" Version="4.15.0" />
     <PackageVersion Include="SonarAnalyzer.CSharp" Version="10.27.0.140913" />

From 8532f94405cdb71c59bec8072e364a68caff0914 Mon Sep 17 00:00:00 2001
From: HandyS11 <valentin-clergue@orange.fr>
Date: Mon, 29 Jun 2026 19:05:34 +0200
Subject: [PATCH 2/2] Suppress VSTHRD103 false positive for EF Core DbSet.Add

VS.Threading.Analyzers 18.x flags synchronous DbSet<T>.Add as
"Add synchronously blocks; await AddAsync instead" (VSTHRD103) because
DbSet also exposes AddAsync. This is a false positive: EF Core's Add does
not block; AddAsync only matters for special value generators. With
TreatWarningsAsErrors the 17.14.15 -> 18.7.23 bump broke the build (src
plus the EF-using test projects once src compiled).

Scope severity=none to src/RustPlusBot.Persistence (the only production
DbSet.Add sites) and to tests/** (test EF setup), keeping VSTHRD103
active everywhere else.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---
 .editorconfig | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/.editorconfig b/.editorconfig
index 701b6b7d..b1b7658d 100644
--- a/.editorconfig
+++ b/.editorconfig
@@ -475,6 +475,10 @@ dotnet_diagnostic.CS1591.severity = none # XML docs not required in sample apps
 dotnet_diagnostic.CA2007.severity = none # ConfigureAwait not required in test projects
 dotnet_diagnostic.CS1591.severity = none # XML docs not required in test projects
 dotnet_diagnostic.VSTHRD003.severity = none # Awaiting stored Task fields is acceptable in test infrastructure
+dotnet_diagnostic.VSTHRD103.severity = none # EF Core DbSet.Add is not blocking; false positive from VS.Threading.Analyzers 18.x (see src/RustPlusBot.Persistence)
 
 [tools/**]
 dotnet_diagnostic.CS1591.severity = none # XML docs not required in internal tooling
+
+[src/RustPlusBot.Persistence/**]
+dotnet_diagnostic.VSTHRD103.severity = none # EF Core DbSet.Add is not blocking; AddAsync only matters for special value generators. False positive from VS.Threading.Analyzers 18.x.